Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 927659 - media-sound/audacity-3.4.2: missing depend media-libs/opusfile
Summary: media-sound/audacity-3.4.2: missing depend media-libs/opusfile
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Professional Audio Applications Maintainers
URL:
Whiteboard:
Keywords: PullRequest
: 928737 (view as bug list)
Depends on:
Blocks:
 
Reported: 2024-03-24 07:15 UTC by vowstar
Modified: 2024-04-16 22:57 UTC (History)
14 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,19.36 KB, text/x-log)
2024-03-24 07:16 UTC, vowstar
Details
audacity-3.4.2.ebuild (audacity-3.4.2.ebuild,6.59 KB, application/vnd.gentoo.ebuild)
2024-04-03 02:15 UTC, Alex Barker
Details

Note You need to log in before you can comment on or make changes to this bug.
Description vowstar 2024-03-24 07:15:48 UTC
Build failed by error below.

Error at cmake-proxies/cmake-modules/AudacityFunctions.cmake:569 (target_link_libraries):
  Target "mod-opus" links to:

    opusfile::opusfile

  but the target was not found.  Possible reasons include:

    * There is a typo in the target name.
    * A find_package call is missing for an IMPORTED target.
    * An ALIAS target is missing.

Reproducible: Always

Steps to Reproduce:
1. Make sure media-libs/opusfile not installed yet.
2. Install media-sound/audacity with/without opus use flag
3. Build failed, and media-libs/opusfile not as depend.
Comment 1 vowstar 2024-03-24 07:16:51 UTC
Created attachment 888343 [details]
build.log
Comment 2 vowstar 2024-03-24 07:17:43 UTC
Add depend media-libs/opusfile as depend fixed this issue.
Comment 3 vowstar 2024-03-24 07:22:43 UTC
media-libs/opusfile is a hard depend, without media-libs/opusfile, even disable opus use flag, it also failed to build.
Comment 4 Gary E. Miller 2024-03-24 18:59:34 UTC
#MeToo
Comment 5 Aliaksei Urbanski 2024-03-24 22:02:01 UTC
(In reply to vowstar from comment #3)
> media-libs/opusfile is a hard depend, without media-libs/opusfile, even
> disable opus use flag, it also failed to build.

It looks like it's a bit more complicated.
In order to reproduce this bug, USE="ogg" is required.
It isn't reproducible with USE="-ogg".
Comment 6 Amit Ugol 2024-03-25 05:54:59 UTC
Same here.
Re ogg, its a part of the desktop profile so I assume many people have it enabled by default; hence media-libs/opusfile is a logical requirement.

# grep ogg /var/db/repos/gentoo/profiles/targets/desktop/make.defaults
USE="a52 aac acpi alsa bluetooth branding cairo cdda cdr cups dbus dri dts dvd dvdr elogind encode exif flac gif gpm gtk gui icu jpeg lcms libnotify mad mng mp3 mp4 mpeg ogg opengl pango pdf png policykit ppds qt5 sdl sound spell startup-notification svg tiff truetype vorbis udev udisks unicode upower usb vulkan wxwidgets X xcb xft x264 xml xv xvid"
Comment 7 Alex Barker 2024-04-03 02:15:10 UTC
Created attachment 889304 [details]
audacity-3.4.2.ebuild

I think it's that easy.
Comment 8 Aliaksei Urbanski 2024-04-03 09:29:05 UTC
(In reply to Alex Barker from comment #7)
> Created attachment 889304 [details]
> audacity-3.4.2.ebuild
> 
> I think it's that easy.

Hello Alex,

No, it isn't. You probably didn't notice the PRs linked to this issues.
Please take a look at changes and the conversation at https://github.com/gentoo/gentoo/pull/35903.

Best regards!
Comment 9 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-04-06 16:21:41 UTC
*** Bug 928737 has been marked as a duplicate of this bug. ***
Comment 10 Larry the Git Cow gentoo-dev 2024-04-16 22:57:23 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=72e8c24fcd0beb997a88f7d185a02a212abafe37

commit 72e8c24fcd0beb997a88f7d185a02a212abafe37
Author:     Aliaksei Urbanski <aliaksei.urbanski@gmail.com>
AuthorDate: 2024-04-16 19:03:31 +0000
Commit:     Yixun Lan <dlan@gentoo.org>
CommitDate: 2024-04-16 22:53:49 +0000

    media-sound/audacity: fix various issues
    
    The flac USE flag was mistakenly used
    instead of the opus USE flag for configuring.
    
    Also, Audacity 3.4.2 introduced a brand new
    USE_OPUSFILE option which must be set properly.
    
    These changes:
      - fix the opus USE flag
      - add proper REQUIRED_USE
      - replace media-sound/mpg123 with media-sound/mpg123-base
      - move dev-libs/rapidjson from RDEPEND to DEPEND
      - fix missing `#include <limits>` for 2.4.2-r4
      - limit media-video/ffmpeg to <5 for 2.4.2-r4
      - add x11-base/xorg-proto to DEPEND
      - add some ASM to BDEPEND
      - add audacity-3.4.2-audiocom-std-string.patch to PATCHES for 3.3.3-r1
      - add audacity-2.4.2-fix-libflac-undefined-references.patch to PATCHES for 2.4.2-r4
      - reset KEYWORDS for 2.4.2-r4 and 3.3.3-r1
    
    Closes: https://bugs.gentoo.org/741969
    Closes: https://bugs.gentoo.org/884747
    Closes: https://bugs.gentoo.org/910723
    Closes: https://bugs.gentoo.org/922595
    Closes: https://bugs.gentoo.org/927659
    Closes: https://github.com/gentoo/gentoo/pull/35903
    Co-authored-by: Matthew White <mehw.is.me@inventati.org>
    Signed-off-by: Aliaksei Urbanski <aliaksei.urbanski@gmail.com>
    Signed-off-by: Yixun Lan <dlan@gentoo.org>

 media-sound/audacity/audacity-2.4.2-r4.ebuild      | 135 +++++++++++++++++++++
 ...acity-3.3.3.ebuild => audacity-3.3.3-r1.ebuild} |  33 ++---
 ...acity-3.4.2.ebuild => audacity-3.4.2-r1.ebuild} |  24 ++--
 media-sound/audacity/audacity-9999.ebuild          |  24 ++--
 ...audacity-2.4.2-add-missing-include-limits.patch |  10 ++
 ...ty-2.4.2-fix-libflac-undefined-references.patch |  61 ++++++++++
 media-sound/audacity/metadata.xml                  |   4 +-
 7 files changed, 258 insertions(+), 33 deletions(-)