Created attachment 882719 [details] requested information files Hello, after upgrading ffmpeg from v4 to v6, audacity fails to compile. All other packages upgraded fine. TAR holds the requested files. CU Tom
From the log: -------------------- /var/tmp/portage/media-sound/audacity-2.4.2-r3/work/audacity-Audacity-2.4.2/include/audacity/Types.h:630:75: error: 'numeric_limits' is not a member of 'std' 630 | wxASSERT(static_cast<std::make_unsigned<type>::type>(value) <= std::numeric_limits<size_t>::max()); | ^~~~~~~~~~~~~~ /usr/include/wx-3.0-gtk3/wx/debug.h:280:42: note: in definition of macro 'wxASSERT_MSG' 280 | if ( wxTheAssertHandler && !(cond) && \ | ^~~~ /var/tmp/portage/media-sound/audacity-2.4.2-r3/work/audacity-Audacity-2.4.2/include/audacity/Types.h:630:7: note: in expansion of macro 'wxASSERT' 630 | wxASSERT(static_cast<std::make_unsigned<type>::type>(value) <= std::numeric_limits<size_t>::max()); | ^~~~~~~~ /var/tmp/portage/media-sound/audacity-2.4.2-r3/work/audacity-Audacity-2.4.2/include/audacity/Types.h:630:96: error: expected primary-expression before '>' token 630 | wxASSERT(static_cast<std::make_unsigned<type>::type>(value) <= std::numeric_limits<size_t>::max()); | ^ /usr/include/wx-3.0-gtk3/wx/debug.h:280:42: note: in definition of macro 'wxASSERT_MSG' 280 | if ( wxTheAssertHandler && !(cond) && \ | ^~~~ /var/tmp/portage/media-sound/audacity-2.4.2-r3/work/audacity-Audacity-2.4.2/include/audacity/Types.h:630:7: note: in expansion of macro 'wxASSERT' 630 | wxASSERT(static_cast<std::make_unsigned<type>::type>(value) <= std::numeric_limits<size_t>::max()); | ^~~~~~~~ /var/tmp/portage/media-sound/audacity-2.4.2-r3/work/audacity-Audacity-2.4.2/include/audacity/Types.h:630:99: error: '::max' has not been declared; did you mean 'std::max'? 630 | wxASSERT(static_cast<std::make_unsigned<type>::type>(value) <= std::numeric_limits<size_t>::max());
Why are you building old audacity? Is it because of fears of telemetry? Note that 3.x has: ``` # Disable telemetry features. -Daudacity_has_sentry_reporting=off -Daudacity_has_crashreports=off ```
Because v2 is marked stable, while v3 requires the ~x86 keyword... After adding ~x86 keyword, the new version 3 compiled fine. THX for your help.
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=72e8c24fcd0beb997a88f7d185a02a212abafe37 commit 72e8c24fcd0beb997a88f7d185a02a212abafe37 Author: Aliaksei Urbanski <aliaksei.urbanski@gmail.com> AuthorDate: 2024-04-16 19:03:31 +0000 Commit: Yixun Lan <dlan@gentoo.org> CommitDate: 2024-04-16 22:53:49 +0000 media-sound/audacity: fix various issues The flac USE flag was mistakenly used instead of the opus USE flag for configuring. Also, Audacity 3.4.2 introduced a brand new USE_OPUSFILE option which must be set properly. These changes: - fix the opus USE flag - add proper REQUIRED_USE - replace media-sound/mpg123 with media-sound/mpg123-base - move dev-libs/rapidjson from RDEPEND to DEPEND - fix missing `#include <limits>` for 2.4.2-r4 - limit media-video/ffmpeg to <5 for 2.4.2-r4 - add x11-base/xorg-proto to DEPEND - add some ASM to BDEPEND - add audacity-3.4.2-audiocom-std-string.patch to PATCHES for 3.3.3-r1 - add audacity-2.4.2-fix-libflac-undefined-references.patch to PATCHES for 2.4.2-r4 - reset KEYWORDS for 2.4.2-r4 and 3.3.3-r1 Closes: https://bugs.gentoo.org/741969 Closes: https://bugs.gentoo.org/884747 Closes: https://bugs.gentoo.org/910723 Closes: https://bugs.gentoo.org/922595 Closes: https://bugs.gentoo.org/927659 Closes: https://github.com/gentoo/gentoo/pull/35903 Co-authored-by: Matthew White <mehw.is.me@inventati.org> Signed-off-by: Aliaksei Urbanski <aliaksei.urbanski@gmail.com> Signed-off-by: Yixun Lan <dlan@gentoo.org> media-sound/audacity/audacity-2.4.2-r4.ebuild | 135 +++++++++++++++++++++ ...acity-3.3.3.ebuild => audacity-3.3.3-r1.ebuild} | 33 ++--- ...acity-3.4.2.ebuild => audacity-3.4.2-r1.ebuild} | 24 ++-- media-sound/audacity/audacity-9999.ebuild | 24 ++-- ...audacity-2.4.2-add-missing-include-limits.patch | 10 ++ ...ty-2.4.2-fix-libflac-undefined-references.patch | 61 ++++++++++ media-sound/audacity/metadata.xml | 4 +- 7 files changed, 258 insertions(+), 33 deletions(-)
