Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 926788 - media-gfx/hugin: fix automagic openmp support
Summary: media-gfx/hugin: fix automagic openmp support
Status: CONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Andreas K. Hüttel
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-03-12 00:39 UTC by Sam James
Modified: 2024-03-24 09:05 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-03-12 00:39:26 UTC
When removing a very stale zthread dep, I noticed its functionality was replaced with openmp support.

It looks like as of 2023.0.0, the dep/use of openmp is automagic. Please fix that to use USE=openmp & the toolchain-funcs machinery for it.
Comment 1 Larry the Git Cow gentoo-dev 2024-03-12 00:39:52 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a7796141b51a1c4f2eb0da0221fab1e128e7f667

commit a7796141b51a1c4f2eb0da0221fab1e128e7f667
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2024-03-12 00:35:37 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-03-12 00:39:41 +0000

    media-gfx/hugin: drop stale zthread dependency
    
    Dropped upstream in https://sourceforge.net/p/hugin/hugin/ci/7811fb3dab6c7d5cfd1133df40e1f0845a173d62/
    from 2014.
    
    Someone posted about this on /r/gentoo a few weeks ago and I found it curious
    but didn't dig into it more. After coming across bug #924925 for zthread, I thought
    I'd take a deeper look.
    
    hugin still has the CMake module for zthread but it's not called anywhere, and
    the bundled copy in foreign/ it references is long-gone too.
    
    Note that hugin also, since 2014, supports OpenMP as a replacement, but handling
    that in a separate commit as can't do that in stable like we are here.
    
    Bug: https://bugs.gentoo.org/924925
    Bug: https://bugs.gentoo.org/926788
    Signed-off-by: Sam James <sam@gentoo.org>

 media-gfx/hugin/{hugin-2022.0.0-r1.ebuild => hugin-2022.0.0-r2.ebuild} | 3 +--
 media-gfx/hugin/{hugin-2023.0.0.ebuild => hugin-2023.0.0-r1.ebuild}    | 3 +--
 media-gfx/hugin/hugin-9999.ebuild                                      | 3 +--
 3 files changed, 3 insertions(+), 6 deletions(-)
Comment 2 Markus Meier gentoo-dev 2024-03-24 09:05:08 UTC
Proposed a patch here:

https://groups.google.com/d/msgid/hugin-ptx/20240324100306.4cb1bf20%40xps13-2021.home