Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 924925 - dev-libs/zthread-2.3.2-r5 fails to compile: PoolExecutor.h:58:9: error: type struct PoolExecutor violates the C++ One Definition Rule [-Werror=odr]
Summary: dev-libs/zthread-2.3.2-r5 fails to compile: PoolExecutor.h:58:9: error: type ...
Status: RESOLVED OBSOLETE
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it
URL:
Whiteboard:
Keywords: PMASKED
Depends on:
Blocks: lto
  Show dependency tree
 
Reported: 2024-02-18 14:42 UTC by Agostino Sarubbo
Modified: 2024-04-28 03:45 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,100.45 KB, text/plain)
2024-02-18 14:42 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2024-02-18 14:42:00 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: dev-libs/zthread-2.3.2-r5 fails to compile.
Discovered on: amd64 (internal ref: lto_tinderbox)
System: LTO-SYSTEM (https://wiki.gentoo.org/wiki/Project:Tinderbox/Common_Issues_Helper#LTO)

Info about the issue:
https://wiki.gentoo.org/wiki/Project:Tinderbox/Common_Issues_Helper#CF0014
Comment 1 Agostino Sarubbo gentoo-dev 2024-02-18 14:42:02 UTC
Created attachment 885356 [details]
build.log

build log and emerge --info
Comment 2 Larry the Git Cow gentoo-dev 2024-03-12 00:39:52 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a7796141b51a1c4f2eb0da0221fab1e128e7f667

commit a7796141b51a1c4f2eb0da0221fab1e128e7f667
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2024-03-12 00:35:37 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-03-12 00:39:41 +0000

    media-gfx/hugin: drop stale zthread dependency
    
    Dropped upstream in https://sourceforge.net/p/hugin/hugin/ci/7811fb3dab6c7d5cfd1133df40e1f0845a173d62/
    from 2014.
    
    Someone posted about this on /r/gentoo a few weeks ago and I found it curious
    but didn't dig into it more. After coming across bug #924925 for zthread, I thought
    I'd take a deeper look.
    
    hugin still has the CMake module for zthread but it's not called anywhere, and
    the bundled copy in foreign/ it references is long-gone too.
    
    Note that hugin also, since 2014, supports OpenMP as a replacement, but handling
    that in a separate commit as can't do that in stable like we are here.
    
    Bug: https://bugs.gentoo.org/924925
    Bug: https://bugs.gentoo.org/926788
    Signed-off-by: Sam James <sam@gentoo.org>

 media-gfx/hugin/{hugin-2022.0.0-r1.ebuild => hugin-2022.0.0-r2.ebuild} | 3 +--
 media-gfx/hugin/{hugin-2023.0.0.ebuild => hugin-2023.0.0-r1.ebuild}    | 3 +--
 media-gfx/hugin/hugin-9999.ebuild                                      | 3 +--
 3 files changed, 3 insertions(+), 6 deletions(-)
Comment 3 Larry the Git Cow gentoo-dev 2024-03-26 14:04:03 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ba1d0aa780a7ab7097ef7999a1340c0a153c260d

commit ba1d0aa780a7ab7097ef7999a1340c0a153c260d
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2024-03-26 13:53:43 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2024-03-26 14:03:56 +0000

    package.mask: Last rite dev-libs/zthread
    
    Bug: https://bugs.gentoo.org/924925
    Signed-off-by: Michał Górny <mgorny@gentoo.org>

 profiles/package.mask | 6 ++++++
 1 file changed, 6 insertions(+)
Comment 4 Larry the Git Cow gentoo-dev 2024-04-27 15:01:46 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5cdcb810e27d4b7be8507a6c0f7c28ef68e65dac

commit 5cdcb810e27d4b7be8507a6c0f7c28ef68e65dac
Author:     Arthur Zamarin <arthurzam@gentoo.org>
AuthorDate: 2024-04-27 14:56:47 +0000
Commit:     Arthur Zamarin <arthurzam@gentoo.org>
CommitDate: 2024-04-27 14:56:47 +0000

    dev-libs/zthread: treeclean
    
    Closes: https://bugs.gentoo.org/924925
    Bug: https://bugs.gentoo.org/912434
    Bug: https://bugs.gentoo.org/715478
    Bug: https://bugs.gentoo.org/903529
    Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>

 dev-libs/zthread/Manifest                          |  1 -
 .../zthread/files/zthread-2.3.2-automake-r2.patch  | 75 -----------------
 dev-libs/zthread/files/zthread-2.3.2-clang.patch   | 15 ----
 .../files/zthread-2.3.2-configure-clang16.patch    | 22 -----
 dev-libs/zthread/files/zthread-2.3.2-gcc47.patch   | 25 ------
 .../zthread/files/zthread-2.3.2-m4-quote.patch     | 26 ------
 .../files/zthread-2.3.2-no-fpermissive-r1.diff     | 94 ----------------------
 dev-libs/zthread/metadata.xml                      |  8 --
 dev-libs/zthread/zthread-2.3.2-r5.ebuild           | 65 ---------------
 profiles/package.mask                              |  6 --
 10 files changed, 337 deletions(-)