Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 921561 - media-sound/ncmpcpp: bashism in configure script
Summary: media-sound/ncmpcpp: bashism in configure script
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Adrian Schollmeyer
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks: nonbash
  Show dependency tree
 
Reported: 2024-01-07 14:15 UTC by Michał Górny
Modified: 2024-10-21 12:36 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
/var/log/portage/media-sound:ncmpcpp-0.9.2-r3:20240107-140752.log (media-sound:ncmpcpp-0.9.2-r3:20240107-140752.log,36.79 KB, text/plain)
2024-01-07 14:15 UTC, Michał Górny
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2024-01-07 14:15:04 UTC
Created attachment 881593 [details]
/var/log/portage/media-sound:ncmpcpp-0.9.2-r3:20240107-140752.log

* QA Notice: command not found:
 * 
 *      ./configure: 20994: LDFLAGS+=-Wl,-O1 -Wl,--as-needed -Wl,--defsym=__gentoo_check_ldflags__=0      : not found


That's with /bin/sh → dash.
Comment 1 Larry the Git Cow gentoo-dev 2024-10-21 12:36:28 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f1e7e792ab4402aa5d757b3e4ef770e4036e631e

commit f1e7e792ab4402aa5d757b3e4ef770e4036e631e
Author:     Filip Kobierski <fkobi@pm.me>
AuthorDate: 2024-09-26 13:13:14 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2024-10-21 12:36:25 +0000

    media-sound/ncmpcpp: add 0.10_p20240912
    
    - I have prepared a patch to fix bashism and it got merged upstream.
      (72d990fe250da1e583677474b3462b9e9894130b)
      I have decided to do a _p ebuild to avoid backporting it.
    - add DOCS
    
    Closes: https://bugs.gentoo.org/921561
    Signed-off-by: Filip Kobierski <fkobi@pm.me>
    Closes: https://github.com/gentoo/gentoo/pull/38578
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 media-sound/ncmpcpp/Manifest                      |  1 +
 media-sound/ncmpcpp/ncmpcpp-0.10_p20240912.ebuild | 76 +++++++++++++++++++++++
 2 files changed, 77 insertions(+)