Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 919309 - app-containers/distrobuilder-3.1: add missing dependencies
Summary: app-containers/distrobuilder-3.1: add missing dependencies
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal enhancement
Assignee: William Hubbs
URL:
Whiteboard:
Keywords: EBUILD
Depends on:
Blocks:
 
Reported: 2023-12-05 21:21 UTC by rick
Modified: 2024-10-27 16:45 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
patch and updated ebuild file (distrobuilder.tar.gz,10.00 KB, text/plain)
2023-12-05 21:23 UTC, rick
Details

Note You need to log in before you can comment on or make changes to this bug.
Description rick 2023-12-05 21:21:08 UTC
Hi,

I've tried to build an ISO to make a Windows 10 VM and I found some problems.

I submit this patch for distrobuilder which contains 3 dependencies and a patch to use mkisofs instead of genisoimage. genisoimage was in a deleted package (https://bugs.gentoo.org/591778). I've also add a kernel configuration check because repack-windows needs some specific flags.

I've also found that app-emulation/qemu needs the flag virtfs to run a Windows 10 VM. I hesitate to add a flag just for it, we don't really need these dependancies and flags and patch if we don't want to make a W10 VM.

Reproducible: Always
Comment 1 rick 2023-12-05 21:23:13 UTC
Created attachment 877654 [details]
patch and updated ebuild file
Comment 2 Joonas Niilola gentoo-dev 2023-12-13 13:27:21 UTC
First of all I didn't even know you could _build_ Windows VMs with distrobuilder. Then, I wonder if it's possible to write some all-around code logic that it's gonna try to use genisoimage and if that can't be found, fallback to mkisofs? If these tools are compatible at leat. That solution could be upstreamed potentially. 

If you run VMs through lxd (which utilizes qemu to do so), there's a message saying what you need to enable on qemu to have working VM support:
  optfeature "virtual machine support" app-emulation/qemu[spice,usbredir,virtfs]
Comment 3 rick 2023-12-14 23:25:20 UTC
I think it's possible. I'll try to make a patch for that and write a PR to the main project. I'll let write a comment when it's good, to remove the patch for a future version.

And my bad, I've not seen the message when I run LXD, I'll try to read my terminal better next time.
Comment 4 Larry the Git Cow gentoo-dev 2024-02-13 06:28:08 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e8ba118e6a27680c108d7fa5e559877217717733

commit e8ba118e6a27680c108d7fa5e559877217717733
Author:     Joonas Niilola <juippis@gentoo.org>
AuthorDate: 2024-02-13 06:26:34 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2024-02-13 06:26:34 +0000

    app-containers/distrobuilder: depend on cdrtools for 'mkisofs' bin
    
    Bug: https://bugs.gentoo.org/919309
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 .../{distrobuilder-3.0.ebuild => distrobuilder-3.0-r1.ebuild}        | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
Comment 5 rick 2024-10-26 19:25:25 UTC
The fix has been merged in distrobuilder (https://github.com/lxc/distrobuilder/commit/e9c6e0fe46fe19f52dc5d910ae7b75d218d2ead1).

The package is still missing app-arch/wimlib and app-misc/hivex as dependencies.
Comment 6 rick 2024-10-27 16:02:58 UTC
after a quick check, the package is missing app-misc/hivex and app-arch/wimlib (with flag fuse), even after the update to 3.1. I must install them before building windows image.
Comment 7 Larry the Git Cow gentoo-dev 2024-10-27 16:45:01 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2f74c4184142de9c4d0d335df2b6ff26e2b98507

commit 2f74c4184142de9c4d0d335df2b6ff26e2b98507
Author:     Joonas Niilola <juippis@gentoo.org>
AuthorDate: 2024-10-27 16:44:11 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2024-10-27 16:44:58 +0000

    app-containers/distrobuilder: add optfeature info for building win iso
    
    Closes: https://bugs.gentoo.org/919309
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 app-containers/distrobuilder/distrobuilder-3.1.ebuild | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)