Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 914764 - media-sound/mixxx-9999, media-sound/mixxx-2.4.9999 Qt6 dependencies, drop dev-qt/qtscript:5, media-sound/mixxx-2.4.0 version bump
Summary: media-sound/mixxx-9999, media-sound/mixxx-2.4.9999 Qt6 dependencies, drop dev...
Status: UNCONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Professional Audio Applications Maintainers
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks: qtscript-removal
  Show dependency tree
 
Reported: 2023-09-26 20:05 UTC by jospezial
Modified: 2024-04-06 01:06 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
mixxx-9999.ebuild_qt6.patch (mixxx-9999.ebuild_qt6.patch,3.51 KB, patch)
2024-02-18 15:29 UTC, jospezial
Details | Diff
mixxx-9999.ebuild (mixxx-9999.ebuild,3.00 KB, text/plain)
2024-02-24 23:31 UTC, jospezial
Details
mixxx-9999.ebuild (mixxx-9999.ebuild,3.10 KB, text/plain)
2024-03-14 14:17 UTC, jospezial
Details

Note You need to log in before you can comment on or make changes to this bug.
Description jospezial 2023-09-26 20:05:47 UTC
https://github.com/mixxxdj/mixxx/commit/850029cd688155a04991595be58e4adffc9ba183
"CMakeLists: Default QT6 to ON"

Please add QT6 dependencies and a QT5 USE flag to the ebuild.

-DQT6="$(usex QT5 off on)" #-DQT6=OFF if QT5 enabled

qml could also be interesting to enable.
Comment 2 Andreas Sturmlechner gentoo-dev 2023-10-24 19:48:56 UTC
Turns out 2.4-beta and 2.4 branch is a thing. It still supports Qt5, so in a first step, if not providing Qt6, looking at ebuilds without dev-qt/qtscript:5 would be nice.
Comment 3 jospezial 2023-10-24 22:07:10 UTC
I think 2.4-beta is to old with date of May.
Most of the commits go first into 2.4 branch and then into main.
I have the feeling a 2.4 release is near.
https://github.com/mixxxdj/mixxx/projects/3
The 2.3 Branch development seems dead with last commit in August when 2.3.6 was released.

-mixxx-2.3.9999.ebuild
+mixxx-2.4.9999.ebuild
Comment 4 Alfred Wingate 2023-12-03 14:48:40 UTC
https://github.com/mixxxdj/mixxx/commit/94dde618a4e5448c92a24fe77f4ec22a3ef4f7ea

Looks like they want to support qt6 officially in 2.5.
Comment 5 jospezial 2024-01-16 13:52:41 UTC
https://github.com/mixxxdj/mixxx/commit/3f0045b5924131d7664a75ff42e490ed6ef04848
"add qt6-qpa-plugins to dependencies
    main"
Comment 6 Andreas Sturmlechner gentoo-dev 2024-01-16 14:18:46 UTC
(In reply to Alfred Wingate from comment #4)
> https://github.com/mixxxdj/mixxx/commit/
> 94dde618a4e5448c92a24fe77f4ec22a3ef4f7ea
> 
> Looks like they want to support qt6 officially in 2.5.
We need something that can be stabilised and Qt6-based software will not make that cut for a while.
Comment 7 jospezial 2024-02-16 17:55:10 UTC
(In reply to Andreas Sturmlechner from comment #6)
> (In reply to Alfred Wingate from comment #4)
> > https://github.com/mixxxdj/mixxx/commit/
> > 94dde618a4e5448c92a24fe77f4ec22a3ef4f7ea
> > 
> > Looks like they want to support qt6 officially in 2.5.
> We need something that can be stabilised and Qt6-based software will not
> make that cut for a while.

There you have it:
https://github.com/mixxxdj/mixxx/releases/tag/2.4.0

"Mixxx 2.4 does not fully support Qt6, use 2.5/main instead. "
        "Qt6 support is available for CI checks only and requires the environment variable GITHUB_ACTIONS to be set."

I will try to convert the live ebuild to qt6.
Comment 8 jospezial 2024-02-18 15:29:13 UTC
Created attachment 885362 [details, diff]
mixxx-9999.ebuild_qt6.patch

Works with qt6. I did not test with qt5.
Experimental QML gui also works.

The resulting mixxx-9999.ebuild could also work for mixxx-2.4 . You could set qt5 USEflag to +qt5 then.

Would be nice if we could solve Bug 822357 to get rid of the tests and benchmark builds and dependencies.
Comment 9 jospezial 2024-02-24 12:02:12 UTC
Miroslav, what is you opinion? Would you like to merge the patch?
Comment 10 Andreas Sturmlechner gentoo-dev 2024-02-24 12:06:13 UTC
Your patch lacks a bit of alphanumerical sorting and there's at least one error:

> !qt5? ( qtkeychain? ( dev-libs/qtkeychain:=[qt6(+)] ) )

...means that Qt6 functionality will be assumed even in *older* versions of qtkeychain that did not have the flag.
Comment 11 Andreas Sturmlechner gentoo-dev 2024-02-24 20:34:11 UTC
plus it is highly unlikely that dev-cpp/gtest and dev-cpp/benchmark are RDEPENDs.
Comment 12 jospezial 2024-02-24 23:31:04 UTC
Created attachment 885914 [details]
mixxx-9999.ebuild

sorted the deps
It is hard for me to decide whether they are build depends or also run depends and why dev-cpp/ms-gsl is in DEPEND.
Should the cmake args also be sorted? By cmake option?
I think now they are sorted by appearance in cmakelist.txt or logical and a little alphanumerical/USEflags.

I'll attach an ebuild.patch again when all is good.
Comment 13 jospezial 2024-02-27 22:33:01 UTC
Should I add something like --prefix= or ${ED} for the insinto ?
Comment 14 jospezial 2024-03-14 14:17:28 UTC
Created attachment 887644 [details]
mixxx-9999.ebuild

added dep on dev-qt/qtshadertools
https://github.com/mixxxdj/mixxx/commit/bdb6630669edf8aefe9a5f9eb5dda1ecbb812c9f
and dev-qt/qt5compat
Comment 15 jospezial 2024-04-04 11:03:55 UTC
Maybe we need to restrict mixxx to <qt-6.7 until upstream or we have have a patch.