Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 912330 - net-misc/r8152-2.16.3-r1: error: implicit declaration of function ‘skb_gso_segment’ with sys-kernel/gentoo-sources-6.4.10
Summary: net-misc/r8152-2.16.3-r1: error: implicit declaration of function ‘skb_gso_se...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Jay Faulkner
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2023-08-15 22:20 UTC by Jay Faulkner
Modified: 2023-08-18 03:48 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build log from failure (r8152-build-log.txt,8.33 KB, text/plain)
2023-08-15 22:33 UTC, Jay Faulkner
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jay Faulkner 2023-08-15 22:20:23 UTC
Build fails with

  printf '%s\n'   r8152.o | awk '!x[$0]++ { print("/var/tmp/portage/net-misc/r8152-2.16.3-r1/work/r8152-2.16.3/"$0) }' > /var/tmp/portage/net-misc/r8152-2.16.3-r1/work/r8152-2.16.3/r8152.mod
/var/tmp/portage/net-misc/r8152-2.16.3-r1/work/r8152-2.16.3/r8152.c: In function ‘r8152_csum_workaround’:
/var/tmp/portage/net-misc/r8152-2.16.3-r1/work/r8152-2.16.3/r8152.c:2075:24: error: implicit declaration of function ‘skb_gso_segment’; did you mean ‘skb_gso_reset’? [-Werror=implicit-function-declaration]
 2075 |                 segs = skb_gso_segment(skb, features);
      |                        ^~~~~~~~~~~~~~~
      |                        skb_gso_reset
/var/tmp/portage/net-misc/r8152-2.16.3-r1/work/r8152-2.16.3/r8152.c:2075:22: warning: assignment to ‘struct sk_buff *’ from ‘int’ makes pointer from integer without a cast [-Wint-conversion]
 2075 |                 segs = skb_gso_segment(skb, features);
      |                      ^
cc1: some warnings being treated as errors
make[2]: *** [scripts/Makefile.build:252: /var/tmp/portage/net-misc/r8152-2.16.3-r1/work/r8152-2.16.3/r8152.o] Error 1
make[1]: *** [Makefile:2032: /var/tmp/portage/net-misc/r8152-2.16.3-r1/work/r8152-2.16.3] Error 2
make: *** [Makefile:24: modules] Error 2

Full build.log attached.

Reproducible: Always
Comment 1 Jay Faulkner 2023-08-15 22:22:27 UTC
Appears to be same issue/resolution as https://bugs.gentoo.org/912242 -- I will look at that patch and attempt a fix by, at the latest, this weekend.
Comment 2 Jay Faulkner 2023-08-15 22:26:05 UTC
https://github.com/wget/realtek-r8152-linux/pull/34

Looks like I should dig in and perhaps push the new upstream version with the fix.
Comment 3 Jay Faulkner 2023-08-15 22:33:55 UTC
Created attachment 867923 [details]
build log from failure
Comment 4 Larry the Git Cow gentoo-dev 2023-08-18 03:48:33 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ae31310d7938f6ca21ce4dd7ceb76e09a604b755

commit ae31310d7938f6ca21ce4dd7ceb76e09a604b755
Author:     Jay Faulkner <jay@jvf.cc>
AuthorDate: 2023-08-17 23:06:01 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-08-18 03:48:04 +0000

    net-misc/r8152: Fix build issues for kernel 6.4.10+
    
    Build of this module was broken by a recent kernel update; this change
    allows the module to build on 6.4.10+ now as well as against older
    kernels.
    
    Closes: https://bugs.gentoo.org/912330
    Signed-off-by: Jay Faulkner <jay@jvf.cc>
    Closes: https://github.com/gentoo/gentoo/pull/32366
    Signed-off-by: Sam James <sam@gentoo.org>

 .../files/r8152-2.16.3-kernel-6.4.10-fix.patch     | 27 ++++++++++++++++++++++
 net-misc/r8152/r8152-2.16.3-r1.ebuild              |  1 +
 net-misc/r8152/r8152-2.16.3.ebuild                 |  1 +
 3 files changed, 29 insertions(+)