Realtek network adapter kernel module fails to compile with latest Gentoo kernel. Reproducible: Always Steps to Reproduce: emerge r8168 Actual Results: ... /var/tmp/portage/net-misc/r8168-8.051.02/work/r8168-8.051.02/src/r8168_n.c: In function ‘r8168_csum_workaround’: /var/tmp/portage/net-misc/r8168-8.051.02/work/r8168-8.051.02/src/r8168_n.c:29208:24: error: implicit declaration of function ‘skb_gso_segment’; did you mean ‘skb_gso_reset’? [-Werror=implicit-function-declaration] 29208 | segs = skb_gso_segment(skb, features); | ^~~~~~~~~~~~~~~ | skb_gso_reset /var/tmp/portage/net-misc/r8168-8.051.02/work/r8168-8.051.02/src/r8168_n.c:29208:22: warning: assignment to ‘struct sk_buff *’ from ‘int’ makes pointer from integer without a cast [-Wint-conversion] 29208 | segs = skb_gso_segment(skb, features); | ^ cc1: some warnings being treated as errors make[2]: *** [scripts/Makefile.build:252: /var/tmp/portage/net-misc/r8168-8.051.02/work/r8168-8.051.02/src/r8168_n.o] Error 1 make[1]: *** [Makefile:2032: /var/tmp/portage/net-misc/r8168-8.051.02/work/r8168-8.051.02/src] Error 2 make: *** [Makefile:154: modules] Error 2 Expected Results: Successful kernel module build.
Created attachment 867796 [details] build.log
$ emerge --info Portage 3.0.50 (python 3.11.4-final-0, default/linux/amd64/17.1/no-multilib/hardened, gcc-12, glibc-2.37-r4, 6.4.10-gentoo x86_64) ================================================================= System uname: Linux-6.4.10-gentoo-x86_64-AMD_Ryzen_9_5950X_16-Core_Processor-with-glibc2.37 KiB Mem: 131848756 total, 130851236 free KiB Swap: 7503752 total, 7503752 free Timestamp of repository gentoo: Sun, 13 Aug 2023 06:15:02 +0000 Head commit of repository gentoo: d66932f58442587cd4da03e3d831b0f8872794fe Timestamp of repository sinustrom: Tue, 08 Aug 2023 09:17:05 +0000 Head commit of repository sinustrom: bc1bd1e94715e3eed8bfee939b64d4e206195651 sh bash 5.2_p15-r6 ld GNU ld (Gentoo 2.41 p2) 2.41.0 distcc 3.4 x86_64-pc-linux-gnu [disabled] app-misc/pax-utils: 1.3.7::gentoo app-shells/bash: 5.2_p15-r6::gentoo dev-lang/perl: 5.38.0-r1::gentoo dev-lang/python: 3.11.4::gentoo, 3.12.0_rc1_p1::gentoo dev-lang/rust: 1.71.1::gentoo dev-util/cmake: 3.27.2::gentoo dev-util/meson: 1.2.1::gentoo sys-apps/baselayout: 2.14::gentoo sys-apps/openrc: 0.48::gentoo sys-apps/sandbox: 2.38::gentoo sys-devel/autoconf: 2.71-r7::gentoo sys-devel/automake: 1.16.5-r1::gentoo sys-devel/binutils: 2.41-r1::gentoo sys-devel/binutils-config: 5.5::gentoo sys-devel/gcc: 12.3.1_p20230623::gentoo, 13.2.0::gentoo sys-devel/gcc-config: 2.11::gentoo sys-devel/libtool: 2.4.7-r1::gentoo sys-devel/llvm: 16.0.6::gentoo sys-devel/make: 4.4.1-r1::gentoo sys-kernel/linux-headers: 6.4::gentoo (virtual/os-headers) sys-libs/glibc: 2.37-r4::gentoo Repositories: gentoo location: /var/db/repos/gentoo sync-type: rsync sync-uri: rsync://barbican.sinustrom.net/gentoo-portage priority: -1000 volatile: False sync-rsync-extra-opts: sync-rsync-verify-metamanifest: yes sync-rsync-verify-max-age: 24 sync-rsync-verify-jobs: 1 sinustrom location: /var/db/repos/sinustrom sync-type: git sync-uri: https://github.com/gentoo-mirror/sinustrom.git masters: gentoo volatile: False ACCEPT_KEYWORDS="amd64 ~amd64" ACCEPT_LICENSE="@FREE" CBUILD="x86_64-pc-linux-gnu" CFLAGS="-march=native -O2 -pipe -ftree-vectorize" CHOST="x86_64-pc-linux-gnu" CONFIG_PROTECT="/etc /usr/share/gnupg/qualified.txt" CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo" CXXFLAGS="-march=native -O2 -pipe -ftree-vectorize" DISTDIR="/var/cache/portage/distfiles" ENV_UNSET="CARGO_HOME DBUS_SESSION_BUS_ADDRESS DISPLAY GDK_PIXBUF_MODULE_FILE GOBIN GOPATH PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR XDG_STATE_HOME" FCFLAGS="-march=native -O2 -pipe -ftree-vectorize" FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs binpkg-multi-instance buildpkg-live config-protect-if-modified distlocks ebuild-locks fixlafiles ipc-sandbox merge-sync multilib-strict network-sandbox news parallel-fetch pid-sandbox preserve-libs protect-owned qa-unresolved-soname-deps sandbox sfperms strict strict-keepdir unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync warn-on-large-env xattr" FFLAGS="-march=native -O2 -pipe -ftree-vectorize" GENTOO_MIRRORS="rsync://barbican.sinustrom.net/gentoo-distfiles/" LANG="en_US.utf8" LDFLAGS="-Wl,-O1 -Wl,--as-needed" LEX="flex" MAKEOPTS="-j32" PKGDIR="/var/cache/portage/binpkgs" PORTAGE_CONFIGROOT="/" PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git" PORTAGE_TMPDIR="/var/tmp" SHELL="/bin/zsh" USE="7zip acl acpi amd64 bash-completion bzip2 cet cli crypt cuda dri fortran gdbm gmp hardened iconv ipv6 libtirpc lto lzma ncurses nls nptl nvidia opencl opengl openmp pam pcre pie posix readline seccomp smp sockets split-usr ssl ssp test-rust threads unicode usb vim-syntax xattr xtpax zlib zsh-completion zstd" ABI_X86="64" ADA_TARGET="gnat_2021" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon sheets words" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="aes avx avx2 f16c fma3 mmx mmxext pclmul popcnt rdrand sha sse sse2 sse3 sse4_1 sse4_2 sse4a ssse3" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock greis isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="keyboard mouse evdev" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LLVM_TARGETS="BPF NVPTX" LUA_SINGLE_TARGET="lua5-1" LUA_TARGETS="lua5-1" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php8-1" POSTGRES_TARGETS="postgres15" PYTHON_SINGLE_TARGET="python3_11" PYTHON_TARGETS="python3_11" QEMU_SOFTMMU_TARGETS="x86_64 arm aarch64" QEMU_USER_TARGETS="x86_64 arm aarch64" VIDEO_CARDS="nvidia" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq proto steal rawnat logmark ipmark dhcpmac delude chaos account" Unset: ADDR2LINE, AR, ARFLAGS, AS, ASFLAGS, CC, CCLD, CONFIG_SHELL, CPP, CPPFLAGS, CTARGET, CXX, CXXFILT, ELFEDIT, EMERGE_DEFAULT_OPTS, EXTRA_ECONF, F77FLAGS, FC, GCOV, GPROF, INSTALL_MASK, LC_ALL, LD, LFLAGS, LIBTOOL, LINGUAS, MAKE, MAKEFLAGS, NM, OBJCOPY, OBJDUMP, PORTAGE_BINHOST, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, RANLIB, READELF, RUSTFLAGS, SIZE, STRINGS, STRIP, YACC, YFLAGS
Created attachment 867797 [details, diff] driver patch The patch adds the missing include if used with kernel versions 6.4.10 and up.
Confirmed that the patch fixed my issue with this, just so I can make a personal note and not have problems later with forgetting and leaving the patch there, what is the ETA/status on pushing out the fix?
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=13f43b73752f9cc8630655794307f7b7f77f97c5 commit 13f43b73752f9cc8630655794307f7b7f77f97c5 Author: Karlson2k (Evgeny Grin) <k2k@narod.ru> AuthorDate: 2023-08-15 14:34:57 +0000 Commit: Conrad Kostecki <conikost@gentoo.org> CommitDate: 2023-08-19 22:31:56 +0000 net-misc/r8168: fixed build with kernel 6.4.10+ Bug: https://bugs.gentoo.org/912242 Signed-off-by: Karlson2k (Evgeny Grin) <k2k@narod.ru> Closes: https://github.com/gentoo/gentoo/pull/32323 Signed-off-by: Conrad Kostecki <conikost@gentoo.org> net-misc/r8168/files/r8168-8.051.02-6.4.10-fix.patch | 17 +++++++++++++++++ net-misc/r8168/r8168-8.051.02.ebuild | 1 + 2 files changed, 18 insertions(+)
