Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 911345 - net-misc/icaclient shouldn't have hard dependency on net-libs/webkit-gtk
Summary: net-misc/icaclient shouldn't have hard dependency on net-libs/webkit-gtk
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal enhancement
Assignee: Amy Liffey
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2023-07-27 22:31 UTC by Mark Harmstone
Modified: 2025-01-21 10:07 UTC (History)
6 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
ebuild with webkit USE flag (icaclient-22.12.0.12-r2.ebuild,6.29 KB, text/plain)
2023-09-05 21:06 UTC, Mark Harmstone
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Harmstone 2023-07-27 22:31:46 UTC
At present net-misc/icaclient has a hard dependency on net-libs/webkit-gtk, a package which not only takes a long time to compile, but also pulls in other stuff like Ruby. However, this is only a dependency of some ancillary files - the Citrix base program wfica works perfectly well without webkit-gtk.

It'd be nice if we could have a USE flag which gets rid of the dependency on webkit-gtk, at the expense of not pulling in the files (util/webcontainer, lib/UIDialogLibWebKit3.so, selfservice) that rely on it.

Reproducible: Always
Comment 1 Matt Turner gentoo-dev 2023-09-05 19:45:12 UTC
I previously filed a bug (bug 893706) asking whether it was possible to switch to a newer slot of webkit-gtk or drop the dependency completely.

It didn't seem like the then-maintainer knew what functionality was reliant on webkit-gtk, but it sounds like you might know better.

If you know, could you tell us here? Thanks!
Comment 2 Mark Harmstone 2023-09-05 21:06:30 UTC
Created attachment 869893 [details]
ebuild with webkit USE flag
Comment 3 Mark Harmstone 2023-09-05 21:09:39 UTC
It seems to be mainly the selfservice program, used for enrolment(?).

Have a look at the ebuild I've just attached - I've been testing it the past few days, and it's been fine.
Comment 4 Mark Harmstone 2023-09-05 21:13:07 UTC
I can't see that util/webcontainer and lib/UIDialogLibWebKit3.so are actually used by anything.
Comment 5 Michael Yagliyan 2023-09-19 20:17:59 UTC
FWIW as a regular user of icaclient, I'd happily accept some degraded functionality in order to avoid having to build webkit-gtk.  My PC has 16 cores, 32 threads, 128GB RAM, and I build entirely within RAM (in a tmpfs), and even I find building webkit-gtk to be a nuisance.
Comment 6 OzTiram 2024-10-18 19:59:32 UTC
I added myself as a co-maintainer of this ebuild, as I was who actually did the latest updated for this package. I will take a look of adding webkit-gtk as optional dependency.
Comment 7 OzTiram 2024-10-18 20:04:32 UTC
Looking at the debian package that citrix distribute:

Package: icaclient
Version: 24.8.0.98
Architecture: amd64
Maintainer: Citrix Systems, Inc. <debian.package.support@citrix.com>
Installed-Size: 1122483
Pre-Depends: debconf (>= 0.5)
Depends: libc6 (>= 2.13-38), libice6 (>= 1:1.0.0), libgtk2.0-0 (>= 2.12.0), libsm6, libx11-6, libxext6, libxmu6, libxpm4, libasound2, libstdc++6, libidn11 | libidn12, zlib1g, curl (>= 7.68), libsqlite3-0, libspeexdsp1, libva2
Recommends: libglib2.0-0 (>= 2.12.0), libgstreamer-plugins-base0.10-0 (>= 0.10.15), libgstreamer0.10-0 (>= 0.10.15), libspeex1, libvorbis0a, libvorbisenc2, libcanberra-gtk-module, gstreamer1.0-libav (>= 1.2.0), gstreamer1.0-plugins-bad (>= 1.2.0), pulseaudio, libwebkit2gtk-4.0-37

libwebkit2gtk is an optional dependecy. Hence, I think we can definitely add a use flag to pull it optionally.
Comment 8 OzTiram 2025-01-11 15:23:37 UTC
Note when building the ebuild in the linked PR:

scanelf: rpath_security_checks(): Security problem with relative DT_RPATH '.:$ORIGIN/' in /srv/portage/tmp/portage/net-misc/icaclient-24.11.0.85/image/opt/Citrix/ICAClient/lib/libwebrpc.so
 * QA Notice: Unresolved soname dependencies:
 * 
 * 	/opt/Citrix/ICAClient/lib/UIDialogLibWebKit3.so: libwebkit2gtk-4.0.so.37
 * 	/opt/Citrix/ICAClient/lib/libbgblur.so: libopencv_core.so.410 libopencv_imgcodecs.so.410 libopencv_imgproc.so.410
 * 	/opt/Citrix/ICAClient/lib/libctxVideoDecoder.so: libva.so.2
 * 	/opt/Citrix/ICAClient/selfservice: libwebkit2gtk-4.0.so.37
 * 	/opt/Citrix/ICAClient/util/nfcui: libpcsclite.so.1
 * 	/opt/Citrix/ICAClient/util/webcontainer: libwebkit2gtk-4.0.so.37
 * 


Indeed there is linking to webkit2gtk. However, it is not required if not using the self-service feature.
Also, this shows that libva.so.2 is needed hence, I added it as dependency.

(Without it :
$/usr/bin/wfica
/opt/Citrix/ICAClient/wfica: error while loading shared libraries: libva.so.2: cannot open shared object file: No such file or directory
)
Comment 9 Larry the Git Cow gentoo-dev 2025-01-20 15:44:13 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=547bf0c23dc8089a615d21f5a321249837cb1b5a

commit 547bf0c23dc8089a615d21f5a321249837cb1b5a
Author:     Oz Tiram <oz.tiram@gmail.com>
AuthorDate: 2025-01-10 20:54:30 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2025-01-20 15:42:46 +0000

    net-misc/icaclient: drop 23.5.0.58
    
    Bug: https://bugs.gentoo.org/947611
    Bug: https://bugs.gentoo.org/911345
    Signed-off-by: Oz Tiram <oz.tiram@gmail.com>
    Closes: https://github.com/gentoo/gentoo/pull/40090
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 net-misc/icaclient/Manifest                    |   2 -
 net-misc/icaclient/icaclient-23.5.0.58.ebuild  | 310 -------------------------
 net-misc/icaclient/icaclient-24.11.0.85.ebuild |   1 +
 3 files changed, 1 insertion(+), 312 deletions(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f8c5cdbb021dae3165062b5bc9f94529ac624017

commit f8c5cdbb021dae3165062b5bc9f94529ac624017
Author:     Oz Tiram <oz.tiram@gmail.com>
AuthorDate: 2025-01-10 20:49:26 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2025-01-20 15:42:45 +0000

    net-misc/icaclient: add 24.11.0.85
    
    Bug: https://bugs.gentoo.org/911345
    Signed-off-by: Oz Tiram <oz.tiram@gmail.com>
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 net-misc/icaclient/Manifest                    |   1 +
 net-misc/icaclient/icaclient-24.11.0.85.ebuild | 312 +++++++++++++++++++++++++
 net-misc/icaclient/metadata.xml                |   1 +
 3 files changed, 314 insertions(+)
Comment 10 OzTiram 2025-01-21 10:07:11 UTC
I believe this issue can be closed. The latest version in the tree has an optional dependency.