Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 893706 - net-misc/icaclient: Migrate from net-libs/webkit-gtk:4 to :4.1 if possible
Summary: net-misc/icaclient: Migrate from net-libs/webkit-gtk:4 to :4.1 if possible
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Amy Liffey
URL: https://discussions.citrix.com/topic/...
Whiteboard:
Keywords:
Depends on:
Blocks: 893668
  Show dependency tree
 
Reported: 2023-02-09 03:01 UTC by Matt Turner
Modified: 2024-10-18 19:57 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Turner gentoo-dev 2023-02-09 03:01:02 UTC
We would like to reduce the number of net-libs/webkit-gtk slots.

Please check if it is possible to migrate from net-libs/webkit-gtk:4 to net-libs/webkit-gtk:4.1.

This should be possible (with minor build-system patching, see https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ea0bb7cd3b47dd02d964a5c27c010eeaea8cc8b1 for example) if net-libs/libsoup:2.4 is not pulled in by the package or any of its dependencies.
Comment 1 Matt Turner gentoo-dev 2023-02-09 03:25:46 UTC
Looks like this package depends on libsoup:2.4 and webkit-gtk:4 and is a binary package :(
Comment 2 Henning Schild 2023-02-17 14:16:13 UTC
Ok i can have a look if it also works against 4.1 or 5.

Is there like an overview bug where i could see possible other blockers that hinder a removal of 4 . To get a feel how much to invest and when.
Comment 3 Matt Turner gentoo-dev 2023-02-17 14:18:58 UTC
(In reply to Henning Schild from comment #2)
> Is there like an overview bug where i could see possible other blockers that
> hinder a removal of 4 . To get a feel how much to invest and when.

Yes, this bug blocks it.

Since this is a binary package, you're not going to be able to switch it. The best thing to do is to file a bug upstream and request they do it.
Comment 4 Henning Schild 2023-02-17 14:19:49 UTC
And maybe also let me know which files to watch out for when looking at ldd output, and what the relationship with libsoup is
Comment 5 Henning Schild 2023-02-17 14:23:53 UTC
This is a binary that can deal with some stuff missing. It has everything it possibly needs in multiple versions. Not sure about webkitgtk.

Just saying so you do not assume too much only because you saw something in ldd of installed files ... does not mean it is actually needed!

And yes i understand that it blocks. But if there are 500 others ... we can stop talking.
Comment 6 Henning Schild 2023-02-17 19:10:48 UTC
I want to help and see what is possible. Talking to upstream is hard on that one and we already talked in gentoo about making this ~ only again.

But i am not sure ~ only would help getting rid of :4.

That said

gentoo $ grep -r webkit-gtk:4 | grep -v webkit-gtk:4.1 | wc -l
43

does not seem to suggest the goal to drop :4 can be reached in the short term
Comment 7 Matt Turner gentoo-dev 2023-02-17 19:45:25 UTC
(In reply to Henning Schild from comment #4)
> And maybe also let me know which files to watch out for when looking at ldd
> output, and what the relationship with libsoup is

webkit-gtk:4.1:

/usr/lib64/libjavascriptcoregtk-4.1.so
/usr/lib64/libjavascriptcoregtk-4.1.so.0
/usr/lib64/libjavascriptcoregtk-4.1.so.0.2.6
/usr/lib64/libwebkit2gtk-4.1.so
/usr/lib64/libwebkit2gtk-4.1.so.0
/usr/lib64/libwebkit2gtk-4.1.so.0.2.6

I don't have a file list of  SLOT=4 handy, but it's basically just s/4.1/4/ of that.

I typed up what is the relationship to libsoup in the blocking bug that I already mentioned.

(In reply to Henning Schild from comment #6)
> I want to help and see what is possible. Talking to upstream is hard on that
> one and we already talked in gentoo about making this ~ only again.
> 
> But i am not sure ~ only would help getting rid of :4.
> 
> That said
> 
> gentoo $ grep -r webkit-gtk:4 | grep -v webkit-gtk:4.1 | wc -l
> 43
> 
> does not seem to suggest the goal to drop :4 can be reached in the short term

Please just focus on your package, and I'll see to the rest.
Comment 8 Matt Turner gentoo-dev 2023-02-24 02:06:50 UTC
Can you confirm that the package actually does depend on webkit-gtk? I see this in src_prepare, which makes me suspect that it might not:

> rm lib/UIDialogLibWebKit.so || die
Comment 9 Henning Schild 2023-02-25 17:07:03 UTC
Yes it is needed.

$ ldd /opt/Citrix/ICAClient/lib/UIDialogLibWebKit3.so | grep webkit
	libwebkit2gtk-4.0.so.37 => /usr/lib64/libwebkit2gtk-4.0.so.37 (0x00007f8cb7400000)
$ ldd /opt/Citrix/ICAClient/lib/UIDialogLibWebKit3.so | grep soup
	libsoup-2.4.so.1 => /usr/lib64/libsoup-2.4.so.1 (0x00007f7c84621000)
$ ldd /opt/Citrix/ICAClient/lib/UIDialogLibWebKit3.so | grep coregtk
	libjavascriptcoregtk-4.0.so.18 => /usr/lib64/libjavascriptcoregtk-4.0.so.18 (0x00007fbe86600000)
Comment 10 Henning Schild 2023-02-25 17:26:42 UTC
And a few other libs and binaries are using the libs as well. Plus there is a testcase in util/workspacecheck.sh to look for libwebkit2gtk-4.0.

So i strongly doubt that all the bits can be "not installed" without some sort of serious impact. Not to mention that partial installation was causing some serious headache, so we install almost everything we get from upstream.
Comment 11 OzTiram 2024-10-18 19:57:59 UTC
Current ICAclient ebuild in the gentoo tree no longer depend on webkit-gtk:4