Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 909888 - app-portage/gentoolkit: needs to use PEP517 build (DistutilsNonPEP517Build)
Summary: app-portage/gentoolkit: needs to use PEP517 build (DistutilsNonPEP517Build)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: Normal normal (vote)
Assignee: Portage Tools Team
URL:
Whiteboard:
Keywords: PullRequest
: 841137 (view as bug list)
Depends on:
Blocks: pep517-porting
  Show dependency tree
 
Reported: 2023-07-08 06:46 UTC by Michał Górny
Modified: 2024-01-02 18:02 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2023-07-08 06:46:21 UTC
This package still uses the legacy eclass code paths.  These paths are deprecated and pose a significant maintenance cost.  Please update the package to use PEP517 build mode.  For more information, please see the Python Guide, particularly; https://projects.gentoo.org/python/guide/migration.html#migrating-to-pep-517-builds
Comment 1 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-07-08 20:40:51 UTC
[Adding this comment en-masse, sorry for the noise, but it's important.)

1. Please take particular care to check file diffs before/after, possibly using `iwdevtools`. Keep a particular eye out for e.g. config files now missing from /etc and instead being in /usr/lib/python*/site-packages, etc.

2. Please make sure to do the migration in a new revision in ~arch, partly because of 1.
Comment 2 Larry the Git Cow gentoo-dev 2023-10-12 05:04:10 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/gentoolkit.git/commit/?id=78c8fbe8a35cd2926f37f21235c5d8b587efae46

commit 78c8fbe8a35cd2926f37f21235c5d8b587efae46
Author:     Zac Medico <zmedico@gentoo.org>
AuthorDate: 2023-10-09 04:57:02 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-10-12 05:04:06 +0000

    Migrate to PEP517 meson-python build
    
    Bug: https://bugs.gentoo.org/909888
    Signed-off-by: Zac Medico <zmedico@gentoo.org>
    Closes: https://github.com/gentoo/gentoolkit/pull/36
    Signed-off-by: Sam James <sam@gentoo.org>

 .github/workflows/ci.yml                  |  17 ++-
 MANIFEST.in                               |  13 ---
 bin/ebump                                 |   2 +-
 bin/euse                                  |   2 +-
 bin/meson.build                           |  55 ++++++++++
 bin/revdep-rebuild.sh                     |   2 +-
 data/meson.build                          |  20 ++++
 man/meson.build                           |  23 ++++
 meson.build                               |  68 ++++++++++++
 meson_options.txt                         |  15 +++
 pym/gentoolkit/eclean/cli.py              |   2 +-
 pym/gentoolkit/eclean/meson.build         |  18 +++
 pym/gentoolkit/ekeyword/ekeyword.py       |   2 +-
 pym/gentoolkit/ekeyword/meson.build       |  26 +++++
 pym/gentoolkit/ekeyword/tests/meson.build |  12 ++
 pym/gentoolkit/enalyze/__init__.py        |   4 +-
 pym/gentoolkit/enalyze/meson.build        |  17 +++
 pym/gentoolkit/equery/__init__.py         |   4 +-
 pym/gentoolkit/equery/meson.build         |  26 +++++
 pym/gentoolkit/eshowkw/__init__.py        |   2 +-
 pym/gentoolkit/eshowkw/meson.build        |  16 +++
 pym/gentoolkit/imlate/imlate.py           |   2 +-
 pym/gentoolkit/imlate/meson.build         |  14 +++
 pym/gentoolkit/meson.build                |  35 ++++++
 pym/gentoolkit/revdep_rebuild/__init__.py |   2 +-
 pym/gentoolkit/revdep_rebuild/meson.build |  21 ++++
 pym/gentoolkit/test/eclean/meson.build    |  20 ++++
 pym/gentoolkit/test/equery/meson.build    |   7 ++
 pym/gentoolkit/test/meson.build           |  16 +++
 pym/meson.build                           |   1 +
 pyproject.toml                            |  17 +++
 setup.py                                  | 176 ------------------------------
 32 files changed, 454 insertions(+), 203 deletions(-)
Comment 3 Larry the Git Cow gentoo-dev 2023-10-12 05:04:38 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=54b07999b19d0f3de682b6bec5c545cf1af20bc0

commit 54b07999b19d0f3de682b6bec5c545cf1af20bc0
Author:     Zac Medico <zmedico@gentoo.org>
AuthorDate: 2023-10-09 05:19:33 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-10-12 05:04:28 +0000

    app-portage/gentoolkit: Migrate 9999 to use Meson
    
    Bug: https://bugs.gentoo.org/909888
    Signed-off-by: Zac Medico <zmedico@gentoo.org>
    Closes: https://github.com/gentoo/gentoo/pull/33257
    Signed-off-by: Sam James <sam@gentoo.org>

 app-portage/gentoolkit/gentoolkit-9999.ebuild | 68 +++++++++++++++++++++++----
 1 file changed, 59 insertions(+), 9 deletions(-)
Comment 4 Larry the Git Cow gentoo-dev 2023-10-20 00:58:29 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=122ee4d7e65a6a1ba60a508a99f4d93632bda5dd

commit 122ee4d7e65a6a1ba60a508a99f4d93632bda5dd
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2023-10-20 00:57:42 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-10-20 00:58:01 +0000

    app-portage/gentoolkit: add 0.6.3
    
    Bug: https://bugs.gentoo.org/900224
    Closes: https://bugs.gentoo.org/909888
    Signed-off-by: Sam James <sam@gentoo.org>

 app-portage/gentoolkit/Manifest                |   1 +
 app-portage/gentoolkit/gentoolkit-0.6.3.ebuild | 121 +++++++++++++++++++++++++
 app-portage/gentoolkit/gentoolkit-9999.ebuild  |   6 +-
 3 files changed, 125 insertions(+), 3 deletions(-)
Comment 5 Zac Medico gentoo-dev 2024-01-02 18:02:01 UTC
*** Bug 841137 has been marked as a duplicate of this bug. ***