Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 907427 - dev-libs/libltdl-2.4.7-r1 ignores -Werror flags at link time
Summary: dev-libs/libltdl-2.4.7-r1 ignores -Werror flags at link time
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: AMD64 Linux
: Normal normal
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: lto
  Show dependency tree
 
Reported: 2023-05-30 18:28 UTC by Kostadin Shishmanov
Modified: 2024-05-16 01:45 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build log and emerge --info (dev-libs:libltdl-2.4.7-r1:20230530-182357.log,33.46 KB, text/x-log)
2023-05-30 18:28 UTC, Kostadin Shishmanov
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Kostadin Shishmanov 2023-05-30 18:28:47 UTC
Created attachment 862912 [details]
build log and emerge --info

libtool: link: (cd .libs && x86_64-pc-linux-gnu-gcc -march=native -O2 -pipe -flto=auto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing -c -fno-builtin  -fPIC -DPIC "libltdlS.c")
libtool: link: rm -f ".libs/libltdlS.c" ".libs/libltdl.nm" ".libs/libltdl.nmS" ".libs/libltdl.nmT" ".libs/libltdl.nmI"
libtool: link: (cd .libs/libltdl.lax/dlopen.a && x86_64-pc-linux-gnu-ar x "/var/tmp/portage/dev-libs/libltdl-2.4.7-r1/work/libtool-2.4.7/libltdl-abi_x86_64.amd64/./.libs/dlopen.a")
libtool: link: x86_64-pc-linux-gnu-gcc -shared  -fPIC -DPIC  loaders/.libs/libltdl_la-preopen.o .libs/libltdl_la-lt__alloc.o .libs/libltdl_la-lt_dlloader.o .libs/libltdl_la-lt_error.o .libs/libltdl_la-ltdl.o .libs/libltdl_la-slist.o .libs/lt__strl.o .libs/libltdlS.o  .libs/libltdl.lax/dlopen.a/dlopen.o    -march=native -O2 -flto=auto -Wl,-O1 -Wl,--as-needed   -Wl,-soname -Wl,libltdl.so.7 -o .libs/libltdl.so.7.3.2
.libs/libltdlS.c:27:12: warning: type of 'dlopen_LTX_get_vtable' does not match original declaration [-Wlto-type-mismatch]
/var/tmp/portage/dev-libs/libltdl-2.4.7-r1/work/libtool-2.4.7/libltdl/loaders/dlopen.c:61:1: note: return value type mismatch
   61 | get_vtable (lt_user_data loader_data)
      | ^
/var/tmp/portage/dev-libs/libltdl-2.4.7-r1/work/libtool-2.4.7/libltdl/loaders/dlopen.c:61:1: note: 'dlopen_LTX_get_vtable' was previously declared here
/var/tmp/portage/dev-libs/libltdl-2.4.7-r1/work/libtool-2.4.7/libltdl/loaders/dlopen.c:61:1: note: code may be misoptimized unless '-fno-strict-aliasing' is used
Comment 1 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-01-09 07:42:56 UTC
We need to apply this to libltdl, I guess:

commit 2b258b6396f73a8c9065132834b273e2fbdd1556
Author: Sam James <sam@gentoo.org>
Date:   Sat Dec 10 02:42:23 2022 +0000

    sys-devel/libtool: add -Werror filtering patch

    Needed to make -Werror=odr and such error out at link-time.

    Bug: https://bugs.gentoo.org/884767
    Signed-off-by: Sam James <sam@gentoo.org>
Comment 2 Larry the Git Cow gentoo-dev 2024-05-16 00:51:26 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f2eedcdbfedb96dfc136e0e18e08202442e5be2e

commit f2eedcdbfedb96dfc136e0e18e08202442e5be2e
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2024-05-16 00:48:51 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-05-16 00:50:06 +0000

    dev-libs/libltdl: add 2.5.0 (unkeyworded)
    
    Added filter-lto for now but need to report upstream. I thought I'd seen
    vapier fix this though (or something similar)...
    
    Bug: https://bugs.gentoo.org/907427
    Signed-off-by: Sam James <sam@gentoo.org>

 dev-libs/libltdl/Manifest             |  1 +
 dev-libs/libltdl/libltdl-2.5.0.ebuild | 48 +++++++++++++++++++++++++++++++++++
 2 files changed, 49 insertions(+)