Bug 884767 – sys-devel/libtool: filters out -Werror at link time (affects LTO testing like -Werror=odr) (media-libs/fdk-aac: ignoring -Werror=odr during linking phase)

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Kostadin Shishmanov 2022-12-07 19:40:17 UTC]

media-libs/fdk-aac is ignoring -Werror=odr in both CFLAGS and LDFLAGS during the linking phase

[Comment 1 Kostadin Shishmanov 2022-12-07 19:40:38 UTC]

Created attachment 840829 [details, diff]
patch from irc

[Comment 2 Sam James 2022-12-07 19:48:44 UTC]

We'll need to both patch sys-devel/libtool (and send it upstream, although our other patches are still pending) and then add it into elt-patches.

[Comment 3 Larry the Git Cow 2022-12-10 02:44:03 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=40b028161459dcad5ddbe429216c7632a0b7e80a

commit 40b028161459dcad5ddbe429216c7632a0b7e80a
Author:     Sam James <[e-mail]>
AuthorDate: 2022-12-10 02:42:57 +0000
Commit:     Sam James <[e-mail]>
CommitDate: 2022-12-10 02:43:03 +0000

    media-libs/fdk-aac: elibtoolize for -Werror=odr
    
    Closes: https://bugs.gentoo.org/884767
    Signed-off-by: Sam James <[e-mail]>

 media-libs/fdk-aac/fdk-aac-2.0.2.ebuild | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a9438218bd109ab144c5c05526e6dda213194dfc

commit a9438218bd109ab144c5c05526e6dda213194dfc
Author:     Sam James <[e-mail]>
AuthorDate: 2022-12-10 02:34:26 +0000
Commit:     Sam James <[e-mail]>
CommitDate: 2022-12-10 02:43:03 +0000

    app-portage/elt-patches: add 20221210
    
    Closes: https://bugs.gentoo.org/884767
    Signed-off-by: Sam James <[e-mail]>

 app-portage/elt-patches/Manifest                   |  1 +
 .../elt-patches/elt-patches-20221210.ebuild        | 25 ++++++++++++++++++++++
 2 files changed, 26 insertions(+)

Additionally, it has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2b258b6396f73a8c9065132834b273e2fbdd1556

commit 2b258b6396f73a8c9065132834b273e2fbdd1556
Author:     Sam James <[e-mail]>
AuthorDate: 2022-12-10 02:42:23 +0000
Commit:     Sam James <[e-mail]>
CommitDate: 2022-12-10 02:43:03 +0000

    sys-devel/libtool: add -Werror filtering patch
    
    Needed to make -Werror=odr and such error out at link-time.
    
    Bug: https://bugs.gentoo.org/884767
    Signed-off-by: Sam James <[e-mail]>

 .../libtool/files/libtool-2.4.7-werror-lto.patch   |  45 ++++++++
 sys-devel/libtool/libtool-2.4.7-r1.ebuild          | 116 +++++++++++++++++++++
 2 files changed, 161 insertions(+)

[Comment 4 Larry the Git Cow 2022-12-10 02:44:15 UTC]

The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/elt-patches.git/commit/?id=7ff3d75742a3560333334af9c92b282a99cc1486

commit 7ff3d75742a3560333334af9c92b282a99cc1486
Author:     Sam James <[e-mail]>
AuthorDate: 2022-12-10 02:31:23 +0000
Commit:     Sam James <[e-mail]>
CommitDate: 2022-12-10 02:31:23 +0000

    2.4.6, 2.4.7: add -Werror filter bypass for LTO
    
    Bug: https://bugs.gentoo.org/884767
    Signed-off-by: Sam James <[e-mail]>

 eltpatch.in          |  2 +-
 patches/werror/2.4.6 | 28 ++++++++++++++++++++++++++++
 patches/werror/2.4.7 | 30 ++++++++++++++++++++++++++++++
 3 files changed, 59 insertions(+), 1 deletion(-)

[Comment 5 Larry the Git Cow 2024-05-16 00:51:26 UTC]

The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c235441176385e7a096b85335b82cefa74968748

commit c235441176385e7a096b85335b82cefa74968748
Author:     Sam James <[e-mail]>
AuthorDate: 2024-05-16 00:43:56 +0000
Commit:     Sam James <[e-mail]>
CommitDate: 2024-05-16 00:49:59 +0000

    dev-build/libtool: add 2.5.0 (unkeyworded)
    
    It fails one test for me that was newly added in https://lists.gnu.org/archive/html/libtool-commit/2024-04/msg00003.html.
    
    Bug: https://bugs.gentoo.org/884767
    Signed-off-by: Sam James <[e-mail]>

 dev-build/libtool/Manifest             |   1 +
 dev-build/libtool/libtool-2.5.0.ebuild | 151 +++++++++++++++++++++++++++++++++
 dev-build/libtool/libtool-9999.ebuild  |  36 ++++++--
 3 files changed, 183 insertions(+), 5 deletions(-)