Bug 905707 – games-strategy/vcmi-1.2.0::gamerlay is broken, needs fixes

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Michał Dec 2023-05-04 16:22:56 UTC]

Created attachment 861132 [details]
This ebuild should work

There are many deficiencies in the current ebuild of 1.2.0.

1. It depends on fuzzylite compiled with float use disabled. Turning floats on in fuzzylite breaks vcmi. Not sure how we can deal with this at the moment. We can follow my advice from https://bugs.gentoo.org/905664#c1 and simply enforce this at the ebuild level, since there are no other fuzzylite users in Gentoo other than VCMI. Without this, the build will not run as intended.
2. Lua and ERM break the compilation process. Their USEFLAGS need to be masked. Without this, the compilation process will fail.
3. Without -DENABLE_GITVERSION=no in the source config incantation, the VCMI window be named "VCMI 1.2.1.GITDIR-NOTFOUND". We can fix this ugliness by including that parameter in the source configuration. Without this, our build will just be ugly.
4. dev-libs/boost requires that we specify -DCMAKE_BUILD_TYPE=GentooRelease or -DCMAKE_BUILD_TYPE=GentooDebug, instead of the usual RelWithDebInfo. This can be controlled with the debug USEFLAG. Without this, configuring the source code will not be successful.

Related upstream issues:
1. https://github.com/vcmi/vcmi/issues/2115
2. https://github.com/vcmi/vcmi/issues/2117

[Comment 1 Michał Dec 2023-05-04 16:23:18 UTC]

Forgot to write this is for gamerlay

[Comment 2 Michał Dec 2023-05-04 16:30:40 UTC]

Comment on attachment 861132 [details]
This ebuild should work

># Copyright 1999-2023 Gentoo Authors
># Distributed under the terms of the GNU General Public License v2
>
>EAPI=8
>
>LUA_COMPAT=(luajit)
># TODO: other targets (buildsystem is crazy and needs patches)
>
>inherit cmake lua-single flag-o-matic
>
>DESCRIPTION="Heroes of Might and Magic III game engine rewrite"
>HOMEPAGE="http://forum.vcmi.eu/index.php"
>SRC_URI="https://github.com/${PN}/${PN}/archive/${PV}.tar.gz -> ${P}.tar.gz"
>
>LICENSE="GPL-2"
>SLOT="0"
>KEYWORDS="~amd64 ~x86"
># TODO: other arches
>IUSE="+editor -debug -erm +launcher -lua +nullkiller-ai +translations"
>
>REQUIRED_USE="
>	erm? ( lua )
>	lua? ( ${LUA_REQUIRED_USE} )
>"
>
>CDEPEND="
>	media-libs/libsdl2[video]
>	media-libs/sdl2-image
>	media-libs/sdl2-mixer
>	media-libs/sdl2-ttf
>	media-video/ffmpeg
>	launcher? (
>		dev-qt/qtgui
>		dev-qt/qtcore
>		dev-qt/qtnetwork
>		dev-qt/qtwidgets
>		translations? ( dev-qt/linguist-tools )
>	)
>	editor? (
>		dev-qt/qtgui
>		dev-qt/qtcore
>		dev-qt/qtnetwork
>		dev-qt/qtwidgets
>		translations? ( dev-qt/linguist-tools )
>	)
>	dev-libs/fuzzylite
>	nullkiller-ai? ( dev-cpp/tbb )
>	sys-libs/zlib[minizip]
>"
>
>BDEPEND="
>	>dev-libs/boost-1.48.0
>	virtual/pkgconfig
>"
>DEPEND="
>	${BDEPEND}
>	${CDEPEND}
>"
>RDEPEND="
>	${CDEPEND}
>"
># PDEPEND="
># 	games-strategy/vcmi-data
># "
>
>src_configure() {
>	CMAKE_BUILD_TYPE='GentooRelease'
>	if use debug; then
>		CMAKE_BUILD_TYPE='GentooDebug'
>	fi
>	local mycmakeargs=(
>		-DENABLE_ERM=$(usex erm)
>		-DENABLE_LUA=$(usex lua)
>		-DENABLE_LAUNCHER=$(usex launcher)
>		-DENABLE_EDITOR=$(usex editor)
>		-DENABLE_TRANSLATIONS=$(usex translations)
>		-DENABLE_PCH=$(usex !debug)
>		-DENABLE_NULLKILLER_AI=$(usex nullkiller-ai)
>		-DENABLE_MONOLITHIC_INSTALL=OFF
>		-DFORCE_BUNDLED_FL=OFF
>		-DFORCE_BUNDLED_MINIZIP=OFF
>		-DENABLE_GITVERSION=no
>	)
>	export CCACHE_SLOPPINESS="time_macros"
>	cmake_src_configure
>}
>
>pkg_postinst() {
>	elog "For the game to work properly, please copy your"
>	elog 'Heroes Of Might and Magic ("The Wake Of Gods" or'
>	elog '"Shadow of Death" or "Complete edition")'
>	elog "game directory into /usr/share/${PN}."
>	elog "or use 'vcmibuilder' utility on your:"
>	elog "   a) One or two CD's or CD images"
>	elog "   b) gog.com installer"
>	elog "   c) Directory with installed game"
>	elog "(although installing it in such way is 'bad practices')."
>	elog "For more information, please visit:"
>	elog "http://wiki.vcmi.eu/index.php?title=Installation_on_Linux"
>	elog ""
>	elog "Also, you may want to install VCMI Extras and Wake of Gods"
>	elog "mods from the launcher after you'll start the game"
>}

[Comment 3 Michał Dec 2023-05-04 16:31:07 UTC]

Debug should also be disabled by default.

[Comment 4 Larry the Git Cow 2024-01-15 16:59:36 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/proj/gamerlay.git/commit/?id=cc94c1ccdb5805a994ba097ea6acf31a0d4d4f3d

commit cc94c1ccdb5805a994ba097ea6acf31a0d4d4f3d
Author:     Vadim Misbakh-Soloviov <[e-mail]>
AuthorDate: 2024-01-15 16:51:37 +0000
Commit:     Vadim Misbakh-Soloviov <[e-mail]>
CommitDate: 2024-01-15 16:55:48 +0000

    games-strategy/vcmi: Bump
    
    Closes: https://bugs.gentoo.org/905707
    Signed-off-by: Vadim Misbakh-Soloviov <[e-mail]>

 games-strategy/vcmi/Manifest                               |  2 +-
 games-strategy/vcmi/metadata.xml                           | 14 ++++++++++----
 .../vcmi/{vcmi-1.2.0.ebuild => vcmi-1.4.2.ebuild}          | 11 +++++++----
 3 files changed, 18 insertions(+), 9 deletions(-)