Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 905664 - dev-libs/fuzzylite-6.0::gamerlay requires fixes for GCC 12
Summary: dev-libs/fuzzylite-6.0::gamerlay requires fixes for GCC 12
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Overlays (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Vadim A. Misbakh-Soloviov (mva)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-05-03 20:12 UTC by Michał Dec
Modified: 2024-01-15 17:15 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
This patch adds extra preprocessor statements to make this work without warnings (0000-add-gcc11-12-support.patch,823 bytes, patch)
2023-05-03 20:12 UTC, Michał Dec
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Dec 2023-05-03 20:12:08 UTC
Created attachment 861101 [details, diff]
This patch adds extra preprocessor statements to make this work without warnings

Fuzzylite 6.0 will fail to compile with the current ebuild if we're using GCC 12.0.0 or newer.

The bug is not reproducible if:
- you are not using GCC, i.e. you're using pretty much any other C++ compiler
- or if you are using GCC 11.x.x

The compilation is done with -Werror which means the relatively trivial warning that std::set_unexpected is deprecated, turns into a showstopper issue.

std::set_unexpected is removed in C++17 and should be perfectly fine to use in C++11, but for some reason GCC 12 throws a warning. Probably to send a message to devs that they should stop relying on this function call.

Nevertheless, this issue presents patches that fix this issue. Upstream has actually fixed this in https://github.com/fuzzylite/fuzzylite/commit/da4e875bb83a6e569d423405acc0f51f80781509

The patches presented in this issue hope to support fuzzylite with both GCC 12 and pre-12. The uploaded patch differs slightly, because you can still trigger warnings with GCC 12 when satisfying this preprocessor statement.
Comment 1 Michał Dec 2023-05-04 15:59:59 UTC
The only user of fuzzylite in gamerlay is VCMI. In order for VCMI to work correctly, fuzzylite needs to be compiled with -DFL_USE_FLOAT=OFF as well.
Comment 2 Larry the Git Cow gentoo-dev 2024-01-15 17:15:16 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/proj/gamerlay.git/commit/?id=e4f29b9e8c08ff10e242ac32eaec2381161ae27c

commit e4f29b9e8c08ff10e242ac32eaec2381161ae27c
Author:     Vadim Misbakh-Soloviov <mva@gentoo.org>
AuthorDate: 2024-01-15 17:14:58 +0000
Commit:     Vadim Misbakh-Soloviov <mva@gentoo.org>
CommitDate: 2024-01-15 17:14:58 +0000

    dev-libs/fuzzylite: Some more fixes
    
    Closes: https://bugs.gentoo.org/905664
    Signed-off-by: Vadim Misbakh-Soloviov <mva@gentoo.org>

 .../fuzzylite/files/0000-add-gcc11-12-suppor.patch | 24 ++++++++++++++++++++++
 dev-libs/fuzzylite/fuzzylite-6.0.ebuild            |  6 ++++--
 2 files changed, 28 insertions(+), 2 deletions(-)