Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 903575 - dev-qt/qtlocation-5.15.8: Missing include when building with libcxx
Summary: dev-qt/qtlocation-5.15.8: Missing include when building with libcxx
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Qt Bug Alias
URL:
Whiteboard:
Keywords: PATCH, UPSTREAM
Depends on:
Blocks: systemwide-libcxx
  Show dependency tree
 
Reported: 2023-03-30 12:25 UTC by Manuel Nickschas
Modified: 2023-04-12 12:14 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log.gz,11.10 KB, application/gzip)
2023-03-30 12:26 UTC, Manuel Nickschas
Details
emerge --info (emerge.info.gz,7.21 KB, application/gzip)
2023-03-30 12:26 UTC, Manuel Nickschas
Details
fix-missing-include.patch (fix-missing-include.patch,351 bytes, patch)
2023-03-30 12:26 UTC, Manuel Nickschas
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Manuel Nickschas 2023-03-30 12:25:20 UTC
Header misses an #include <utility> to make std::move() available. Works with default toolchain, however fails with Clang+libcxx most likely due to some transitive include not being there:

/var/tmp/portage/dev-qt/qtlocation-5.15.8/work/qtlocation-everywhere-src-5.15.8/src/3rdparty/mapbox-gl-native/include/mbgl/util/unique_any.hpp:51:31: error: no member named 'move' in namespace 'std'
            vtable->move(std::move(rhs.storage), storage);

Patch attached.

Reproducible: Always

Steps to Reproduce:
1. Try to build dev-qt/qtlocation with Clang+libcxx
2.
3.
Actual Results:  
Compilation fails due to missing header

Expected Results:  
Package should be buildable with Clang+libcxx

This issue was already around with Clang 15. With Clang 16, package fails to build even with the attached patch due to bug 895516. Reporting as a separate issue anyway, since these are two different things.
Comment 1 Manuel Nickschas 2023-03-30 12:26:02 UTC
Created attachment 859265 [details]
build.log
Comment 2 Manuel Nickschas 2023-03-30 12:26:20 UTC
Created attachment 859266 [details]
emerge --info
Comment 3 Manuel Nickschas 2023-03-30 12:26:52 UTC
Created attachment 859267 [details, diff]
fix-missing-include.patch
Comment 4 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-03-30 13:48:42 UTC
meh, mapbox-gl-native again. It's gone in Qt 6, thankfully.
Comment 5 Larry the Git Cow gentoo-dev 2023-04-12 12:14:59 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b0b8ec0eb0812395514c4ff9f48448fe80ba651b

commit b0b8ec0eb0812395514c4ff9f48448fe80ba651b
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2023-04-12 07:44:07 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2023-04-12 12:13:46 +0000

    dev-qt/qtlocation: Fix build with libcxx
    
    Closes: https://bugs.gentoo.org/903575
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 ...tlocation-5.15.8-mapboxgl-missing-include.patch | 26 ++++++++++++++++++++++
 dev-qt/qtlocation/qtlocation-5.15.8.ebuild         |  5 ++++-
 2 files changed, 30 insertions(+), 1 deletion(-)