Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 900248 - app-arch/sharutils-4.15.2-r2 has implicit function declarations in configure logs (GCC-13-SYSTEM)
Summary: app-arch/sharutils-4.15.2-r2 has implicit function declarations in configure ...
Status: CONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks: implicit-in-configure gcc-14-stable
  Show dependency tree
 
Reported: 2023-03-08 08:16 UTC by Agostino Sarubbo
Modified: 2025-02-10 19:09 UTC (History)
6 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,157.30 KB, text/plain)
2023-03-08 08:16 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2023-03-08 08:16:29 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: app-arch/sharutils-4.15.2-r2 has implicit function declarations in configure logs (GCC-13-SYSTEM).
Discovered on: amd64 (internal ref: gcc13_tinderbox)

NOTE:
(GCC-13-SYSTEM) in the summary means that the bug was found on a machine that runs gcc-13 but this bug MAY or MAY NOT BE related to the new compiler
See also: https://bugs.gentoo.org/898488#c4.
Comment 1 Agostino Sarubbo gentoo-dev 2023-03-08 08:16:31 UTC
Created attachment 856682 [details]
build.log

build log and emerge --info
Comment 2 Dennis Clarke 2024-12-20 04:09:52 UTC
emerge will fail due to modern GCC 14.x being a bit picky about :

shar.c: In function 'initialize':
shar.c:2331:3: error: implicit declaration of function 'bindtextdomain' [-Wimplicit-function-declaration]
 2331 |   bindtextdomain (PACKAGE, LOCALEDIR);
      |   ^~~~~~~~~~~~~~
shar.c:2332:3: error: implicit declaration of function 'textdomain' [-Wimplicit-function-declaration]
 2332 |   textdomain (PACKAGE);
      |   ^~~~~~~~~~

The trivial hack/workaround is to slide in -Wno-implicit-function-declaration :

chroot# grep 'COMMON_FLAGS' /etc/portage/make.conf
COMMON_FLAGS="-march=k8 -mtune=k8 -O2 -pipe -Wno-implicit-function-declaration"
CFLAGS="${COMMON_FLAGS}"
CXXFLAGS="${COMMON_FLAGS}"
FCFLAGS="${COMMON_FLAGS}"
FFLAGS="${COMMON_FLAGS}"
chroot# 

That solves that.
Comment 3 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-12-20 06:45:10 UTC
(In reply to Dennis Clarke from comment #2)
> emerge will fail due to modern GCC 14.x being a bit picky about :
> 

I think your bug is probably bug 894322.
Comment 4 Larry the Git Cow gentoo-dev 2025-01-23 18:27:16 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=319c1a011cc04637dc556b3a80d5173a6a01abb0

commit 319c1a011cc04637dc556b3a80d5173a6a01abb0
Author:     NHOrus <jy6x2b32pie9@yahoo.com>
AuthorDate: 2025-01-22 14:25:36 +0000
Commit:     Arthur Zamarin <arthurzam@gentoo.org>
CommitDate: 2025-01-23 18:27:10 +0000

    app-arch/sharutils: update EAPI 7 -> 8, fix modern C issues
    
    Patch removes which from m4 macros and regenerates configure.
    Patch adds include of lib/gettext.h into only place it can go
    so it works in glibc and musl - in the middle of *-opts.h file,
    after condifional declaration of gettext or inclusion of libintl,
    but before gettext is actually used.
    In other places funky macro dance either undefines gettext or
    uses it before marking it with asm attributes.
    This supercedes other PR, and also lets all code to be aware of all
    the defines from config.h and friends.
    
    Closes: https://bugs.gentoo.org/941724
    Closes: https://bugs.gentoo.org/894322
    Bug: https://bugs.gentoo.org/900248
    Closes: #31725
    Signed-off-by: NHOrus <jy6x2b32pie9@yahoo.com>
    Closes: https://github.com/gentoo/gentoo/pull/40259
    Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>

 .../sharutils/files/sharutils-4.15.2-C23.patch     | 50 ++++++++++++++++++++++
 .../sharutils/files/sharutils-4.15.2-dewhich.patch | 32 ++++++++++++++
 ...4.15.2-r2.ebuild => sharutils-4.15.2-r3.ebuild} | 22 +++++++---
 3 files changed, 98 insertions(+), 6 deletions(-)
Comment 5 Klaus Kusche 2025-01-24 13:54:39 UTC
app-arch/sharutils-4.15.2-r3 (should have that patch?!) is still broken for me:

I get tons of "implicit declaration of function 'bindtextdomain'" and
"implicit declaration of function 'textdomain'" and 
"implicit declaration of function 'gettext'" 
during the compile phase (*not* in configure) 
in uuencode.c, uudecode.c, unshar.c and shar.c .
Comment 6 Jaco Kroon 2025-01-30 12:51:03 UTC
(In reply to Klaus Kusche from comment #5)
> app-arch/sharutils-4.15.2-r3 (should have that patch?!) is still broken for
> me:
> 
> I get tons of "implicit declaration of function 'bindtextdomain'" and
> "implicit declaration of function 'textdomain'" and 
> "implicit declaration of function 'gettext'" 
> during the compile phase (*not* in configure) 
> in uuencode.c, uudecode.c, unshar.c and shar.c .

Missing #include <libintl.h> for those.
Comment 7 Preston Crow 2025-02-10 19:09:55 UTC
Looks like the same bug as https://bugs.gentoo.org/949267
It builds fine with USE=nls.