Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 898488 - net-misc/asterisk-18.16.0 has implicit function declarations in configure logs
Summary: net-misc/asterisk-18.16.0 has implicit function declarations in configure logs
Status: RESOLVED INVALID
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Jaco Kroon
URL:
Whiteboard: false positive
Keywords:
Depends on:
Blocks: c99-porting
  Show dependency tree
 
Reported: 2023-02-28 18:14 UTC by Agostino Sarubbo
Modified: 2023-03-07 18:17 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,953.54 KB, text/plain)
2023-02-28 18:14 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2023-02-28 18:14:44 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: net-misc/asterisk-18.16.0 has implicit function declarations in configure logs.
Discovered on: amd64 (internal ref: ci)
Comment 1 Agostino Sarubbo gentoo-dev 2023-02-28 18:14:47 UTC
Created attachment 855318 [details]
build.log

build log and emerge --info
Comment 2 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-02-28 23:45:11 UTC
 *   /var/tmp/portage/net-misc/asterisk-18.16.0/work/asterisk-18.16.0/config.log:6211 - htonll
 *   /var/tmp/portage/net-misc/asterisk-18.16.0/work/asterisk-18.16.0/config.log:6444 - ntohll
 *   /var/tmp/portage/net-misc/asterisk-18.16.0/work/asterisk-18.16.0/config.log:11532 - res_ndestroy

htonll/ntohll don't exist on linux; res_ndestroy is gone in newer glibc, so this is more-or-less a fp
Comment 3 Jaco Kroon 2023-03-01 03:09:32 UTC
This is definitely a false positive, the check is specifically designed to check for the availability of those functions, in particular res_ndestroy check is used to decide whether to use res_ndestroy vs res_nclose, and ntonll check is designed to decide whether or not to compile the asterisk htonll variant from it's compat code.

I'm guessing there are a fair number of ./configure tests which works in a similar manner, if there is a way to "fix" this I'll submit upstream, but for now I'm going to close this with INVALID.
Comment 4 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-03-01 03:16:01 UTC
(In reply to Jaco Kroon from comment #3)
> This is definitely a false positive, the check is specifically designed to
> check for the availability of those functions, in particular res_ndestroy
> check is used to decide whether to use res_ndestroy vs res_nclose, and
> ntonll check is designed to decide whether or not to compile the asterisk
> htonll variant from it's compat code.
> 
> I'm guessing there are a fair number of ./configure tests which works in a
> similar manner, if there is a way to "fix" this I'll submit upstream, but
> for now I'm going to close this with INVALID.

You can add them to QA_CONFIG_IMPL_DECL_SKIP in the ebuild with a commment, like:

QA_CONFIG_IMPL_DECL_SKIP=(
    func1 # uses a fallback
    func2 # blah
)
Comment 5 Larry the Git Cow gentoo-dev 2023-03-07 18:14:05 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a87879f8046d39c966b04d3a1fa6054d4a1ce216

commit a87879f8046d39c966b04d3a1fa6054d4a1ce216
Author:     Thomas Beierlein <tomjbe@gentoo.org>
AuthorDate: 2023-03-07 18:06:48 +0000
Commit:     Thomas Beierlein <tomjbe@gentoo.org>
CommitDate: 2023-03-07 18:13:33 +0000

    media-radio/tlf: Skip check for implicit function declaration in config logs
    
    ax_with_curses.m4 ifrom autoconf-archive checks potential available
    ncursesw header file locations. If header file is not found the check
    results in an implicit function declaration.
    
    Closes: https://bugs.gentoo.org/898488
    Signed-off-by: Thomas Beierlein <tomjbe@gentoo.org>

 media-radio/tlf/tlf-1.4.1-r2.ebuild | 56 +++++++++++++++++++++++++++++++++++++
 1 file changed, 56 insertions(+)
Comment 6 Thomas Beierlein gentoo-dev 2023-03-07 18:17:11 UTC
Sorry wrong bug number in commit (see comment #5) which fixes bug #899842.

Setting status back to 'INVALID'