Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 899568 - net-libs/nghttp2-1.51.0-r1 has implicit function declarations in configure logs
Summary: net-libs/nghttp2-1.51.0-r1 has implicit function declarations in configure logs
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Bernard Cafarelli
URL:
Whiteboard: false positive?
Keywords:
Depends on:
Blocks: c99-porting
  Show dependency tree
 
Reported: 2023-03-04 08:58 UTC by Agostino Sarubbo
Modified: 2025-03-18 00:46 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,98.06 KB, text/plain)
2023-03-04 08:58 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2023-03-04 08:58:28 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: net-libs/nghttp2-1.51.0-r1 has implicit function declarations in configure logs.
Discovered on: amd64 (internal ref: ci)

NOTE:
See also: https://bugs.gentoo.org/898488#c4.
Comment 1 Agostino Sarubbo gentoo-dev 2023-03-04 08:58:31 UTC
Created attachment 856072 [details]
build.log

build log and emerge --info
Comment 2 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-03-04 09:26:10 UTC
Probably a FP
Comment 3 Bernard Cafarelli gentoo-dev 2023-03-04 10:36:19 UTC
Indeed, one is for boringssl specific function, the other is quic patched openssl.

I may switch to cmake with just release 1.52.0 (which drops several deprecated features too) and from quick check it will be better then.

Though for general thoughts I wonder if these checks are maintainable long-term, so many configure scripts test for optional supported features that way (already 14 bugs in my backlog to go through)...
Comment 4 Larry the Git Cow gentoo-dev 2023-03-13 22:38:14 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3a38f9b245e674722d5d58dfbb6baafca2b26975

commit 3a38f9b245e674722d5d58dfbb6baafca2b26975
Author:     Bernard Cafarelli <voyageur@gentoo.org>
AuthorDate: 2023-03-13 22:33:49 +0000
Commit:     Bernard Cafarelli <voyageur@gentoo.org>
CommitDate: 2023-03-13 22:38:11 +0000

    net-libs/nghttp2: add 1.52.0
    
    This release removed the deprecated Python bindings and libnghttp2_asio
    (C++) lib
    
    Switch to cmake build
    
    Closes: https://bugs.gentoo.org/899568
    Signed-off-by: Bernard Cafarelli <voyageur@gentoo.org>

 net-libs/nghttp2/Manifest              |  1 +
 net-libs/nghttp2/nghttp2-1.52.0.ebuild | 58 ++++++++++++++++++++++++++++++++++
 2 files changed, 59 insertions(+)
Comment 5 Larry the Git Cow gentoo-dev 2025-03-18 00:28:04 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a7716d6ed1fbff2e7c27618aa2f7d24bc748f7d1

commit a7716d6ed1fbff2e7c27618aa2f7d24bc748f7d1
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2025-03-17 23:56:52 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2025-03-18 00:27:39 +0000

    net-libs/nghttp2: switch back to autotools, rather than cmake
    
    Naive first pass based on the live ebuild from 3a38f9b245e674722d5d58dfbb6baafca2b26975
    (live ebuild was done in subsequent commit).
    
    We need to use autotools rather than CMake here because of a circular
    dependency (ditto nghttp2):
    ```
    (net-misc/curl-8.11.1-r2:0/0::gentoo, ebuild scheduled for merge) depends on
     (net-libs/nghttp3-1.7.0:0/0::gentoo, ebuild scheduled for merge) (buildtime)
      (dev-build/cmake-3.31.5:0/0::gentoo, ebuild scheduled for merge) (buildtime)
       (net-misc/curl-8.11.1-r2:0/0::gentoo, ebuild scheduled for merge) (buildtime)
    ```
    
    I've taken the opportunity to add a live ebuild template to allow
    easier syncing. I'm going to make some followup changes to deps to clean
    them up a bit (I think, needs checking) but I want to do that separately
    as I want to stabilise this version quickly.
    
    Bug: https://bugs.gentoo.org/899568
    Closes: https://bugs.gentoo.org/951525
    Signed-off-by: Sam James <sam@gentoo.org>

 net-libs/nghttp2/nghttp2-1.65.0-r1.ebuild | 68 +++++++++++++++++++++++++++++
 net-libs/nghttp2/nghttp2-9999.ebuild      | 71 +++++++++++++++++--------------
 2 files changed, 108 insertions(+), 31 deletions(-)
Comment 6 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2025-03-18 00:46:37 UTC
I don't see these anymore with the latest version + autotools. Can look int oit if it reappears.