Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 899024 - games-util/qstat-2.14 has implicit function declarations in configure logs (GCC-13-SYSTEM)
Summary: games-util/qstat-2.14 has implicit function declarations in configure logs (G...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Games
URL:
Whiteboard:
Keywords: PATCH, PullRequest
Depends on:
Blocks: implicit-in-configure gcc-14-stable
  Show dependency tree
 
Reported: 2023-03-03 08:46 UTC by Agostino Sarubbo
Modified: 2025-02-10 08:56 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,59.29 KB, text/plain)
2023-03-03 08:46 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2023-03-03 08:46:43 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: games-util/qstat-2.14 has implicit function declarations in configure logs (GCC-13-SYSTEM).
Discovered on: amd64 (internal ref: gcc13_tinderbox)

NOTE:
(GCC-13-SYSTEM) in the summary means that the bug was found on a machine that runs gcc-13 but this bug MAY or MAY NOT BE related to the new compiler
See also: https://bugs.gentoo.org/898488#c4.
Comment 1 Agostino Sarubbo gentoo-dev 2023-03-03 08:46:45 UTC
Created attachment 855932 [details]
build.log

build log and emerge --info
Comment 3 NHO 2025-01-26 15:12:23 UTC
While making a package bump, I learned that my previous assertion was incorrect, strnstr still being tested for.
Either way, there's a fallback strnstr implementation, it's safe to ignore.
Comment 4 Larry the Git Cow gentoo-dev 2025-02-10 08:56:29 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=46ae3b8e567d43a891f8818bb92b6258b412e07e

commit 46ae3b8e567d43a891f8818bb92b6258b412e07e
Author:     NHOrus <jy6x2b32pie9@yahoo.com>
AuthorDate: 2025-01-26 15:18:18 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2025-02-10 08:54:22 +0000

    games-util/qstat: Remove bad function pointer cast, C23 porting
    
    Existing function pointer is already of correct type, any additional
    casting is superfluous, and in this case lacks argument types.
    Safely removed.
    Added strnstr to whitelist of QA checks for implicit declarations:
    there is a fallback implementation, safe to ignore
    
    Closes: https://bugs.gentoo.org/899024
    Bug: https://bugs.gentoo.org/944360
    Signed-off-by: NHOrus <jy6x2b32pie9@yahoo.com>
    Signed-off-by: Sam James <sam@gentoo.org>

 games-util/qstat/Manifest                                  |  1 +
 games-util/qstat/files/qstat-2.14-unneeded-cast.patch      | 14 ++++++++++++++
 .../qstat/{qstat-2.14.ebuild => qstat-2.14-r1.ebuild}      | 13 +++++++++----
 3 files changed, 24 insertions(+), 4 deletions(-)