Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 898992 - games-strategy/lgeneral-1.4.4 has implicit function declarations in configure logs (GCC-13-SYSTEM)
Summary: games-strategy/lgeneral-1.4.4 has implicit function declarations in configure...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Games
URL:
Whiteboard: ~arch only
Keywords: PullRequest
Depends on:
Blocks: implicit-in-configure
  Show dependency tree
 
Reported: 2023-03-03 08:43 UTC by Agostino Sarubbo
Modified: 2025-02-22 23:48 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,133.70 KB, text/plain)
2023-03-03 08:43 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2023-03-03 08:43:40 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: games-strategy/lgeneral-1.4.4 has implicit function declarations in configure logs (GCC-13-SYSTEM).
Discovered on: amd64 (internal ref: gcc13_tinderbox)

NOTE:
(GCC-13-SYSTEM) in the summary means that the bug was found on a machine that runs gcc-13 but this bug MAY or MAY NOT BE related to the new compiler
See also: https://bugs.gentoo.org/898488#c4.
Comment 1 Agostino Sarubbo gentoo-dev 2023-03-03 08:43:42 UTC
Created attachment 855900 [details]
build.log

build log and emerge --info
Comment 2 NHO 2025-02-22 10:06:48 UTC
That's Microsoft Windows header for DirectX...
Comment 3 NHO 2025-02-22 11:41:23 UTC
Configure in this package doesn't actually comes from configure.ac that is shipped with this package.
But both configure and configure.ac set CFLAGS, to clobber whatever packagers do:

CFLAGS="$CFLAGS -Wall -std=gnu89"
CFLAGS="$CFLAGS -O0 -g"
Comment 4 Larry the Git Cow gentoo-dev 2025-02-22 23:48:52 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e98ac25f1e02a223b80897ac29f818ef5cab1d71

commit e98ac25f1e02a223b80897ac29f818ef5cab1d71
Author:     NHOrus <jy6x2b32pie9@yahoo.com>
AuthorDate: 2025-02-22 11:46:13 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2025-02-22 23:47:21 +0000

    games-strategy/lgeneral: update EAPI 7 -> 8, fix build
    
    Remove hardcoded CFLAGS, fix broken test, copy Debian patch for makefile,
    remove pathologically many inlined functions that broke the linking.
    
    Closes: https://bugs.gentoo.org/876337
    Closes: https://bugs.gentoo.org/898992
    Signed-off-by: NHOrus <jy6x2b32pie9@yahoo.com>
    Closes: https://github.com/gentoo/gentoo/pull/40700
    Signed-off-by: Sam James <sam@gentoo.org>

 .../lgeneral/files/lgeneral-1.4.4-configure.patch  |  24 ++
 .../lgeneral-1.4.4-remove-defs-from-header.patch   |  29 ++
 .../lgeneral/files/lgeneral-1.4.4-uninline.patch   | 471 +++++++++++++++++++++
 .../lgeneral/files/update_autotools.patch          | 278 ++++++++++++
 ...neral-1.4.4.ebuild => lgeneral-1.4.4-r1.ebuild} |  16 +-
 5 files changed, 815 insertions(+), 3 deletions(-)