https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/ Issue: app-backup/bareos-21.1.6 has implicit function declarations in configure logs. Discovered on: amd64 (internal ref: ci) NOTE: See also: https://bugs.gentoo.org/898488#c4.
Created attachment 855506 [details] build.log build log and emerge --info
pthread_attr_get_np needs GNU_SOURCE, need to check if test accounts for this
ci has reproduced this issue with version 22.0.2 - Updating summary.
(In reply to Agostino Sarubbo from comment #3) > ci has reproduced this issue with version 22.0.2 - Updating summary. Can you still reproduce with current version?
(In reply to Marc Schiffbauer from comment #4) > (In reply to Agostino Sarubbo from comment #3) > > ci has reproduced this issue with version 22.0.2 - Updating summary. > > Can you still reproduce with current version? Yes, do you not get the warning? The check hasn't changed since this bug was reported. The general shape of these bugs is: """ * the CMake check silently "passes" without the correct include/matching feature test macro (_GNU_SOURCE) -> pthread_attr_get_np is normally found on glibc systems, despite the -Wimplicit-function-declaration warning * stricter C compilers are making -Wimplicit-function-declaration an error by default * the check will then start to fail, despite the function existing on the system, because the check has an error in it (missing the macro) """ ... but, as I sort of hinted at in my comment in https://bugs.gentoo.org/898656#c2, you have to check if the test is ever supposed to pass. In this case, pthread_attr_get_np doesn't exist on Linux, so it's a false positive. Hence you should just add it to QA_CONFIG_IMPL_DECL_SKIP in the ebuild.
Thanks Sam, much appreciated! But unfortunately I cannot reproduce this here: Portage 3.0.51 (python 3.11.5-final-0, default/linux/amd64/17.1, gcc-13, glibc-2.37-r7, 6.1.57-gentoo-x86_64 x86_64) ================================================================= System uname: Linux-6.1.57-gentoo-x86_64-x86_64-Intel-R-_Core-TM-_i7-10510U_CPU_@_1.80GHz-with-glibc2.37 KiB Mem: 65550252 total, 31466796 free KiB Swap: 33554428 total, 32965264 free Timestamp of repository gentoo: Sun, 03 Dec 2023 00:45:01 +0000 Head commit of repository gentoo: ac0bc46eaa27105ea7ca3d854ecaeaa3b99e9880 sh bash 5.1_p16-r6 ld GNU ld (Gentoo 2.40 p7) 2.40.0 app-misc/pax-utils: 1.3.5::gentoo app-shells/bash: 5.1_p16-r6::gentoo dev-lang/perl: 5.38.0-r1::gentoo dev-lang/python: 3.11.5::gentoo dev-util/cmake: 3.27.9::gentoo-git dev-util/meson: 1.2.3::gentoo sys-apps/baselayout: 2.14::gentoo sys-apps/openrc: 0.48::gentoo sys-apps/sandbox: 2.38::gentoo sys-devel/autoconf: 2.71-r6::gentoo sys-devel/automake: 1.16.5-r1::gentoo sys-devel/binutils: 2.40-r9::gentoo sys-devel/binutils-config: 5.5::gentoo sys-devel/gcc: 13.2.1_p20230826::gentoo sys-devel/gcc-config: 2.11::gentoo sys-devel/libtool: 2.4.7-r1::gentoo sys-devel/make: 4.4.1-r1::gentoo sys-kernel/linux-headers: 6.1::gentoo (virtual/os-headers) sys-libs/glibc: 2.37-r7::gentoo Repositories: gentoo location: /var/db/repos/gentoo sync-type: rsync sync-uri: rsync://rsync.gentoo.org/gentoo-portage priority: -1000 volatile: False sync-rsync-extra-opts: sync-rsync-verify-jobs: 1 sync-rsync-verify-max-age: 24 sync-rsync-verify-metamanifest: yes gentoo-git location: /var/db/repos/gentoo-git priority: 50 volatile: False Binary Repositories: gentoobinhost priority: 1 sync-uri: https://gentoo.osuosl.org/releases/amd64/binpackages/17.1/x86-64 ACCEPT_KEYWORDS="amd64" ACCEPT_LICENSE="@FREE" CBUILD="x86_64-pc-linux-gnu" CFLAGS="-O2 -pipe" CHOST="x86_64-pc-linux-gnu" CONFIG_PROTECT="/etc /usr/share/gnupg/qualified.txt" CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/gconf /etc/gentoo-release /etc/sandbox.d /etc/terminfo" CXXFLAGS="-O2 -pipe" DISTDIR="/app/container/cache/portage/distfiles" EMERGE_DEFAULT_OPTS="-k --autounmask-continue y " ENV_UNSET="CARGO_HOME DBUS_SESSION_BUS_ADDRESS DISPLAY GDK_PIXBUF_MODULE_FILE GOBIN GOPATH PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR XDG_STATE_HOME" FCFLAGS="-O2 -pipe" FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs binpkg-multi-instance buildpkg buildpkg-live config-protect-if-modified distlocks ebuild-locks fixlafiles merge-sync multilib-strict news parallel-fetch preserve-libs protect-owned qa -unresolved-soname-deps sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr" FFLAGS="-O2 -pipe" GENTOO_MIRRORS="http://distfiles.gentoo.org" LANG="C.UTF8" LDFLAGS="-Wl,-O1 -Wl,--as-needed" LEX="flex" PKGDIR="/app/container/cache/portage/packages" PORTAGE_CONFIGROOT="/" PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git" PORTAGE_TMPDIR="/var/tmp" USE="acl amd64 bzip2 cli crypt dri fortran gdbm iconv ipv6 libtirpc multilib ncurses nls nptl openmp pam pcre readline seccomp split-usr ssl test-rust unicode xattr zlib" ABI_X86="64" ADA_TARGET="gnat_2021" APACHE2_MODULES="authn_core authz_core socache _shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext _filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon sheets words" COLLECTD_PLUGINS="df interface irq loa d memory rrdtool swap syslog" CPU_FLAGS_X86="mmx mmxext sse sse2" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock greis isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 s irf skytraq superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="libinput" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LUA_SIN GLE_TARGET="lua5-1" LUA_TARGETS="lua5-1" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php8-1" POSTGRES_TARGETS="postgres15" PYTHON_SINGLE_TARGET="python3_11" PYTHON_TARGETS="python3_11" RUBY_TARGETS="ruby31" VIDEO_CARDS="amdgpu fbdev intel nouveau r adeon radeonsi vesa dummy v4l" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq proto steal rawnat logmark ipmark dhcpmac delude chaos account" Unset: ADDR2LINE, AR, ARFLAGS, AS, ASFLAGS, CC, CCLD, CONFIG_SHELL, CPP, CPPFLAGS, CTARGET, CXX, CXXFILT, ELFEDIT, EXTRA_ECONF, F77FLAGS, FC, GCOV, GPROF, INSTALL_MASK, LC_ALL, LD, LFLAGS, LIBTOOL, LINGUAS, MAKE, MAKEFLAGS, MAKEOPTS, NM, OBJCOPY, OBJDU MP, PORTAGE_BINHOST, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, RANLIB, READELF, RUSTFLAGS, SHELL, SIZE, STRINGS, STRIP, YACC, YFLAGS [...] -- Installing: /var/tmp/portage/app-backup/bareos-22.1.2-r1/image/usr/lib64/bareos/plugin/BareosDirPluginNscaSender.py -- Installing: /var/tmp/portage/app-backup/bareos-22.1.2-r1/image/usr/lib64/bareos/plugin/bareos-dir-nsca-sender.py removed '/var/tmp/portage/app-backup/bareos-22.1.2-r1/image/usr/share/man/man8/bscrypto.8' >>> Completed installing app-backup/bareos-22.1.2-r1 into /var/tmp/portage/app-backup/bareos-22.1.2-r1/image * Final size of build directory: 138520 KiB (135.2 MiB) * Final size of installed tree: 11408 KiB ( 11.1 MiB) strip: x86_64-pc-linux-gnu-strip --strip-unneeded -N __gentoo_check_ldflags__ -R .comment -R .GCC.command.line -R .note.gnu.gold-version /usr/sbin/bareos-fd /usr/bin/bsmtp /usr/bin/bwild /usr/bin/bregex /usr/sbin/btestls /usr/lib64/libbareoscats.so.22.1.2 /usr/sbin/bpluginfo /usr/sbin/bscrypto /usr/lib64/bareos/backend/libbareoscats-postgresql.so /usr/lib64/libbareossql.so.22.1.2 /usr/lib64/libbareossd.so.22.1.2 /usr/sbin/bls /usr/sbin/bextract /usr/sbin/bscan /usr/sbin/btape /usr/sbin/bareos-sd /usr/sbin/bcopy /usr/lib64/bareos/backend/libbareossd-file.so /usr/lib64/bareos/backend/libbareossd-fifo.so /usr/lib64/bareos/backend/libbareossd-tape.so /usr/sbin/testfind /usr/sbin/bareos-dbcheck /usr/bin/bconsole /usr/sbin/bareos-dir /usr/lib64/bareos/plugin/python3-dir.so /usr/lib64/libbareosfind.so.22.1.2 /usr/lib/python3.11/site-packages/bareosdir.cpython-311-x86_64-linux-gnu.so /usr/lib64/libbareos.so.22.1.2 /usr/lib64/bareos/plugin/python3-sd.so /usr/lib/python3.11/site-packages/bareossd.cpython-311-x86_64-linux-gnu.so /usr/lib64/bareos/plugin/autoxflate-sd.so /usr/lib64/bareos/plugin/scsicrypto-sd.so /usr/lib64/bareos/plugin/python3-fd.so /usr/lib64/bareos/plugin/scsitapealert-sd.so /usr/lib/python3.11/site-packages/bareosfd.cpython-311-x86_64-linux-gnu.so /usr/lib64/bareos/plugin/bpipe-fd.so /usr/lib64/libbareosfastlz.so.22.1.2 >>> Done. >>> Installing (1 of 1) app-backup/bareos-22.1.2-r1::gentoo-git
I can't reproduce either, or at least not with current versions and gcc13. Tried both 21.1.8 and 22.1.2 with same USE. Haven't looked that closely though. The check still works fwiw, I tried to removing a SKIP I had in another package and the message came back. I just don't get it for this package.
(In reply to Ionen Wolkens from comment #7) > The check still works fwiw, I tried to removing a SKIP I had in another > package and the message came back. I just don't get it for this package. Huh... looking at the workdir, it did not even produce a CMakeError.log, but I can find the implicit error message in CMakeConfigureLog.yaml instead. did dev-util/cmake change something?
(In reply to Ionen Wolkens from comment #8) > (In reply to Ionen Wolkens from comment #7) > > The check still works fwiw, I tried to removing a SKIP I had in another > > package and the message came back. I just don't get it for this package. > Huh... looking at the workdir, it did not even produce a CMakeError.log, but > I can find the implicit error message in CMakeConfigureLog.yaml instead. > > did dev-util/cmake change something? Well, I can't reproduce with stable cmake either, so maybe not.
Well, stable's 3.27.7 was just not old enough I guess. Apparently CMakeConfigureLog.yaml is from cmake-3.26+ [1] which also removes CmakeError.log [2] This bug was filed with cmake-3.25.x in emerge --info (gone from the tree so haven't bothered to try it). [1] https://cmake.org/cmake/help/latest/release/3.26.html#configure-log [2] https://cmake.org/cmake/help/latest/release/3.26.html#deprecated-and-removed-features (In reply to Sam James from comment #5) > (In reply to Marc Schiffbauer from comment #4) > > (In reply to Agostino Sarubbo from comment #3) > > > ci has reproduced this issue with version 22.0.2 - Updating summary. > > > > Can you still reproduce with current version? > > Yes, do you not get the warning? The check hasn't changed since this bug was > reported. Are you sure you're still able to reproduce? I mean the implicit is still real, but the log to be parsed seems gone.
I suspect such a QA Notice should be silenced by adding an include line for the culprit function.
