Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 893982 - >=dev-libs/libfilezilla-0.39.1-r1 build failure with gcc-13 due to missing include
Summary: >=dev-libs/libfilezilla-0.39.1-r1 build failure with gcc-13 due to missing in...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: AMD64 Linux
: Normal normal (vote)
Assignee: Bernard Cafarelli
URL: https://trac.filezilla-project.org/ti...
Whiteboard:
Keywords: PATCH
Depends on:
Blocks: gcc-13
  Show dependency tree
 
Reported: 2023-02-12 01:39 UTC by Ninpo
Modified: 2023-02-16 09:22 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
libfilezilla build.log (build.log,407.28 KB, text/x-log)
2023-02-12 01:39 UTC, Ninpo
Details
libfilezilla-cstdin-include.patch (libfilezilla-cstdin-include.patch,2.10 KB, patch)
2023-02-12 19:39 UTC, Ninpo
Details | Diff
libfilezilla-0.39.1-r1-cstdin-include.patch (libfilezilla-cstdin-include.patch,1.87 KB, patch)
2023-02-12 19:49 UTC, Ninpo
Details | Diff
libfilezilla-0.41.0-cstdin-include.patch (libfilezilla-cstdin-include.patch,2.15 KB, patch)
2023-02-12 20:23 UTC, Ninpo
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ninpo 2023-02-12 01:39:23 UTC
Created attachment 850412 [details]
libfilezilla build.log

https://svn.filezilla-project.org/filezilla/libfilezilla/trunk/lib/buffer.cpp?view=markup

Missing #include <cstdint> causes build failure with gcc 13. Build log attached.
Comment 1 Yixun Lan archtester gentoo-dev 2023-02-12 09:24:31 UTC
couple things I can think of
1) does that adding "#include <cstdint>" will fix the problem? or in other words, is there any other problem with gcc-13?
2) we need to report this to upstream
3) gcc-13 is un-keyworded, so probably we can wait response from upstream before pushing the patch
Comment 2 Ninpo 2023-02-12 19:39:53 UTC
Created attachment 850556 [details, diff]
libfilezilla-cstdin-include.patch

The attached patch allows libfilezilla-0.39.1-r1 to build with gcc-13 and tests pass.

>>> dev-libs/libfilezilla-0.39.1-r1 merged.
Comment 3 Ninpo 2023-02-12 19:49:40 UTC
Created attachment 850558 [details, diff]
libfilezilla-0.39.1-r1-cstdin-include.patch

Superfluous patch of buffer.cpp removed.
Comment 4 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-02-12 19:57:59 UTC
Thanks, I've attached that applied to svn trunk at https://trac.filezilla-project.org/ticket/12868.
Comment 5 Ninpo 2023-02-12 20:23:51 UTC
Created attachment 850562 [details, diff]
libfilezilla-0.41.0-cstdin-include.patch

0.41.0 also requires a patch to string.hpp (fixed in trunk, including here for completeness)
Comment 6 Larry the Git Cow gentoo-dev 2023-02-16 09:22:50 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=45fb8f807e5908e2bbc73d3d038bd77c825256ea

commit 45fb8f807e5908e2bbc73d3d038bd77c825256ea
Author:     Yixun Lan <dlan@gentoo.org>
AuthorDate: 2023-02-16 09:17:13 +0000
Commit:     Yixun Lan <dlan@gentoo.org>
CommitDate: 2023-02-16 09:22:33 +0000

    dev-libs/libfilezilla: fix build failure with gcc-13
    
    patch only apply to version 0.41.0
    
    Upstream: https://trac.filezilla-project.org/ticket/12868
    Closes: https://bugs.gentoo.org/893982
    Signed-off-by: Yixun Lan <dlan@gentoo.org>

 .../files/libfilezilla-0.41.0-gcc13.patch          | 79 ++++++++++++++++++++++
 dev-libs/libfilezilla/libfilezilla-0.41.0.ebuild   |  5 +-
 2 files changed, 83 insertions(+), 1 deletion(-)