Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 891643 - www-client/firefox: fails to compile with GCC 13
Summary: www-client/firefox: fails to compile with GCC 13
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Mozilla Gentoo Team
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks: gcc-13
  Show dependency tree
 
Reported: 2023-01-22 02:37 UTC by Sam James
Modified: 2023-04-13 22:32 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log.xz (build.log.xz,227.54 KB, application/x-xz)
2023-01-22 02:37 UTC, Sam James
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-01-22 02:37:03 UTC
Created attachment 848943 [details]
build.log.xz

I'll handle this (as we discussed on IRC) but filing for completeness.

```
 0:29.52 In file included from /var/tmp/portage/www-client/firefox-109.0/work/firefox-109.0/dom/canvas/DrawTargetWebgl.cpp:7:
 0:29.52 In file included from /var/tmp/portage/www-client/firefox-109.0/work/firefox-109.0/dom/canvas/DrawTargetWebglInternal.h:10:
 0:29.52 In file included from /var/tmp/portage/www-client/firefox-109.0/work/firefox-109.0/dom/canvas/DrawTargetWebgl.h:10:
 0:29.52 In file included from /var/tmp/portage/www-client/firefox-109.0/work/firefox_build/dist/include/mozilla/gfx/2D.h:12:
 0:29.52 /var/tmp/portage/www-client/firefox-109.0/work/firefox_build/dist/include/mozilla/gfx/Rect.h:327:47: error: no member named 'int32_t' in namespace 'std'
 0:29.52   float min = (float)std::numeric_limits<std::int32_t>::min();
 0:29.53                                          ~~~~~^
 0:29.53 /var/tmp/portage/www-client/firefox-109.0/work/firefox_build/dist/include/mozilla/gfx/Rect.h:328:47: error: no member named 'int32_t' in namespace 'std'
 0:29.54   float max = (float)std::numeric_limits<std::int32_t>::max();
 0:29.54                                          ~~~~~^
 0:29.54 2 errors generated.
 0:29.55 gmake[4]: *** [/var/tmp/portage/www-client/firefox-109.0/work/firefox-109.0/config/rules.mk:669: DrawTargetWebgl.o] Error 1
 0:29.55 gmake[4]: Leaving directory '/var/tmp/portage/www-client/firefox-109.0/work/firefox_build/dom/canvas'
 0:29.55 gmake[3]: *** [/var/tmp/portage/www-client/firefox-109.0/work/firefox-109.0/config/recurse.mk:72: dom/canvas/target-objects] Error 2
 0:29.55 gmake[3]: *** Waiting for unfinished jobs....
```

----

Portage 3.0.44 (python 3.11.1-final-0, default/linux/amd64/17.1/hardened, gcc-13, glibc-2.36-r7, 5.15.89-gentoo-dist-hardened x86_64)
=================================================================
System uname: Linux-5.15.89-gentoo-dist-hardened-x86_64-AMD_Ryzen_9_3950X_16-Core_Processor-with-glibc2.36
KiB Mem:    65763884 total,  14328528 free
KiB Swap:    8290300 total,   8066300 free
Timestamp of repository gentoo: Sat, 21 Jan 2023 22:02:20 +0000
Head commit of repository gentoo: b73abe218efed0606f98340ab74e299041fa1777

Timestamp of repository emacs: Tue, 03 Jan 2023 09:03:30 +0000
Head commit of repository emacs: 44cd1dcebb0e68efc58d2332dd967922368dc6db

Timestamp of repository kde: Fri, 20 Jan 2023 14:32:01 +0000
Head commit of repository kde: b6e83198433580c6b41bb2068ec4370feb506b10

Timestamp of repository qt: Mon, 16 Jan 2023 21:17:16 +0000
Head commit of repository qt: e06df1df9866ac9c391858544661d1fae22de2f2

Timestamp of repository sam_c: Fri, 20 Jan 2023 23:17:03 +0000
Head commit of repository sam_c: f36a91a06a6ea9c9d7168bf56ed19b2291937401

Timestamp of repository steam-overlay: Sat, 21 Jan 2023 15:01:56 +0000
Head commit of repository steam-overlay: 681d17f8ed5b7d981b5f1509bdc6f9d74816fe9e

sh bash 5.2_p15-r1
ld GNU ld (Gentoo 2.40 p1) 2.40
ccache version 4.7.4 [disabled]
app-misc/pax-utils:        1.3.6-r1::gentoo
app-shells/bash:           5.2_p15-r1::gentoo
dev-java/java-config:      2.3.1::gentoo
dev-lang/perl:             5.36.0-r2::gentoo
dev-lang/python:           3.9.16::gentoo, 3.10.9::gentoo, 3.11.1::gentoo, 3.12.0_alpha4::gentoo
dev-lang/rust:             1.66.1::gentoo
dev-util/ccache:           4.7.4::gentoo
dev-util/cmake:            3.25.2::gentoo
dev-util/meson:            1.0.0::gentoo
sys-apps/baselayout:       2.9::gentoo
sys-apps/sandbox:          2.30-r1::gentoo
sys-apps/systemd:          252.4-r1::gentoo
sys-devel/autoconf:        2.13-r7::gentoo, 2.71-r5::gentoo
sys-devel/automake:        1.16.5::gentoo
sys-devel/binutils:        2.40::gentoo
sys-devel/binutils-config: 5.5::gentoo
sys-devel/clang:           15.0.7-r1::gentoo, 16.0.0_pre20230107::gentoo
sys-devel/gcc:             10.4.1_p20230119::gentoo, 11.3.1_p20230113::gentoo, 12.2.1_p20230114::gentoo, 13.0.0_pre20230115::gentoo
sys-devel/gcc-config:      2.10::gentoo
sys-devel/libtool:         2.4.7-r1::gentoo
sys-devel/lld:             15.0.7::gentoo, 16.0.0_pre20230107::gentoo
sys-devel/llvm:            14.0.6-r2::gentoo, 15.0.7::gentoo, 16.0.0_pre20230107::gentoo
sys-devel/make:            4.4.0.90::gentoo
sys-kernel/linux-headers:  6.1::gentoo (virtual/os-headers)
sys-libs/glibc:            2.36-r7::gentoo
Repositories:

gentoo
    location: /var/db/repos/gentoo
    sync-type: git
    sync-uri: https://github.com/gentoo-mirror/gentoo.git
    priority: -1000
    eclass-overrides: sam_c
    volatile: True
    sync-git-verify-commit-signature: yes
    sync-git-clone-extra-opts: -b stable -c gc.reflogExpire=0 -c gc.reflogExpireUnreachable=0 -c gc.rerereresolved=0 -c gc.rerereunresolved=0 -c gc.pruneExpire=now

crossdev
    location: /var/db/repos/crossdev
    masters: gentoo
    eclass-overrides: sam_c
    volatile: True

emacs
    location: /var/db/repos/emacs
    sync-type: git
    sync-uri: https://github.com/gentoo-mirror/emacs.git
    masters: gentoo
    eclass-overrides: sam_c
    volatile: True

kde
    location: /var/db/repos/kde
    sync-type: git
    sync-uri: https://github.com/gentoo-mirror/kde.git
    masters: gentoo
    eclass-overrides: sam_c
    volatile: True

local
    location: /var/db/repos/local
    masters: gentoo
    eclass-overrides: sam_c
    volatile: True

qt
    location: /var/db/repos/qt
    sync-type: git
    sync-uri: https://github.com/gentoo-mirror/qt.git
    masters: gentoo
    eclass-overrides: sam_c
    volatile: True

sam_c
    location: /var/db/repos/sam_c
    sync-type: git
    sync-uri: https://github.com/gentoo-mirror/sam_c.git
    masters: gentoo
    eclass-overrides: sam_c
    volatile: True

steam-overlay
    location: /var/db/repos/steam-overlay
    sync-type: git
    sync-uri: https://github.com/gentoo-mirror/steam-overlay.git
    masters: gentoo
    eclass-overrides: sam_c
    volatile: True

test
    location: /var/db/repos/test
    masters: gentoo
    eclass-overrides: sam_c
    volatile: True

ACCEPT_KEYWORDS="amd64 ~amd64"
ACCEPT_LICENSE="@FREE"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-O2 -pipe -march=native -fdiagnostics-color=always -frecord-gcc-switches -Wreturn-type"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/config /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/php/apache2-php8.2/ext-active/ /etc/php/cgi-php8.2/ext-active/ /etc/php/cli-php8.2/ext-active/ /etc/php/fpm-php8.2/ext-active/ /etc/php/phpdbg-php8.2/ext-active/ /etc/revdep-rebuild /etc/sandbox.d /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c"
CXXFLAGS="-O2 -pipe -march=native -fdiagnostics-color=always -frecord-gcc-switches -Wreturn-type -D_GLIBCXX_ASSERTIONS"
DISTDIR="/var/cache/distfiles"
EMERGE_DEFAULT_OPTS="--keep-going --with-bdeps=y --complete-graph --deep --dynamic-deps=n --changed-deps=n --usepkg-exclude sys-fs/zfs --usepkg-exclude sys-fs/zfs-kmod --usepkg=y --implicit-system-deps=n --jobs=4 --load-average 32"
ENV_UNSET="CARGO_HOME DBUS_SESSION_BUS_ADDRESS DISPLAY GDK_PIXBUF_MODULE_FILE GOBIN GOPATH PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR XDG_STATE_HOME"
FCFLAGS="-O2 -pipe -march=native -fdiagnostics-color=always -frecord-gcc-switches -Wreturn-type"
FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs buildpkg cgroup clean-logs config-protect-if-modified distlocks fixlafiles ipc-sandbox mount-sandbox multilib-strict network-sandbox news parallel-fetch parallel-install pid-sandbox pkgdir-index-trusted preserve-libs protect-owned qa-unresolved-soname-deps sandbox sfperms split-log strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-O2 -pipe -march=native -fdiagnostics-color=always -frecord-gcc-switches -Wreturn-type"
GENTOO_MIRRORS="http://mirror.bytemark.co.uk/gentoo/ http://www.mirrorservice.org/sites/distfiles.gentoo.org/ http://mirrors.soeasyto.com/distfiles.gentoo.org/"
LANG="en_GB.UTF-8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed -Wl,--defsym=__gentoo_check_ldflags__=0 -Wl,-z,pack-relative-relocs"
LEX="flex"
LINGUAS="en en_GB"
MAKEOPTS="-j32 -l32"
PKGDIR="/var/cache/binpkgs"
PORTAGE_BUNZIP2_COMMAND="lbunzip2"
PORTAGE_COMPRESS="xz"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/var/tmp"
RUSTFLAGS="-C target-cpu=native"
SHELL="/bin/bash"
USE="PIC X a52 aac acl acpi activities aes alsa amd64 avx avx2 bash-completion bluetooth branding bzip2 cairo caps cdda cdr cet clang cli crypt dbus declarative dist-kernel dri dts dvd dvdr emacs encode exif f16c filecaps firewalld flac fma3 fortran freetype gdbm gif gmp gpm graphite gtk gui hardened harfbuzz hunspell iconv icu ipv6 jit jpeg kde kdesu kwallet lcms libglvnd libnotify libtirpc llvm-libunwind lto mad mmx mmxext mng mp3 mp4 mpeg multilib ncurses nftables nls nptl ogg opengl openmp pam pango pclmul pcre pdf pgo pie pipewire plasma png policykit popcnt ppds pulseaudio qml qt5 rdrand readline screencast sdl seccomp semantic-desktop sha sound spell sse sse2 sse3 sse4_1 sse4_2 sse4a ssl ssp ssse3 startup-notification svg system-av1 system-binutils system-boost system-bootstrap system-cairo system-clang system-digest system-ffmpeg system-harfbuzz system-heimdal system-icu system-jpeg system-leveldb system-libevent system-libs system-libvpx system-libyaml system-llvm system-lz4 system-mitkrb5 system-sqlite system-ssl system-tbb system-uulib system-webp system-zlib systemd test-rust tiff truetype udev udisks unicode upower usb verify-sig vorbis vulkan wayland widgets x264 xattr xcb xft xml xtpax xv xvid zfs zlib zsh-completion" ABI_X86="32 64" ADA_TARGET="gnat_2021" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon sheets words" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="aes avx avx2 f16c fma3 mmx mmxext pclmul popcnt rdrand sha sse sse2 sse3 sse4_1 sse4_2 sse4a ssse3" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock greis isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="libinput" KERNEL="linux" L10N="en en-GB" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LLVM_TARGETS="X86 AArch64 AMDGPU ARM AVR BPF Hexagon Lanai MSP430 Mips NVPTX PowerPC RISCV Sparc SystemZ WebAssembly XCore" LUA_SINGLE_TARGET="lua5-1" LUA_TARGETS="lua5-1" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php7-4 php8-0" POSTGRES_TARGETS="postgres12 postgres13" PYTHON_SINGLE_TARGET="python3_11" PYTHON_TARGETS="python3_10 pypy3 python3_11 python3_8 python3_9" QEMU_USER_TARGETS="aarch64 aarch64_be alpha armeb hppa m68k ppc ppc64 ppc64le sparc sparc64" RUBY_TARGETS="ruby31" USERLAND="GNU" VIDEO_CARDS="amdgpu radeonsi radeon" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq proto steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  ADDR2LINE, AR, ARFLAGS, AS, ASFLAGS, CC, CCLD, CONFIG_SHELL, CPP, CPPFLAGS, CTARGET, CXX, CXXFILT, ELFEDIT, EXTRA_ECONF, F77FLAGS, FC, GCOV, GPROF, INSTALL_MASK, LC_ALL, LD, LFLAGS, LIBTOOL, MAKE, MAKEFLAGS, NM, OBJCOPY, OBJDUMP, PORTAGE_BINHOST, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, RANLIB, READELF, SIZE, STRINGS, STRIP, YACC, YFLAGS
Comment 1 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-01-22 03:17:14 UTC
There are further issues with -fpermissive after fixing the trivial include problem:
```
 0:20.11 /var/tmp/portage/www-client/firefox-109.0/work/firefox_build/dist/include/mozilla/ProfilerThreadRegistration.h: At global scope:
 0:20.11 /var/tmp/portage/www-client/firefox-109.0/work/firefox_build/dist/include/mozilla/ProfilerThreadRegistration.h:217:38: error: declaration of 'mozilla::profiler::ThreadRegistration::OnThreadRef::RWOnThreadWithLock mozilla::profiler::ThreadRegistration::OnThreadRef::LockedRWOnThread()' changes meaning of 'LockedRWOnThread' [-fpermissive]
 0:20.11   217 |     [[nodiscard]] RWOnThreadWithLock LockedRWOnThread() {
 0:20.11       |                                      ^~~~~~~~~~~~~~~~
 0:20.11 /var/tmp/portage/www-client/firefox-109.0/work/firefox_build/dist/include/mozilla/ProfilerThreadRegistration.h:213:7: note: used here to mean 'using mozilla::profiler::ThreadRegistration::LockedRWOnThread = class mozilla::profiler::ThreadRegistrationLockedRWOnThread'
 0:20.11   213 |       LockedRWOnThread& mLockedRWOnThread;
 0:20.12       |       ^~~~~~~~~~~~~~~~
 0:20.12 /var/tmp/portage/www-client/firefox-109.0/work/firefox_build/dist/include/mozilla/ProfilerThreadRegistration.h:63:9: note: declared here
 0:20.12    63 |   using LockedRWOnThread = ThreadRegistrationLockedRWOnThread;
 0:20.12       |         ^~~~~~~~~~~~~~~~
 0:20.12 In file included from /var/tmp/portage/www-client/firefox-109.0/work/firefox_build/dist/include/mozilla/ProfilerThreadState.h:15:
 0:20.12 /var/tmp/portage/www-client/firefox-109.0/work/firefox_build/dist/include/mozilla/ProfilerThreadRegistry.h:180:43: error: declaration of 'mozilla::profiler::ThreadRegistry::OffThreadRef::RWFromAnyThreadWithLock mozilla::profiler::ThreadRegistry::OffThreadRef::LockedRWFromAnyThread()' changes meaning of 'LockedRWFromAnyThread' [-fpermissive]
 0:20.12   180 |     [[nodiscard]] RWFromAnyThreadWithLock LockedRWFromAnyThread() {
 0:20.12       |                                           ^~~~~~~~~~~~~~~~~~~~~
 0:20.12 /var/tmp/portage/www-client/firefox-109.0/work/firefox_build/dist/include/mozilla/ProfilerThreadRegistry.h:176:7: note: used here to mean 'using mozilla::profiler::ThreadRegistry::LockedRWFromAnyThread = class mozilla::profiler::ThreadRegistrationLockedRWFromAnyThread'
 0:20.12   176 |       LockedRWFromAnyThread& mLockedRWFromAnyThread;
 0:20.13       |       ^~~~~~~~~~~~~~~~~~~~~
 0:20.13 /var/tmp/portage/www-client/firefox-109.0/work/firefox_build/dist/include/mozilla/ProfilerThreadRegistry.h:33:9: note: declared here
 0:20.13    33 |   using LockedRWFromAnyThread = ThreadRegistrationLockedRWFromAnyThread;
 0:20.13       |         ^~~~~~~~~~~~~~~~~~~~~
 0:20.13 gmake[4]: *** [/var/tmp/portage/www-client/firefox-109.0/work/firefox-109.0/config/rules.mk:669: Unified_cpp_ipc_extension_other0.o] Error 1
```

mliska reported them already upstream at https://bugzilla.mozilla.org/show_bug.cgi?id=1807652.
Comment 2 Larry the Git Cow gentoo-dev 2023-01-24 10:01:33 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d361fad3aa2fb3229d5ec972268ec52da37f5abc

commit d361fad3aa2fb3229d5ec972268ec52da37f5abc
Author:     Joonas Niilola <juippis@gentoo.org>
AuthorDate: 2023-01-24 09:51:51 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2023-01-24 10:01:30 +0000

    www-client/firefox: update patchset for 109.0
    
     - include gcc-13 fixes,
     - include updated webrtc patch on ppc64.
    
    Closes: https://bugs.gentoo.org/891643
    Bug: https://bugs.gentoo.org/891389
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 www-client/firefox/Manifest             | 2 +-
 www-client/firefox/firefox-109.0.ebuild | 8 +-------
 2 files changed, 2 insertions(+), 8 deletions(-)