Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 891487 - net-p2p/transmission-3* apply debian patch to use ayatana indicators
Summary: net-p2p/transmission-3* apply debian patch to use ayatana indicators
Status: CONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Mike Gilbert
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 887171
  Show dependency tree
 
Reported: 2023-01-20 14:38 UTC by Pacho Ramos
Modified: 2023-03-11 18:04 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Pacho Ramos gentoo-dev 2023-01-20 14:38:14 UTC
dev-libs/libayatana-appindicator and dev-libs/libayatana-indicator are the only appindicators implementation that are still maintained and developped, while libappindicator are unmaintained for ages.

OpenSUSE already migrated and Debian is ongoing. This patch can be applied to transmission-3 for the migration:
https://salsa.debian.org/debian/transmission/-/blob/master/debian/patches/ayatana-indicators.patch

For transmission-4 it's only a matter of updating the dep to dev-libs/libayatana-indicator and it will pick the new one (since beta2 version)
https://github.com/transmission/transmission/pull/4001

Thanks
Comment 1 Mike Gilbert gentoo-dev 2023-01-20 16:16:01 UTC
Sounds good, thanks for the background info.

I'll update it shortly.
Comment 2 Mike Gilbert gentoo-dev 2023-01-20 19:31:48 UTC
The Debian patch wont work for us; it patches configure.ac, but not the cmake build files.
Comment 3 Mike Gilbert gentoo-dev 2023-01-20 19:41:58 UTC
An oddity: dev-libs/libayatana-appindicator-0.5.91 installs libayatana-appindicator3, but has SLOT=0. Is that correct? Seems like a mistake to me.
Comment 4 Larry the Git Cow gentoo-dev 2023-01-20 19:45:09 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2e9e62c5ae19c8565310c4d652647efe6084e332

commit 2e9e62c5ae19c8565310c4d652647efe6084e332
Author:     Mike Gilbert <floppym@gentoo.org>
AuthorDate: 2023-01-20 19:43:15 +0000
Commit:     Mike Gilbert <floppym@gentoo.org>
CommitDate: 2023-01-20 19:43:52 +0000

    net-p2p/transmission: update appindicator dep
    
    Bug: https://bugs.gentoo.org/891487
    Signed-off-by: Mike Gilbert <floppym@gentoo.org>

 net-p2p/transmission/transmission-4.0.0_beta3.ebuild | 4 ++--
 net-p2p/transmission/transmission-9999.ebuild        | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)
Comment 5 Pacho Ramos gentoo-dev 2023-01-22 12:16:35 UTC
Thanks for the fast action... I replied to one question you made in https://bugs.gentoo.org/887171#c2 (I see you are not in the CC list there... then.. to ensure you get the reply)

(In reply to Mike Gilbert from comment #3)
> An oddity: dev-libs/libayatana-appindicator-0.5.91 installs
> libayatana-appindicator3, but has SLOT=0. Is that correct? Seems like a
> mistake to me.

Well... no gtk2 support will be added... and for gtk4 the situation is pretty obscure currently (https://github.com/AyatanaIndicators/libayatana-appindicator/issues/22) and I cannot predict what will happen to it (or if it will be implemented by another project or...) :/  Then I simply planned to act when the support finally is added... somewhere (if ever, I hope)
Comment 6 Pacho Ramos gentoo-dev 2023-01-22 12:25:18 UTC
And, also (and specially), because it is hard to predict now if, in the future, there will be a dev-libs/libayatana-appindicator4 additional package or a dev-libs/libayatana-appindicator with two slots and those -r300 vs -r400 revisions that we need to use on those cases