Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 890933 - app-xemacs/ebuild-mode-1.61 stable request
Summary: app-xemacs/ebuild-mode-1.61 stable request
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Stabilization (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: XEmacs team
URL:
Whiteboard:
Keywords: ALLARCHES, STABLEREQ
Depends on:
Blocks:
 
Reported: 2023-01-15 11:54 UTC by Ulrich Müller
Modified: 2023-02-27 21:55 UTC (History)
0 users

See Also:
Package list:
app-xemacs/ebuild-mode-1.61
Runtime testing required: Manual
nattka: sanity-check+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ulrich Müller gentoo-dev 2023-01-15 11:54:27 UTC
Changes since previous stable version 1.60:

2022-12-01  Ulrich Müller  <ulm@gentoo.org>

	* Version 1.61 released.

	* ebuild-mode-keywords.el (ebuild-mode-keywords-eclass):
	Regenerated.

	* ebuild-mode.el: Add documentation to some functions and
	variables.
	(ebuild-compilation-mode): Reword docstring to avoid an open paren
	at the beginning of a line, which confuses some Emacs versions.

	* ebuild-mode.el (ebuild-mode-restrict-list): Update.

2022-11-30  Ulrich Müller  <ulm@gentoo.org>

	* ebuild-mode.texi (ebuild-mode): Document ebuild-mode-run-pkgdev
	and ebuild-mode-run-pkgcheck.

	* ebuild-mode.el (ebuild-compilation-mode): New mode for
	compilation buffers, filters SGR control sequences.
	(ebuild-log-buffer-mode): Default to it.
	(ebuild-mode-run-pkgdev, ebuild-mode-run-pkgcheck): Call compile
	with ebuild-log-buffer-mode.
	(ebuild-mode-process-environment): Don't set NOCOLOR if ansi-color
	is available.

2022-11-28  Ulrich Müller  <ulm@gentoo.org>

	* ebuild-mode.el (ebuild-mode-ebuild-history)
	(ebuild-mode-pkgdev-history, ebuild-mode-pkgcheck-history):
	New variables.
	(ebuild-run-command, ebuild-mode-run-pkgdev)
	(ebuild-mode-run-pkgcheck): Use them.

	* ebuild-mode.el (ebuild-mode-process-environment): New custom
	variable. Bug 882055.
	(ebuild-run-command, ebuild-mode-run-pkgdev)
	(ebuild-mode-run-pkgcheck): Use it.

	* ebuild-mode.el (ebuild-mode-ebuild-cmd-complete): New function,
	completes multiple ebuild commands. Bug 882053.
	(ebuild-run-command): Call it.
	(ebuild-mode-menu): Add ebuild-run-command without argument.

2022-11-19  Ulrich Müller  <ulm@gentoo.org>

	* ebuild-mode.el (ebuild-mode-run-pkgdev)
	(ebuild-mode-run-pkgcheck): New commands. Bug 881449.
	(ebuild-mode-map, ebuild-mode-menu): Keybindings and menu entries
	for them.
	(ebuild-mode-pkgdev-commands, ebuild-mode-pkgcheck-commands):
	New variables.
	(ebuild-mode-get-completion-function): New function, split off
	from ebuild-mode-ekeyword-complete.
	(ebuild-mode-ekeyword-complete): Call it.
	(ebuild-mode-command-complete): New function.

2022-11-18  Ulrich Müller  <ulm@gentoo.org>

	* ebuild-mode.el (ebuild-repo-mode): Fix byte-compile warning
	in XEmacs.

	* ebuild-mode.el (ebuild-mode-collect-and-split): Renamed from
	ebuild-mode-collect-equal-cdrs. Split the car of an element if its
	length is above the limit.
	(ebuild-mode-font-lock-keywords): Split the list of eclass
	keywords here, rather than in keyword-generation.sh.
	* keyword-generation.sh: Don't split the list into parts.
	* ebuild-mode-keywords.el (ebuild-mode-keywords-eclass): Updated.

2022-07-31  Ulrich Müller  <ulm@gentoo.org>

	* ebuild-mode.el (ebuild-mode-insert-skeleton): Drop unnecessary
	backslash escapes.

	* ebuild-mode.el (ebuild-repo-mode): Set nxml-attribute-indent.

2022-06-05  Ulrich Müller  <ulm@gentoo.org>

	* ebuild-mode.el (ebuild-repo-mode): Indent XML with tabs or two
	spaces. Set indent-tabs-mode accordingly.
	(ebuild-mode-xml-indent-tabs): New custom variable.

2022-06-03  Ulrich Müller  <ulm@gentoo.org>

	* ebuild-mode.el (ebuild-mode-arch-list): Add loong to default.

	* ebuild-mode.el (ebuild-mode-modify-keywords): Use cons rather
	than append when adding a new keyword.

Test plan: <https://wiki.gentoo.org/wiki/Project:Emacs/Test_plans#app-emacs.2Febuild-mode>

Thanks in advance.
Comment 1 Ulrich Müller gentoo-dev 2023-02-20 17:45:55 UTC
ping
Comment 2 Mats Lidell gentoo-dev 2023-02-20 22:22:57 UTC
(In reply to Ulrich Müller from comment #1)
> ping

Sorry for not acting on this but not sure I should either. Please advice.

Anyway, going through the tests I noticed there is a bug in ebuild-mode due to the XEmacs function format-time-string only taking two args and not supporting the %F format character. This affects two test cases. Saving of an ebuild and creating a new. 

After adjusting ebuild-mode.el for this the test cases pass. 

I think you have commented on the incompatibilities between Emacs and XEmacs before so not sure how you want to go about this here. The problem still remains with the current upstream master branch so bumping to latest XEmacs 21.5 will not help here right now.
Comment 3 Ulrich Müller gentoo-dev 2023-02-21 08:32:05 UTC
These incompatibilities show up in the most unexpected places.
I'm going to fix it and make a new release.
Comment 4 Larry the Git Cow gentoo-dev 2023-02-21 17:15:56 UTC Comment hidden (obsolete)
Comment 5 Larry the Git Cow gentoo-dev 2023-02-21 19:00:15 UTC Comment hidden (obsolete)
Comment 6 Larry the Git Cow gentoo-dev 2023-02-21 19:12:47 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/ebuild-mode.git/commit/?id=2bfe87a7afe45b48268e97d4dd7c9e0edd49e426

commit 2bfe87a7afe45b48268e97d4dd7c9e0edd49e426
Author:     Ulrich Müller <ulm@gentoo.org>
AuthorDate: 2023-02-21 17:05:01 +0000
Commit:     Ulrich Müller <ulm@gentoo.org>
CommitDate: 2023-02-21 19:09:54 +0000

    New compatibility function for format-time-string in XEmacs
    
    * ebuild-mode.el (ebuild-mode-time-string): New compatibility
    function for format-time-string, where XEmacs doesn't support the
    time zone argument. Bug 890933.
    (ebuild-mode-update-copyright, ebuild-mode-insert-skeleton)
    (ebuild-mode-insert-tag-line): Call it.
    (ebuild-mode-update-copyright): Save match data, because setenv
    clobbers it.
    
    Bug: https://bugs.gentoo.org/890933#c2
    Signed-off-by: Ulrich Müller <ulm@gentoo.org>

 ChangeLog      | 10 ++++++++++
 ebuild-mode.el | 23 ++++++++++++++++++++---
 2 files changed, 30 insertions(+), 3 deletions(-)
Comment 7 Ulrich Müller gentoo-dev 2023-02-26 21:48:45 UTC
(In reply to Mats Lidell from comment #2)

Can you test app-xemacs/ebuild-mode-9999 (from emacs overlay)? As far as I can see, it should work with both XEmacs 21.4 and 21.5.
Comment 8 Mats Lidell gentoo-dev 2023-02-27 21:55:04 UTC
(In reply to Ulrich Müller from comment #7)
> (In reply to Mats Lidell from comment #2)
> 
> Can you test app-xemacs/ebuild-mode-9999 (from emacs overlay)? As far as I
> can see, it should work with both XEmacs 21.4 and 21.5.

Yes. It works with both. Thanks for fixing this.