Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 881449 - app-emacs/ebuild-mode: Support pkgdev and pkgcheck commands
Summary: app-emacs/ebuild-mode: Support pkgdev and pkgcheck commands
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Emacs project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-11-16 04:05 UTC by Ulrich Müller
Modified: 2022-12-01 18:36 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ulrich Müller gentoo-dev 2022-11-16 04:05:17 UTC
Add support for pkgdev and pkgcheck, similar to ebuild-run-command.
Comment 1 Pascal Jäger 2022-11-19 13:13:53 UTC
I have not tried, but maybe we could just use "shell-command" with the path of the current buffer or the current file respectively?

Maybe this should just be a wiki entry instead of adding that into ebuild-mode?
Comment 2 Ulrich Müller gentoo-dev 2022-11-19 14:16:51 UTC
Here is what I have so far. It's not very complicated.
https://gitweb.gentoo.org/proj/ebuild-mode.git/commit/?h=pkgdev

(Currently waiting for NOCOLOR=true support in pkgdev.)
Comment 3 Pascal Jäger 2022-11-20 17:12:24 UTC
Hm this bears a problem. 
For example when pushing to the GURU I have to use pkgdev push -A because pkgdev is checking all the commits since the last merge from dev branch into master. If there are any QA issues (and there usually are) pkgdev refuses to push without -A flag.
Can we have the possibility to add arguments to those commands? I don’t know how much work it is but magit does that splendidly.

We also need pkgdev commit -s -S all the time, but I think this could be solved by putting that into the config of pkgdev.
Comment 4 Ulrich Müller gentoo-dev 2022-11-21 08:08:00 UTC
(In reply to Pascal Jäger from comment #3)

I don't understand. What prevents you from simply typing these arguments in the minibuffer?
Comment 5 Pascal Jäger 2022-11-21 09:39:22 UTC
Lol I didn’t now I can do that. I thought I can only choose from the list…
Comment 6 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-11-22 22:41:27 UTC
(In reply to Ulrich Müller from comment #2)
> Here is what I have so far. It's not very complicated.
> https://gitweb.gentoo.org/proj/ebuild-mode.git/commit/?h=pkgdev
> 
> (Currently waiting for NOCOLOR=true support in pkgdev.)

Landed in master: https://github.com/pkgcore/pkgdev/commit/9714e4785e1ffc56a08f042011b5a966c7520a1f.
Comment 7 Larry the Git Cow gentoo-dev 2022-11-28 18:20:43 UTC Comment hidden (obsolete)
Comment 8 Larry the Git Cow gentoo-dev 2022-11-29 19:40:19 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/ebuild-mode.git/commit/?id=349a9450cb1fd4d2404fb48ade3192cc10899a1d

commit 349a9450cb1fd4d2404fb48ade3192cc10899a1d
Author:     Ulrich Müller <ulm@gentoo.org>
AuthorDate: 2022-11-19 14:13:19 +0000
Commit:     Ulrich Müller <ulm@gentoo.org>
CommitDate: 2022-11-29 19:30:17 +0000

    Support pkgdev and pkgcheck
    
    * ebuild-mode.el (ebuild-mode-run-pkgdev)
    (ebuild-mode-run-pkgcheck): New commands. Bug 881449.
    (ebuild-mode-map, ebuild-mode-menu): Keybindings and menu entries
    for them.
    (ebuild-mode-pkgdev-commands, ebuild-mode-pkgcheck-commands):
    New variables.
    (ebuild-mode-get-completion-function): New function, split off
    from ebuild-mode-ekeyword-complete.
    (ebuild-mode-ekeyword-complete): Call it.
    (ebuild-mode-command-complete): New function.
    
    Bug: https://bugs.gentoo.org/881449
    Signed-off-by: Ulrich Müller <ulm@gentoo.org>

 ChangeLog      | 13 ++++++++++
 ebuild-mode.el | 80 +++++++++++++++++++++++++++++++++++++++++++++++++++-------
 2 files changed, 84 insertions(+), 9 deletions(-)
Comment 9 Larry the Git Cow gentoo-dev 2022-12-01 18:36:59 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=fb1896c3847ea94c478b92d1195fda6e3b266a0c

commit fb1896c3847ea94c478b92d1195fda6e3b266a0c
Author:     Ulrich Müller <ulm@gentoo.org>
AuthorDate: 2022-12-01 18:33:48 +0000
Commit:     Ulrich Müller <ulm@gentoo.org>
CommitDate: 2022-12-01 18:36:41 +0000

    app-emacs/ebuild-mode: add 1.61
    
    Closes: https://bugs.gentoo.org/881449
    Closes: https://bugs.gentoo.org/882053
    Closes: https://bugs.gentoo.org/882055
    Signed-off-by: Ulrich Müller <ulm@gentoo.org>

 app-emacs/ebuild-mode/Manifest                |  1 +
 app-emacs/ebuild-mode/ebuild-mode-1.61.ebuild | 22 ++++++++++++++++++++++
 2 files changed, 23 insertions(+)