LICENSE="GPL-3" README: LICENSE ======= This program is free software: you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation, either version 3 of the License, or (at your option) any later version. This program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details. You should have received a copy of the GNU General Public License along with this program (file LICENSE). If not, see http://www.gnu.org/licenses/. In addition, as a special exception, the copyright holders give permission to link the code of portions of this program with the OpenSSL library under certain conditions as described in each individual source file, and distribute linked combinations including the two. You must obey the GNU General Public License in all respects for all of the code used other than OpenSSL. If you modify file(s) with this exception, you may extend this exception to your version of the file(s), but you are not obligated to do so. If you do not wish to do so, delete this exception statement from your version. If you delete this exception statement from all source files in the program, then also delete it here. Should be: LICENSE="GPL-3+-with-openssl-exception" (I see GPL-3-with-openssl-exception in the tree, but it seems that the or-later version needs to be added)
I'm looking at taking this on as a proxy maintainer. The LICENSE and EAPI are easily addressed (I have done so in a local copy): --- gnubiff-2.2.17-r2.ebuild 2024-04-30 14:41:32.000000000 -0400 +++ gnubiff-2.2.17-r3.ebuild 2024-06-03 12:28:00.134650568 -0400 @@ -1,16 +1,16 @@ # Copyright 1999-2024 Gentoo Authors # Distributed under the terms of the GNU General Public License v2 -EAPI=6 +EAPI=8 inherit autotools DESCRIPTION="A mail notification program" HOMEPAGE="http://gnubiff.sourceforge.net/" SRC_URI="https://downloads.sourceforge.net/${PN}/${P}.tar.gz" -LICENSE="GPL-3" +LICENSE="GPL-3+-with-openssl-exception" SLOT="0" KEYWORDS="amd64 x86" IUSE="debug fam nls password" RDEPEND=" I will likely need some help reproducing https://bugs.gentoo.org/930500 as clang is not even used in building net-mail/gnubiff on any of my systems. It looks as though the issue may be CC/CXX arguments being incorrectly passed to clang.
I have a clang-only system and can replicate. Clang doesn't understand the option but continues anyway (with a warning). You can just drop -export-dynamic from src/Makefile.am to fix https://bugs.gentoo.org/930500. It doesn't do anything there: Its a linker option in the compile-only phase and is ignored by gcc (clang warns you it has no effect). What the author probably MEANT was: gnubiff_LDFLAGS = -Wl,--export-dynamic in src/Makefile.am, but adding it doesn't make any difference, the program complains about missing -rdynamic at runtime either way, with or without the patch, and with both gcc and clang Also the ebuild is broken in one subtle way: epatch_apply is called AFTER eautoreconf, so user matches to the autoconf machinery have no effect.
(In reply to Christopher Byrne from comment #2) > I have a clang-only system and can replicate. Clang doesn't understand the > option but continues anyway (with a warning). > > You can just drop -export-dynamic from src/Makefile.am to fix > https://bugs.gentoo.org/930500. It doesn't do anything there: Its a linker > option in the compile-only phase and is ignored by gcc (clang warns you it > has no effect). What the author probably MEANT was: > > gnubiff_LDFLAGS = -Wl,--export-dynamic > > in src/Makefile.am, but adding it doesn't make any difference, the program > complains about missing -rdynamic at runtime either way, with or without the > patch, and with both gcc and clang Thank you! > Also the ebuild is broken in one subtle way: epatch_apply is called AFTER > eautoreconf, so user matches to the autoconf machinery have no effect. Good catch. I can easily fix that.
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a0b6e2a772ca60c1af8c6b49972a13e16b42eb25 commit a0b6e2a772ca60c1af8c6b49972a13e16b42eb25 Author: Phil Stracchino <phils@caerllewys.net> AuthorDate: 2024-07-10 19:26:06 +0000 Commit: Arthur Zamarin <arthurzam@gentoo.org> CommitDate: 2024-07-12 14:24:18 +0000 net-mail/gnubiff: add 2.2.17-r3 - adds a new LICENSE GPL-3+-with-openssl-exception - cleans up all old 2.2.15 patches - fixes compilation errors on clang-only systems by removing '-export-dynamic' from Makefile Closes: https://bugs.gentoo.org/880267 Closes: https://bugs.gentoo.org/930500 Closes: https://bugs.gentoo.org/933241 Signed-off-by: Phil Stracchino <phils@caerllewys.net> Closes: https://github.com/gentoo/gentoo/pull/37513 Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org> licenses/GPL-3+-with-openssl-exception | 16 ++++++ net-mail/gnubiff/files/gnubiff-2.2.15-gold.patch | 17 ------- .../gnubiff/files/gnubiff-2.2.15-underlink.patch | 12 ----- net-mail/gnubiff/files/gnubiff-2.2.17-clang.patch | 15 ++++++ .../gnubiff/files/gnubiff-2.2.17-configure.patch | 18 +++++++ ...-fix-nls.patch => gnubiff-2.2.17-fix-nls.patch} | 8 +-- net-mail/gnubiff/gnubiff-2.2.17-r3.ebuild | 57 ++++++++++++++++++++++ profiles/license_groups | 2 +- 8 files changed, 112 insertions(+), 33 deletions(-)
