Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 877049 - dev-libs/libstrophe: bashisms in configure
Summary: dev-libs/libstrophe: bashisms in configure
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Adrian Schollmeyer
URL: https://github.com/strophe/libstrophe...
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks: nonbash
  Show dependency tree
 
Reported: 2022-10-13 22:59 UTC by Sam James
Modified: 2023-05-02 22:53 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (file_877049.txt,7.80 KB, text/plain)
2022-10-13 22:59 UTC, Sam James
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-10-13 22:59:19 UTC
When building libstrophe with /bin/sh -> /bin/dash, I saw:
```
checking for snprintf... yes
checking for vsnprintf... yes
checking for va_copy... yes
./configure: 14622: test: xno: unexpected operator
./configure: 14716: test: x: unexpected operator
checking for openssl... yes
checking for getrandom... yes
checking for libxml2... yes
```

Indeed, those lines contian bashisms:
>if test "x$enable_tls" != xno -a "x$with_gnutls" == xyes; then
and
>elif test "x$enable_tls" != xno -a "x$with_schannel" == xyes; then
Comment 1 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-10-13 22:59:49 UTC
Created attachment 824001 [details]
build.log
Comment 2 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-10-13 23:00:13 UTC
Portage 3.0.38.1 (python 3.11.0-candidate-2, default/linux/amd64/17.1/hardened, gcc-12, glibc-2.36-r4, 5.15.73-gentoo-dist-hardened x86_64)
=================================================================
System uname: Linux-5.15.73-gentoo-dist-hardened-x86_64-AMD_Ryzen_9_3950X_16-Core_Processor-with-glibc2.36
KiB Mem:    65765036 total,  23165636 free
KiB Swap:    8290300 total,   7352828 free
Timestamp of repository gentoo: Thu, 13 Oct 2022 22:18:37 +0000
Head commit of repository gentoo: 6e203819cb62e5a70990648a434d1844552c294f

Timestamp of repository emacs: Mon, 10 Oct 2022 21:05:01 +0000
Head commit of repository emacs: 5dda10baa9a76f2f3663bc2f924d2adfc7ddfdf7

Timestamp of repository kde: Thu, 13 Oct 2022 20:04:06 +0000
Head commit of repository kde: 54753172ed29889196d193e05c4db1b63a78004f

Timestamp of repository qt: Tue, 11 Oct 2022 16:48:56 +0000
Head commit of repository qt: 002c4cd178a2b83ee2f71a159ee1eed733ee817e

Timestamp of repository sam_c: Thu, 13 Oct 2022 22:18:30 +0000
Head commit of repository sam_c: 8879f473ca7e365a927530705b90679acb5d2055

Timestamp of repository steam-overlay: Mon, 10 Oct 2022 21:05:11 +0000
Head commit of repository steam-overlay: a820d86debea867cb1c40fa3e17c534b8788410b

sh dash 0.5.11.5
ld GNU ld (Gentoo 2.39 p5) 2.39.0
ccache version 4.6.3 [disabled]
app-misc/pax-utils:        1.3.5::gentoo
app-shells/bash:           5.2_p2-r2::gentoo
dev-java/java-config:      2.3.1::gentoo
dev-lang/perl:             5.36.0::gentoo
dev-lang/python:           2.7.18_p15-r1::gentoo, 3.8.15::gentoo, 3.9.15::gentoo, 3.10.8::gentoo, 3.11.0_rc2_p1::gentoo
dev-lang/rust:             1.64.0-r1::gentoo
dev-util/ccache:           4.6.3::gentoo
dev-util/cmake:            3.24.2::gentoo
dev-util/meson:            0.63.2-r1::gentoo
sys-apps/baselayout:       2.9::gentoo
sys-apps/sandbox:          2.29::gentoo
sys-apps/systemd:          251.5::gentoo
sys-devel/autoconf:        2.13-r3::gentoo, 2.71-r4::gentoo
sys-devel/automake:        1.16.5::gentoo
sys-devel/binutils:        2.39-r3::gentoo
sys-devel/binutils-config: 5.4.1::gentoo
sys-devel/clang:           14.0.6-r1::gentoo, 15.0.2::gentoo, 16.0.0_pre20221010::gentoo
sys-devel/gcc:             9.5.0::gentoo, 10.4.1_p20221006::gentoo, 11.3.1_p20221007::gentoo, 12.2.1_p20221008::gentoo, 13.0.0_pre20221002::gentoo
sys-devel/gcc-config:      2.8::gentoo
sys-devel/libtool:         2.4.7::gentoo
sys-devel/lld:             14.0.6::gentoo
sys-devel/llvm:            14.0.6-r2::gentoo, 15.0.2::gentoo, 16.0.0_pre20221010::gentoo
sys-devel/make:            9999::gentoo
sys-kernel/linux-headers:  6.0::gentoo (virtual/os-headers)
sys-libs/glibc:            2.36-r4::gentoo
Repositories:

gentoo
    location: /var/db/repos/gentoo
    sync-type: git
    sync-uri: https://github.com/gentoo-mirror/gentoo.git
    priority: -1000
    eclass-overrides: sam_c
    sync-git-clone-extra-opts: -b stable -c gc.reflogExpire=0 -c gc.reflogExpireUnreachable=0 -c gc.rerereresolved=0 -c gc.rerereunresolved=0 -c gc.pruneExpire=now
    sync-git-verify-commit-signature: yes

crossdev
    location: /var/db/repos/crossdev
    masters: gentoo
    eclass-overrides: sam_c

emacs
    location: /var/db/repos/emacs
    sync-type: git
    sync-uri: https://github.com/gentoo-mirror/emacs.git
    masters: gentoo
    eclass-overrides: sam_c

kde
    location: /var/db/repos/kde
    sync-type: git
    sync-uri: https://github.com/gentoo-mirror/kde.git
    masters: gentoo
    eclass-overrides: sam_c

local
    location: /var/db/repos/local
    masters: gentoo
    eclass-overrides: sam_c

qt
    location: /var/db/repos/qt
    sync-type: git
    sync-uri: https://github.com/gentoo-mirror/qt.git
    masters: gentoo
    eclass-overrides: sam_c

sam_c
    location: /var/db/repos/sam_c
    sync-type: git
    sync-uri: https://github.com/gentoo-mirror/sam_c.git
    masters: gentoo
    eclass-overrides: sam_c

steam-overlay
    location: /var/db/repos/steam-overlay
    sync-type: git
    sync-uri: https://github.com/gentoo-mirror/steam-overlay.git
    masters: gentoo
    eclass-overrides: sam_c

test
    location: /var/db/repos/test
    masters: gentoo
    eclass-overrides: sam_c

ACCEPT_KEYWORDS="amd64 ~amd64"
ACCEPT_LICENSE="@FREE"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-O2 -pipe -march=native -fdiagnostics-color=always -frecord-gcc-switches"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/config /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c"
CXXFLAGS="-O2 -pipe -march=native -fdiagnostics-color=always -frecord-gcc-switches -D_GLIBCXX_ASSERTIONS"
DISTDIR="/var/cache/distfiles"
EMERGE_DEFAULT_OPTS="--keep-going --with-bdeps=y --complete-graph --deep --dynamic-deps=n --changed-deps=n --usepkg-exclude sys-fs/zfs --usepkg-exclude sys-fs/zfs-kmod --usepkg=y --implicit-system-deps=n --jobs=4 --load-average 32"
ENV_UNSET="CARGO_HOME DBUS_SESSION_BUS_ADDRESS DISPLAY GOBIN GOPATH PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR XDG_STATE_HOME"
FCFLAGS="-O2 -pipe -march=native -fdiagnostics-color=always -frecord-gcc-switches"
FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs buildpkg cgroup clean-logs config-protect-if-modified distlocks ebuild-locks fixlafiles ipc-sandbox mount-sandbox multilib-strict network-sandbox news parallel-fetch parallel-install pid-sandbox preserve-libs protect-owned qa-unresolved-soname-deps sandbox sfperms split-log strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-O2 -pipe -march=native -fdiagnostics-color=always -frecord-gcc-switches"
GENTOO_MIRRORS="http://mirror.bytemark.co.uk/gentoo/ http://www.mirrorservice.org/sites/distfiles.gentoo.org/ http://mirrors.soeasyto.com/distfiles.gentoo.org/"
LANG="en_GB.UTF-8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed -Wl,--defsym=__gentoo_check_ldflags__=0 -Wl,-z,pack-relative-relocs"
LINGUAS="en en_GB"
PKGDIR="/var/cache/binpkgs"
PORTAGE_COMPRESS="xz"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/var/tmp"
RUSTFLAGS="-C target-cpu=native"
SHELL="/bin/bash"
USE="PIC X a52 aac acl acpi activities aes alsa amd64 avx avx2 bash-completion bluetooth branding bzip2 cairo caps cdda cdr clang cli crypt dbus declarative dist-kernel dri dts dvd dvdr emacs encode exif f16c filecaps firewalld flac fma3 fortran freetype gdbm gif gmp gpm graphite gtk gui hardened harfbuzz hunspell iconv icu ipv6 jit jpeg kde kdesu kwallet lcms libglvnd libnotify libtirpc llvm-libunwind lto mad mmx mmxext mng mp3 mp4 mpeg multilib ncurses nftables nls nptl ogg opengl openmp pam pango pclmul pcre pdf pgo pie pipewire plasma png policykit popcnt ppds pulseaudio qml qt5 rdrand readline screencast sdl seccomp semantic-desktop sha spell sse sse2 sse3 sse4_1 sse4_2 sse4a ssl ssp ssse3 startup-notification svg system-av1 system-binutils system-boost system-bootstrap system-cairo system-clang system-digest system-ffmpeg system-harfbuzz system-heimdal system-icu system-jpeg system-leveldb system-libevent system-libs system-libvpx system-libyaml system-llvm system-lz4 system-mitkrb5 system-sqlite system-ssl system-tbb system-uulib system-webp system-zlib systemd test-rust tiff truetype udev udisks unicode upower usb verify-sig vorbis vulkan wayland widgets x264 xattr xcb xml xtpax xv xvid zfs zlib zsh-completion" ABI_X86="32 64" ADA_TARGET="gnat_2020" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon sheets words" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="aes avx avx2 f16c fma3 mmx mmxext pclmul popcnt rdrand sha sse sse2 sse3 sse4_1 sse4_2 sse4a ssse3" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock greis isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="libinput" KERNEL="linux" L10N="en en-GB" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LLVM_TARGETS="AArch64 AMDGPU ARM AVR BPF Hexagon Lanai MSP430 Mips NVPTX PowerPC RISCV Sparc SystemZ WebAssembly X86 XCore" LUA_SINGLE_TARGET="lua5-1" LUA_TARGETS="lua5-1" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php7-4 php8-0" POSTGRES_TARGETS="postgres12 postgres13" PYTHON_SINGLE_TARGET="python3_10" PYTHON_TARGETS="python3_10 pypy3 python3_11 python3_8 python3_9" QEMU_USER_TARGETS="aarch64 aarch64_be alpha armeb hppa m68k ppc64le sparc64" RUBY_TARGETS="ruby31" USERLAND="GNU" VIDEO_CARDS="amdgpu radeonsi radeon" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq proto steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  ADDR2LINE, AR, ARFLAGS, AS, ASFLAGS, CC, CCLD, CONFIG_SHELL, CPP, CPPFLAGS, CTARGET, CXX, CXXFILT, ELFEDIT, EXTRA_ECONF, F77FLAGS, FC, GCOV, GPROF, INSTALL_MASK, LC_ALL, LD, LEX, LFLAGS, LIBTOOL, MAKE, MAKEFLAGS, MAKEOPTS, NM, OBJCOPY, OBJDUMP, PORTAGE_BINHOST, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, RANLIB, READELF, SIZE, STRINGS, STRIP, YACC, YFLAGS

(note the QA notice in the build log is my own, not something in portage)
Comment 3 Adrian Schollmeyer 2022-11-05 18:45:15 UTC
Same problem as https://bugs.gentoo.org/879533, but with a different error message.
Comment 4 Larry the Git Cow gentoo-dev 2022-11-06 11:07:11 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ca475f37660c940516572a8c4eee6ec0e017c0f1

commit ca475f37660c940516572a8c4eee6ec0e017c0f1
Author:     Adrian Schollmeyer <nex+b-g-o@nexadn.de>
AuthorDate: 2022-11-05 19:23:46 +0000
Commit:     Florian Schmaus <flow@gentoo.org>
CommitDate: 2022-11-06 11:04:24 +0000

    dev-libs/libstrophe: Backport /bin/sh -> dash fix
    
    Closes: https://bugs.gentoo.org/877049
    Closes: https://bugs.gentoo.org/879533
    Signed-off-by: Adrian Schollmeyer <nex+b-g-o@nexadn.de>
    Closes: https://github.com/gentoo/gentoo/pull/28148
    Signed-off-by: Florian Schmaus <flow@gentoo.org>

 dev-libs/libstrophe/Manifest                 |  1 +
 dev-libs/libstrophe/libstrophe-0.12.2.ebuild | 11 ++++++++++-
 2 files changed, 11 insertions(+), 1 deletion(-)
Comment 5 Larry the Git Cow gentoo-dev 2023-05-02 22:53:24 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=191fbdaf985652a3873a545226a53cc2ad37de41

commit 191fbdaf985652a3873a545226a53cc2ad37de41
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2023-05-02 22:50:03 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-05-02 22:53:12 +0000

    dev-libs/libstrophe: avoid maintainer mode b/c of bashisms patch
    
    The bashisms patch touches configure.ac so it causes maintainer mode
    in src_compile. Run eautoreconf instead.
    
    Bug: https://bugs.gentoo.org/877049
    Bug: https://bugs.gentoo.org/879533
    Signed-off-by: Sam James <sam@gentoo.org>

 dev-libs/libstrophe/libstrophe-0.12.2.ebuild | 11 +++++++++++
 1 file changed, 11 insertions(+)