Bug 874999 – games-emulation/gngb-20060309-r1 - cpu.c: error: implicit declaration of function gbserial_read

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Toralf Förster 2022-10-04 16:30:42 UTC]

cpu.c:882:21: warning: self-comparison always evaluates to false [-Wtautological-compare]
  882 |           (((A&0x0f)>(A&0x0f))?SET_FLAG(FLAG_H):UNSET_FLAG(FLAG_NH));
      |                     ^
cpu.c: In function cpu_run:
cpu.c:2913:24: error: implicit declaration of function gbserial_read; did you mean gbserial_send? [-Werror=implicit-function-declaration]
 2913 |                     SB=gbserial_read();
      |                        ^~~~~~~~~~~~~

  -------------------------------------------------------------------

  This is an unstable amd64 chroot image at a tinderbox (==build bot)
  name: 17.1_desktop_plasma_systemd-j4-20221002-192609

  -------------------------------------------------------------------

gcc-config -l:
 [1] x86_64-pc-linux-gnu-12.2.0 *
clang/llvm (if any):
clang version 15.0.1
Target: x86_64-pc-linux-gnu
Thread model: posix
InstalledDir: /usr/lib/llvm/15/bin
/usr/lib/llvm/15
15.0.1
Python 3.10.7
Available Ruby profiles:
  [1]   ruby27 (with Rubygems)
  [2]   ruby30 (with Rubygems) *
Available Rust versions:
  [1]   rust-bin-1.64.0 *
The following VMs are available for generation-2:
1)	IcedTea JDK 3.16.0 [icedtea-bin-8]
2)	OpenJDK 17.0.5_p5 [openjdk-17]
*)	Eclipse Temurin JDK 17.0.4.1_p1 [openjdk-bin-17]
4)	Eclipse Temurin JDK 8.345_p01 [openjdk-bin-8]
Available Java Virtual Machines:
  [1]   icedtea-bin-8 
  [2]   openjdk-17 
  [3]   openjdk-bin-8 
  [4]   openjdk-bin-17  system-vm

The Glorious Glasgow Haskell Compilation System, version 9.0.2
php cli (if any):
GNU Make 4.3

  HEAD of ::gentoo
commit c599bbe73cde8695547d97c33c9e7da684e68216
Author: Repository mirror & CI <[e-mail]>
Date:   Tue Oct 4 04:02:35 2022 +0000

    2022-10-04 04:02:35 UTC

emerge -qpvO games-emulation/gngb
[ebuild  N    ] games-emulation/gngb-20060309-r1  USE="opengl"

[Comment 1 Toralf Förster 2022-10-04 16:30:43 UTC]

Created attachment 819208 [details]
emerge-info.txt

[Comment 2 Toralf Förster 2022-10-04 16:30:44 UTC]

Created attachment 819211 [details]
emerge-history.txt

[Comment 3 Toralf Förster 2022-10-04 16:30:46 UTC]

Created attachment 819214 [details]
environment

[Comment 4 Toralf Förster 2022-10-04 16:30:47 UTC]

Created attachment 819217 [details]
etc.portage.tar.bz2

[Comment 5 Toralf Förster 2022-10-04 16:30:48 UTC]

Created attachment 819220 [details]
games-emulation:gngb-20060309-r1:20221004-045718.log

[Comment 6 Toralf Förster 2022-10-04 16:30:49 UTC]

Created attachment 819223 [details]
logs.tar.bz2

[Comment 7 Toralf Förster 2022-10-04 16:30:50 UTC]

Created attachment 819226 [details]
temp.tar.bz2

[Comment 8 Sam James 2022-11-20 21:20:47 UTC]

*** Bug 882267 has been marked as a duplicate of this bug. ***

[Comment 9 Larry the Git Cow 2022-11-21 04:59:33 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5e4b089e913c1b6c5888b0b9e4e1bbcce36577b4

commit 5e4b089e913c1b6c5888b0b9e4e1bbcce36577b4
Author:     Ionen Wolkens <[e-mail]>
AuthorDate: 2022-11-21 03:39:29 +0000
Commit:     Ionen Wolkens <[e-mail]>
CommitDate: 2022-11-21 04:58:06 +0000

    games-emulation/gngb: EAPI6->8, fix build w/ clang16, C2x, and lto
    
    Also GPL-2 -> GPL-2+, and fixing clang16 issues also fixed lto
    ones wrt bug #858641 ... but the real fix here would last rites,
    this is a terrible GB emulator by modern standards.
    
    Closes: https://bugs.gentoo.org/858641
    Closes: https://bugs.gentoo.org/874999
    Signed-off-by: Ionen Wolkens <[e-mail]>

 .../gngb/files/gngb-20060309-clang16.patch         | 100 +++++++++++++++++++++
 .../gngb/files/gngb-20060309-gentoo-zlib.patch     |  12 +++
 ...-20060309-r1.ebuild => gngb-20060309-r2.ebuild} |  23 ++---
 3 files changed, 125 insertions(+), 10 deletions(-)