https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/ Issue: games-emulation/gngb-20060309-r1 fails to compile (lto). Discovered on: amd64 (internal ref: lto_tinderbox) NOTE: This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing
Created attachment 791990 [details] build.log build log and emerge --info
Here is a bit of explanation: -Werror=lto-type-mismatch: User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO. For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase. -Werror=odr: Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule. -Werror=strict-aliasing: Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. Workarounds: - If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL). - Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr). - Fix it yourself if interested, of course (VALID FOR ALL). - Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing). - Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing). - -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing). See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5e4b089e913c1b6c5888b0b9e4e1bbcce36577b4 commit 5e4b089e913c1b6c5888b0b9e4e1bbcce36577b4 Author: Ionen Wolkens <ionen@gentoo.org> AuthorDate: 2022-11-21 03:39:29 +0000 Commit: Ionen Wolkens <ionen@gentoo.org> CommitDate: 2022-11-21 04:58:06 +0000 games-emulation/gngb: EAPI6->8, fix build w/ clang16, C2x, and lto Also GPL-2 -> GPL-2+, and fixing clang16 issues also fixed lto ones wrt bug #858641 ... but the real fix here would last rites, this is a terrible GB emulator by modern standards. Closes: https://bugs.gentoo.org/858641 Closes: https://bugs.gentoo.org/874999 Signed-off-by: Ionen Wolkens <ionen@gentoo.org> .../gngb/files/gngb-20060309-clang16.patch | 100 +++++++++++++++++++++ .../gngb/files/gngb-20060309-gentoo-zlib.patch | 12 +++ ...-20060309-r1.ebuild => gngb-20060309-r2.ebuild} | 23 ++--- 3 files changed, 125 insertions(+), 10 deletions(-)