Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 870283 - portage-3.0.36 creates stray empty binpkgs with binhost and binpkg-multi-instance
Summary: portage-3.0.36 creates stray empty binpkgs with binhost and binpkg-multi-inst...
Status: RESOLVED FIXED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Binary packages support (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Portage team
URL:
Whiteboard:
Keywords: InVCS
Depends on:
Blocks: 871561
  Show dependency tree
 
Reported: 2022-09-15 20:12 UTC by Sven Wegener
Modified: 2022-10-04 00:34 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge --info (emerge-info.txt,6.80 KB, text/plain)
2022-09-15 20:43 UTC, Sven Wegener
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Sven Wegener gentoo-dev 2022-09-15 20:12:13 UTC
host ~ # ls -l /var/spool/portage/packages/sys-apps/acl/acl-*
ls: cannot access '/var/spool/portage/packages/sys-apps/acl/acl-*': No such file or directory
host ~ # emerge -1k acl
Calculating dependencies... done!

>>> Emerging binary (1 of 1) sys-apps/acl-2.3.1-r1::gentoo
--2022-09-15 20:02:36--  http://binhost/sys-apps/acl/acl-2.3.1-r1-1.xpak
Resolving binhost... ip
Connecting to binhost|ip|:80... connected.
HTTP request sent, awaiting response... 200 OK
Length: 336091 (328K)
Saving to: ‘/var/spool/portage/packages/sys-apps/acl/acl-2.3.1-r1-2.xpak.partial’

/var/spool/portage/packages/sys-apps/acl/acl-2. 100%[======================================================================================================>] 328.21K  --.-KB/s    in 0.001s  

2022-09-15 20:02:36 (332 MB/s) - ‘/var/spool/portage/packages/sys-apps/acl/acl-2.3.1-r1-2.xpak.partial’ saved [336091/336091]

 * acl-2.3.1-r1-2.xpak MD5 SHA1 size ;-) ...                             [ ok ]
>>> Extracting info
>>> Extracting sys-apps/acl-2.3.1-r1

>>> Installing (1 of 1) sys-apps/acl-2.3.1-r1::gentoo

 * GNU info directory index is up-to-date.
host ~ # ls -l /var/spool/portage/packages/sys-apps/acl/acl-*
-rw-r--r-- 1 root portage 336091 Sep 12 07:16 /var/spool/portage/packages/sys-apps/acl/acl-2.3.1-r1-1.xpak
-rw-r--r-- 1 root portage      0 Sep 15 20:02 /var/spool/portage/packages/sys-apps/acl/acl-2.3.1-r1-2.xpak




I suspect https://github.com/gentoo/portage/commit/fa901a6510c4a5f72dec6aad86db6fe7efd6e7b3 and the placeholder logic to avoid a race condition.
Comment 1 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-09-15 20:18:05 UTC
Please include emerge --info for completeness.
Comment 2 Sven Wegener gentoo-dev 2022-09-15 20:43:03 UTC
Created attachment 805408 [details]
emerge --info
Comment 3 Larry the Git Cow gentoo-dev 2022-09-20 03:39:27 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/portage.git/commit/?id=50854d7a8d7b83e0a598f4e1258d3e063a3fe9e0

commit 50854d7a8d7b83e0a598f4e1258d3e063a3fe9e0
Author:     Sheng Yu <syu.os@protonmail.com>
AuthorDate: 2022-09-16 12:19:19 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-09-20 03:39:22 +0000

    Fix wrong creation of empty binpkg from binhost
    
    Bug: https://bugs.gentoo.org/870283
    Signed-off-by: Sheng Yu <syu.os@protonmail.com>
    Closes: https://github.com/gentoo/portage/pull/901
    Signed-off-by: Sam James <sam@gentoo.org>

 lib/_emerge/Binpkg.py | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)
Comment 4 Larry the Git Cow gentoo-dev 2022-09-23 03:30:29 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=041d1f125384dd935d058b555a0fcb6b260260cb

commit 041d1f125384dd935d058b555a0fcb6b260260cb
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2022-09-23 03:27:14 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-09-23 03:27:14 +0000

    sys-apps/portage: add 3.0.37
    
    Closes: https://bugs.gentoo.org/866197
    Closes: https://bugs.gentoo.org/869470
    Closes: https://bugs.gentoo.org/870229
    Closes: https://bugs.gentoo.org/870283
    Closes: https://bugs.gentoo.org/870310
    Closes: https://bugs.gentoo.org/871561
    Signed-off-by: Sam James <sam@gentoo.org>

 sys-apps/portage/Manifest              |   1 +
 sys-apps/portage/portage-3.0.37.ebuild | 273 +++++++++++++++++++++++++++++++++
 2 files changed, 274 insertions(+)
Comment 5 Larry the Git Cow gentoo-dev 2022-10-04 00:34:16 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=85f3eee96c83a5a4b7f41ff4775eba5ffbfc09ea

commit 85f3eee96c83a5a4b7f41ff4775eba5ffbfc09ea
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2022-10-04 00:34:05 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-10-04 00:34:05 +0000

    profiles: mask buggy binpkg portages
    
    to encourage people to upgrade.
    
    Bug: https://bugs.gentoo.org/870283
    Bug: https://bugs.gentoo.org/874771
    Signed-off-by: Sam James <sam@gentoo.org>

 profiles/package.mask | 10 ++++++++++
 1 file changed, 10 insertions(+)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4d8f8bf35a6624764492d67062cce5105b16b4c0

commit 4d8f8bf35a6624764492d67062cce5105b16b4c0
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2022-10-04 00:31:19 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-10-04 00:32:19 +0000

    sys-apps/portage: drop 3.0.36, 3.0.38
    
    Bug: https://bugs.gentoo.org/870283
    Bug: https://bugs.gentoo.org/874771
    Signed-off-by: Sam James <sam@gentoo.org>

 sys-apps/portage/Manifest              |   2 -
 sys-apps/portage/portage-3.0.36.ebuild | 273 ---------------------------------
 sys-apps/portage/portage-3.0.38.ebuild | 273 ---------------------------------
 3 files changed, 548 deletions(-)