Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 869989 - net-firewall/nftables sets RESTRICT="test? ( userpriv )"
Summary: net-firewall/nftables sets RESTRICT="test? ( userpriv )"
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 516568
  Show dependency tree
 
Reported: 2022-09-13 17:20 UTC by Mike Gilbert
Modified: 2022-09-15 20:25 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Gilbert gentoo-dev 2022-09-13 17:20:34 UTC
net-firewall/nftables sets RESTRICT="test? ( userpriv )". This is quite dangerous since it means the test suite will run as root with no prior notice.
Comment 1 Larry the Git Cow gentoo-dev 2022-09-13 17:34:30 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a60bcdc8ce5eec6674d5e28afa2bd4899d137508

commit a60bcdc8ce5eec6674d5e28afa2bd4899d137508
Author:     Mike Gilbert <floppym@gentoo.org>
AuthorDate: 2022-09-13 17:33:30 +0000
Commit:     Mike Gilbert <floppym@gentoo.org>
CommitDate: 2022-09-13 17:34:26 +0000

    net-firewall/nftables: drop RESTRICT="test? ( userpriv )"
    
    Instead, check for root and skip the relevant tests otherwise.
    
    Closes: https://bugs.gentoo.org/869989
    Signed-off-by: Mike Gilbert <floppym@gentoo.org>

 net-firewall/nftables/nftables-1.0.4-r2.ebuild | 8 ++++++--
 net-firewall/nftables/nftables-1.0.5.ebuild    | 8 ++++++--
 net-firewall/nftables/nftables-9999.ebuild     | 8 ++++++--
 3 files changed, 18 insertions(+), 6 deletions(-)
Comment 2 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-09-13 22:51:42 UTC
I agree with what we've ended up doing here, but I want to pop some more details in the bug for completeness.

We discussed this some more on IRC. I'd checked the tests before doing this and am fairly happy that it'd be fine as it make an effort to use namespaces, but the tests are in such shape that they don't work in an ebuild environment properly anyway.

Plus, we now have a "Manual" value for the "runtime testing required" field on stable/kw bugs, which means we don't really need to worry so much about making-src_test-do-something-useful.