Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 868132 - sci-chemistry/avogadro2 1.95.1 contains two important regressions, request for action
Summary: sci-chemistry/avogadro2 1.95.1 contains two important regressions, request fo...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Chemistry-Related Packages
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2022-09-03 00:42 UTC by Aritz Erkiaga
Modified: 2022-09-07 09:55 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Aritz Erkiaga 2022-09-03 00:42:50 UTC
Avogadro 1.95.1 contains two regressions that heavily hamper usability. I fixed those a few months ago, and while those fixes have been picked up by most major distributions, Gentoo is still offering an unpatched version. I'd like to be as helpful as possible to get Avogadro working on Gentoo.

First bug: https://github.com/OpenChemistry/avogadrolibs/issues/820
Fixed in PR: https://github.com/OpenChemistry/avogadrolibs/pull/819
Description: most actions while drawing molecules would easily (i.e. every time) trigger data corruption, and cause unpredictable behavior or crashes.

Second bug: https://github.com/OpenChemistry/avogadrolibs/issues/754 and https://github.com/OpenChemistry/avogadrolibs/issues/741
Fixed in PR: https://github.com/OpenChemistry/avogadrolibs/pull/825
Description: two of the basic tools for editing molecules would simply not work.

Now, I'd like to describe what the recent development has been like. Next version after 1.95.1 was 1.96.0, which included those two fixes, as well as small features and a lot of performance work. Now the latest version is 1.97.0, which adds a couple of big features from GSoC. Finally, 1.98.0 is probably not very far away, should be out "at the end of the summer".

So, whatever the maintainers see best (cherry-picking the patches or updating to a newer version altogether), I'll be happy to help. I can edit and test the emerge files if that's required.
Comment 1 Aritz Erkiaga 2022-09-03 13:48:59 UTC
To be clear, those patches affect code in sci-libs/avogadrolibs 1.95. If the pathches were backported, they would ONLY affect that package, while a version bump would affect both.
Comment 2 Larry the Git Cow gentoo-dev 2022-09-07 09:55:08 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=99722c1e15796d7b5b60d59a43b1bc73f0657eea

commit 99722c1e15796d7b5b60d59a43b1bc73f0657eea
Author:     Aritz Erkiaga <aerkiaga3@gmail.com>
AuthorDate: 2022-09-03 15:57:03 +0000
Commit:     Andrew Ammerlaan <andrewammerlaan@gentoo.org>
CommitDate: 2022-09-07 09:54:55 +0000

    Backport critical fixes to sci-libs/avogadrolibs
    
    Signed-off-by: Aritz Erkiaga <aerkiaga3@gmail.com>
    Closes: https://bugs.gentoo.org/868132
    Closes: https://github.com/gentoo/gentoo/pull/27128
    Signed-off-by: Andrew Ammerlaan <andrewammerlaan@gentoo.org>

 ...1.95.1.ebuild => avogadrolibs-1.95.1-r1.ebuild} |  1 +
 .../avogadrolibs-1.95.1-usability_backport.patch   | 81 ++++++++++++++++++++++
 2 files changed, 82 insertions(+)

Additionally, it has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a25521396182617822aa285b16ac3af82cacea83

commit a25521396182617822aa285b16ac3af82cacea83
Author:     Andrew Ammerlaan <andrewammerlaan@gentoo.org>
AuthorDate: 2022-09-07 09:47:05 +0000
Commit:     Andrew Ammerlaan <andrewammerlaan@gentoo.org>
CommitDate: 2022-09-07 09:54:54 +0000

    sci-chemistry/avogadro2: add 1.97.0
    
    Bug: https://bugs.gentoo.org/868132
    Signed-off-by: Andrew Ammerlaan <andrewammerlaan@gentoo.org>

 sci-chemistry/avogadro2/Manifest                |  2 +
 sci-chemistry/avogadro2/avogadro2-1.97.0.ebuild | 82 +++++++++++++++++++++++++
 2 files changed, 84 insertions(+)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=9e97c03aece8465ab60bf30fc1807267e2238d21

commit 9e97c03aece8465ab60bf30fc1807267e2238d21
Author:     Andrew Ammerlaan <andrewammerlaan@gentoo.org>
AuthorDate: 2022-09-07 09:33:34 +0000
Commit:     Andrew Ammerlaan <andrewammerlaan@gentoo.org>
CommitDate: 2022-09-07 09:54:52 +0000

    sci-libs/avogadrolibs: add 1.97.0
    
    Bug: https://bugs.gentoo.org/832528
    Bug: https://bugs.gentoo.org/712962
    Bug: https://bugs.gentoo.org/868132
    Signed-off-by: Andrew Ammerlaan <andrewammerlaan@gentoo.org>

 sci-libs/avogadrolibs/Manifest                   |  2 +
 sci-libs/avogadrolibs/avogadrolibs-1.97.0.ebuild | 93 ++++++++++++++++++++++++
 2 files changed, 95 insertions(+)