Arch teams, please stabilize.
This version broke a fair amount of packages so we need to be careful to stable fixes first.
Hi, One of the loaders (xpm) in Imlib2 1.7.5 had a bad bug where it was `memmem`-ing potentially gigabytes of data. Which would result in freezes when someone tried to open, let's say a directory. [0] IMO, it's best to skip this version and stabilize 1.9.0 instead (which has been in tree for ~3months now). And if we *are* to stabilize this, I would recommend back-porting this patch [1]. [0]: https://codeberg.org/nsxiv/nsxiv-record/issues/218#issuecomment-475621 [1]: https://git.enlightenment.org/old/legacy-imlib2/commit/ac59f89870ffab9739a0cde70b0787c5e53cddf3
(In reply to Nickolas Raymond Kaczynski from comment #2) > IMO, it's best to skip this version and stabilize 1.9.0 instead (which has > been in tree for ~3months now). And if we *are* to stabilize this, I would > recommend back-porting this patch [1]. Stabilizing 1.9.0 will break imlib2_loaders, which require the same version of imlib2 to be present. Unfortunately imlib2-1.9.0 was added without imlib2_loaders update by external contribution. I will add imlib2-{,_loaders}-1.9.1 soon, but it will take a usual 30-day timeout before stabilization can be done.
(In reply to Andrew Savchenko from comment #3) > Stabilizing 1.9.0 will break imlib2_loaders, which require the same version > of imlib2 to be present. Unfortunately imlib2-1.9.0 was added without > imlib2_loaders update by external contribution. > > I will add imlib2-{,_loaders}-1.9.1 soon, but it will take a usual 30-day > timeout before stabilization can be done. Ah, I see. In that case I'd just backport that patch. Or does backporting a patch also reset the stabilization timeout?
(In reply to Nickolas Raymond Kaczynski from comment #4) > (In reply to Andrew Savchenko from comment #3) > > Stabilizing 1.9.0 will break imlib2_loaders, which require the same version > > of imlib2 to be present. Unfortunately imlib2-1.9.0 was added without > > imlib2_loaders update by external contribution. > > > > I will add imlib2-{,_loaders}-1.9.1 soon, but it will take a usual 30-day > > timeout before stabilization can be done. > > Ah, I see. In that case I'd just backport that patch. Or does backporting a > patch also reset the stabilization timeout? Usually any change which changes installed binary requires revision bump and any revision bump requires stabilization. There are exceptions for small changes (typos, minor files) and in exceptional cases committing straight to stable is possible, but this is not such case. In our case as sam has pointed out 1.7.5 update broke some packages (that was due to imlib2-config removal in favour of more standard imlib2.pc approach), so we need to wait for their update to be stabilized first. As I see we are waiting for w3m for now. So there is no need to backport patch until they are fixed and stabilized, which will make some time as well.
Given we can't always be around, it makes sense to add a comment to the ebuild then.
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f2a68ba41c253c96a0da6a86ecc691ded02ae40e commit f2a68ba41c253c96a0da6a86ecc691ded02ae40e Author: Sam James <sam@gentoo.org> AuthorDate: 2022-08-01 03:21:20 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2022-08-01 03:21:20 +0000 media-libs/imlib2: add note to bump with media-plugins/imlib2_loaders Bug: https://bugs.gentoo.org/862528 Signed-off-by: Sam James <sam@gentoo.org> media-libs/imlib2/imlib2-1.9.1.ebuild | 2 ++ 1 file changed, 2 insertions(+)
(In reply to Andrew Savchenko from comment #3) > Unfortunately imlib2-1.9.0 was added without > imlib2_loaders update by external contribution. Ah yes, I remember now. That was actually me! I *was* aware of `imlib2-loaders` but v1.9.0 turned out to be a pain in the ass due to some of the new dependencies being related to rust + my inexperience with autohell. So by the time I was done with the ebuild `imlib2-loaders` totally escaped my mind. > it makes sense to add a comment to the ebuild then. I agree, it would make such errors less likely in the future.
Ready now?
arm done
arm64 done
x86 done
amd64 done
ppc64 done
Looking good on ppc. # cat imlib2-862528.report USE tests started on Do 1. Dez 18:54:35 CET 2022 FEATURES=' test' USE='' succeeded for =media-libs/imlib2-1.7.5 USE='X -bzip2 -doc -gif jpeg -mp3 -png -shm -static-libs -tiff -webp -zlib' succeeded for =media-libs/imlib2-1.7.5 USE='X bzip2 -doc gif -jpeg mp3 -png shm -static-libs -tiff -webp -zlib' succeeded for =media-libs/imlib2-1.7.5 USE='-X bzip2 doc -gif -jpeg -mp3 -png -shm static-libs tiff -webp -zlib' succeeded for =media-libs/imlib2-1.7.5 USE='X -bzip2 doc gif jpeg -mp3 -png -shm -static-libs -tiff webp -zlib' succeeded for =media-libs/imlib2-1.7.5 USE='X bzip2 doc -gif -jpeg mp3 png shm static-libs -tiff webp -zlib' succeeded for =media-libs/imlib2-1.7.5 USE='X bzip2 doc -gif -jpeg mp3 png -shm static-libs tiff webp -zlib' succeeded for =media-libs/imlib2-1.7.5 USE='-X -bzip2 -doc -gif -jpeg mp3 -png -shm static-libs tiff -webp zlib' succeeded for =media-libs/imlib2-1.7.5 USE='-X bzip2 doc gif -jpeg -mp3 png -shm -static-libs -tiff webp zlib' succeeded for =media-libs/imlib2-1.7.5 USE='X bzip2 doc -gif -jpeg -mp3 -png -shm static-libs -tiff webp zlib' succeeded for =media-libs/imlib2-1.7.5 USE='X bzip2 doc -gif -jpeg mp3 -png -shm static-libs -tiff webp zlib' succeeded for =media-libs/imlib2-1.7.5 USE='-X -bzip2 -doc gif -jpeg -mp3 -png -shm -static-libs tiff webp zlib' succeeded for =media-libs/imlib2-1.7.5 USE='X bzip2 -doc gif -jpeg -mp3 -png shm static-libs tiff webp zlib' succeeded for =media-libs/imlib2-1.7.5 revdep tests started on Do 1. Dez 19:05:41 CET 2022 FEATURES=' test' USE='-gdk-pixbuf imlib' succeeded for www-client/w3m FEATURES=' test' USE='' succeeded for x11-misc/xfishtank FEATURES=' test' USE='' succeeded for x11-misc/skippy FEATURES=' test' USE='imlib' succeeded for x11-wm/openbox FEATURES=' test' USE='' succeeded for x11-misc/hsetroot FEATURES=' test' USE='' succeeded for media-libs/giblib FEATURES=' test' USE='' succeeded for dev-perl/Image-Imlib2 FEATURES=' test' USE='imlib' succeeded for media-libs/libcaca FEATURES=' test' USE='' succeeded for x11-misc/fbdesk FEATURES=' test' USE='' succeeded for x11-plugins/wmcoincoin
ppc done
Unable to check for sanity: > no match for package: media-libs/imlib2-1.7.5
Unable to check for sanity: > no match for package: media-plugins/imlib2_loaders-1.7.5-r1
Quick note: I've found a bug in imlib2-1.7.5 which has the capacity to lead to certain window managers crashing which seems to be fixed in 1.9.1; I've opened a separate bug at bug 887201.
sparc done all arches done
