Bug 887201 – media-libs/imlib2-1.9.1, media-plugins/imlib2_loaders-1.9.1 stabilization request (incorrect behaviour on loading XScreenSaver icon, leading to crashes in other packages)

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Sophie Hamilton 2022-12-19 13:41:15 UTC]

First off, my apologies for opening a new bug for this when I can see that version 1.7.5 is still in the process of being stabilised (bug 862528), but I'm experiencing a pretty bad bug with version 1.7.5.

Specifically, version 1.7.5 appears to fail in a weird way on my machine when loading /usr/share/pixmaps/xscreensaver.xpm from x11-misc/xscreensaver-6.01-r4 - it appears to load the image correctly, but no data is returned.

This causes a crash in x11-wm/openbox, for example, if the file is referenced in its XML file when the menu is opened! Since a WM crash typically means that the X server will die, this seems like a fairly serious issue.

In imlib2_view, the bug manifests as an infinite loop, while in media-gfx/feh the bug returns an X error. All these issues are resolved when using a version of media-libs/imlib2 other than 1.7.5. (Interestingly enough, even if you forget to merge the corresponding loaders package as I did initially!)

I'm uploading the offending image to the bug here so you can verify this for yourself without having to install x11-misc/xscreensaver yourself.

The image loads and works fine in 1.9.1, and I believe also 1.7.1-r2 and 1.9.0. (So presumably the bug was fixed.)

As this has the potential to be problematic for a large number of people, I'd like to request the stabilisation of 1.9.1 instead. Again, my apologies for opening this new bug while one is already open but I wasn't certain of the right thing to do here!

Reproducible: Always

Steps to Reproduce:
1. Attempt to load the image attached to this thread using imlib2 (or a package that uses it, such as x11-wm/openbox)
Actual Results:  
Every program that I tried crashed when trying to load the image.

Expected Results:  
The image displays the XScreenSaver icon.

Portage 3.0.38.1 (python 3.9.15-final-0, default/linux/amd64/17.1, gcc-11.3.0, glibc-2.36-r5, 5.15.32-gentoo-r1 x86_64)
=================================================================
System uname: Linux-5.15.32-gentoo-r1-x86_64-11th_Gen_Intel-R-_Core-TM-_i7-11700K_@_3.60GHz-with-glibc2.36
KiB Mem:    65718772 total,  57995716 free
KiB Swap:    8191996 total,   8191996 free
Timestamp of repository gentoo: Sun, 04 Dec 2022 00:45:01 +0000
sh bash 5.1_p16-r2
ld GNU ld (Gentoo 2.38 p4) 2.38
ccache version 4.6.3 [disabled]
app-misc/pax-utils:        1.3.5::gentoo
app-shells/bash:           5.1_p16-r2::gentoo
dev-java/java-config:      2.3.1::gentoo
dev-lang/perl:             5.34.1-r4::gentoo
dev-lang/python:           2.7.18_p16::gentoo, 3.7.13::gentoo, 3.8.15_p3::gentoo, 3.9.15_p3::gentoo, 3.10.8_p3::gentoo, 3.11.0_p2::gentoo
dev-lang/rust:             1.65.0::gentoo
dev-util/ccache:           4.6.3::gentoo
dev-util/cmake:            3.24.3::gentoo
dev-util/meson:            0.63.3::gentoo
sys-apps/baselayout:       2.9::gentoo
sys-apps/openrc:           0.45.2-r2::gentoo
sys-apps/sandbox:          2.29::gentoo
sys-devel/autoconf:        2.13-r7::gentoo, 2.71-r5::gentoo
sys-devel/automake:        1.16.5::gentoo
sys-devel/binutils:        2.38-r2::gentoo
sys-devel/binutils-config: 5.4.1::gentoo
sys-devel/clang:           13.0.1::gentoo, 15.0.5::gentoo
sys-devel/gcc:             6.5.0-r3::gentoo, 8.5.0-r1::gentoo, 9.4.0::gentoo, 10.4.0::gentoo, 11.3.0::gentoo
sys-devel/gcc-config:      2.8::gentoo
sys-devel/libtool:         2.4.7::gentoo
sys-devel/lld:             15.0.5::gentoo
sys-devel/llvm:            13.0.1::gentoo, 15.0.5::gentoo
sys-devel/make:            4.3::gentoo
sys-kernel/linux-headers:  5.15-r3::gentoo (virtual/os-headers)
sys-libs/glibc:            2.36-r5::gentoo
Repositories:

gentoo
    location: /usr/portage
    sync-type: webrsync
    sync-uri: rsync://rsync.gentoo.org/gentoo-portage
    priority: -1000
    sync-webrsync-verify-signature: yes

sph-local
    location: /opt/portage-overlay
    masters: gentoo
    priority: 0

anomen
    location: /var/lib/layman/anomen
    masters: gentoo
    priority: 50

dotnet
    location: /var/lib/layman/dotnet
    masters: gentoo
    priority: 50

gambas-overlay
    location: /var/lib/layman/gambas-overlay
    masters: gentoo
    priority: 50

jorgicio
    location: /var/lib/layman/jorgicio
    masters: gentoo
    priority: 50

lmiphay
    location: /var/lib/layman/lmiphay
    masters: gentoo
    priority: 50

menelkir
    location: /var/lib/layman/menelkir
    masters: gentoo
    priority: 50

nest
    location: /var/lib/layman/nest
    masters: gentoo
    priority: 50

netfab-overlay
    location: /var/lib/layman/netfab-overlay
    masters: gentoo
    priority: 50

palemoon
    location: /var/lib/layman/palemoon
    masters: gentoo
    priority: 50

pentoo
    location: /var/lib/layman/pentoo
    masters: gentoo
    priority: 50

vapoursynth
    location: /var/lib/layman/vapoursynth
    masters: gentoo
    priority: 50

wine
    location: /var/lib/layman/wine
    masters: gentoo
    priority: 50

x11
    location: /var/lib/layman/x11
    masters: gentoo
    priority: 50

ACCEPT_KEYWORDS="amd64"
ACCEPT_LICENSE="@FREE"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-march=native -O2 -pipe"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /lib/udev/rules.d /usr/lib64/avfs/extfs /usr/share/gnupg/qualified.txt /var/bind"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/php/apache2-php8.0/ext-active/ /etc/php/apache2-php8.1/ext-active/ /etc/php/cgi-php8.0/ext-active/ /etc/php/cgi-php8.1/ext-active/ /etc/php/cli-php8.0/ext-active/ /etc/php/cli-php8.1/ext-active/ /etc/php/fpm-php8.0/ext-active/ /etc/php/fpm-php8.1/ext-active/ /etc/php/phpdbg-php8.0/ext-active/ /etc/php/phpdbg-php8.1/ext-active/ /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c"
CXXFLAGS="-march=native -O2 -pipe"
DISTDIR="/usr/portage/distfiles"
EMERGE_DEFAULT_OPTS="--ask-enter-invalid --autounmask --autounmask-keep-masks y"
ENV_UNSET="CARGO_HOME DBUS_SESSION_BUS_ADDRESS DISPLAY GOBIN GOPATH PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR XDG_STATE_HOME"
FCFLAGS="-O2 -pipe"
FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs buildpkg-live distlocks ebuild-locks fixlafiles ipc-sandbox merge-sync multilib-strict network-sandbox news parallel-fetch pid-sandbox preserve-libs protect-owned qa-unresolved-soname-deps sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-O2 -pipe"
GENTOO_MIRRORS="https://ftp.snt.utwente.nl/pub/os/linux/gentoo/"
LANG="en_GB.utf8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
LINGUAS="en en-GB"
MAKEOPTS="-j14"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/var/tmp"
SHELL="/bin/bash"
USE="X a52 aac aacplus acl acpi alsa amd64 amr bluray bzip2 cairo cdda cddb cdio cdparanoia cli crypt cups dbus dri dts dvb dvd flac fluidsynth fontconfig fortran gdbm gpm gtk ibus iconv icu ipv6 jpeg libglvnd libnotify libtirpc lzma mad mmx modplug mp3 mtp multilib ncurses nls nptl ogg opengl openmp pam pcre png qt3support qt5 readline seccomp sound split-usr sse sse2 ssl startup-notification svg tcl test-rust theora tk truetype unicode v4l vdpau vim-syntax vorbis vulkan xattr xv xvmc zlib" ABI_X86="64" ADA_TARGET="gnat_2021" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon sheets words" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="mmx mmxext sse sse2 aes avx avx2 f16c fma3 pclmul popcnt sse3 sse4_1 sse4_2 ssse3" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock greis isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="libinput" KERNEL="linux" L10N="en en-GB" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LUA_SINGLE_TARGET="lua5-1" LUA_TARGETS="lua5-1" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php7-4 php8-0" POSTGRES_TARGETS="postgres12 postgres13" PYTHON_SINGLE_TARGET="python3_9" PYTHON_TARGETS="python3_8 python3_9" QEMU_SOFTMMU_TARGETS="x86_64 arm i386 mips mipsel ppc sparc" QEMU_USER_TARGETS="aarch64 alpha arm i386 m68k mips mipsel ppc sparc x86_64" RUBY_TARGETS="ruby27" USERLAND="GNU" VIDEO_CARDS="amdgpu radeonsi" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq proto steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  ADDR2LINE, AR, ARFLAGS, AS, ASFLAGS, CC, CCLD, CONFIG_SHELL, CPP, CPPFLAGS, CTARGET, CXX, CXXFILT, ELFEDIT, EXTRA_ECONF, F77FLAGS, FC, GCOV, GPROF, INSTALL_MASK, LC_ALL, LD, LEX, LFLAGS, LIBTOOL, MAKE, MAKEFLAGS, NM, OBJCOPY, OBJDUMP, PORTAGE_BINHOST, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, RANLIB, READELF, RUSTFLAGS, SIZE, STRINGS, STRIP, YACC, YFLAGS

[Comment 1 Sophie Hamilton 2022-12-19 13:46:09 UTC]

Created attachment 843803 [details]
The XPM file which causes the bug in media-libs/imlib2-1.7.5

I forgot to upload this at first, sorry!

[Comment 2 Sam James 2022-12-20 07:59:47 UTC]

Thanks for the detailed report. By coincidence, I'd come across the stalled stablereq yesterday. It's not ideal but it's not a reason to leave things broken.

Let's go ahead.

[addCollapseLink(3, 1, 'Toggle comment display'); Comment 3 NATTkA bot 2022-12-20 08:04:11 UTC Comment hidden (obsolete)]

Unable to check for sanity:

> no match for package: media-libs/imlib2-1.9.1

[Comment 4 Sophie Hamilton 2022-12-20 09:20:04 UTC]

I'm not part of the Gentoo dev team so I don't know if I should fix the package list manually or not, but just a heads-up that the loaders package is actually in the media-plugins category, not media-libs! That's why I hadn't initially put a category in my subject line.

[Comment 5 Sam James 2022-12-20 09:21:21 UTC]

(In reply to Sophie Hamilton from comment #4)
> I'm not part of the Gentoo dev team so I don't know if I should fix the
> package list manually or not, but just a heads-up that the loaders package
> is actually in the media-plugins category, not media-libs! That's why I
> hadn't initially put a category in my subject line.

Whoops! Feel free to fix something like this if it's obvious.

I've expanded the summary so it's easier to find in searches. Not that what you did is wrong, we do it all the time for ${PN} at least in security bugs.

[addCollapseLink(6, 1, 'Toggle comment display'); Comment 6 NATTkA bot 2022-12-20 09:24:14 UTC Comment hidden (obsolete)]

Unable to check for sanity:

> no match for package: media-libs/imlib2-1.9.1

[Comment 7 Andrew Savchenko 2022-12-21 19:55:48 UTC]

There are no known problems with 1.9.1, so please proceed with stabilization.

I wonder why arches are not actually CC'ed while CC-ARCHES keyword is set. Is this some bug?

[Comment 8 Sam James 2022-12-21 22:44:32 UTC]

sparc done

[Comment 9 Sam James 2022-12-21 22:48:17 UTC]

arm64 done

[Comment 10 Sam James 2022-12-21 22:48:18 UTC]

arm done

[Comment 11 Sam James 2022-12-21 22:53:53 UTC]

ppc64 done

[Comment 12 Sam James 2022-12-21 23:09:39 UTC]

amd64 done

[Comment 13 Sam James 2022-12-21 23:09:40 UTC]

ppc done

[Comment 14 Arthur Zamarin 2022-12-22 07:26:53 UTC]

x86 done

all arches done