Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 829203 - net-im/zoom-5.8.6.739: wrong icon?
Summary: net-im/zoom-5.8.6.739: wrong icon?
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Ulrich Müller
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-12-14 19:47 UTC by Fulgurance
Modified: 2022-01-10 11:34 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Desktop file (file_829203.txt,238 bytes, text/plain)
2021-12-28 11:48 UTC, Fulgurance
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Fulgurance 2021-12-14 19:47:39 UTC
Hello, today I emerged the last version of zoom, and I seen the desktop icon isn't good.

Something wrong in the last ebuild ?
Comment 1 Mike Gilbert gentoo-dev 2021-12-14 20:04:10 UTC
What version of net-im/zoom?

Please describe what you expect to see versus what you actually see. Screen shots would be helpful.
Comment 2 Fulgurance 2021-12-14 20:07:21 UTC
 zohran  ~  eix net-im/zoom
[I] net-im/zoom
     Available versions:  (~)5.4.53391.1108-r3^msd (~)5.8.4.210^msd (~)5.8.6.739^msd {bundled-libjpeg-turbo +bundled-qt opencl pulseaudio wayland}
     Installed versions:  5.8.6.739^msd(20:37:24 14/12/2021)(bundled-qt pulseaudio wayland -bundled-libjpeg-turbo -opencl)
     Homepage:            https://zoom.us/
     Description:         Video conferencing and web conferencing service
Comment 3 Fulgurance 2021-12-14 20:09:50 UTC
Link to a screenshot: https://www.zupimages.net/up/21/50/cj19.png
Comment 4 Ulrich Müller gentoo-dev 2021-12-28 10:24:25 UTC
(In reply to Fulgurance from comment #3)
> Link to a screenshot: https://www.zupimages.net/up/21/50/cj19.png

That's not the icon installed by net-im/zoom. Questions:

1. Do the following icons look correct?
/usr/share/pixmaps/zoom-icon.svg
/usr/share/icons/hicolor/scalable/apps/zoom-icon.svg

2. Please attach /usr/share/applications/zoom-zoom.desktop

3. What is the output of "grep -ilr zoom /usr/share/applications"?
Comment 5 Fulgurance 2021-12-28 11:48:57 UTC
Created attachment 760658 [details]
Desktop file
Comment 6 Fulgurance 2021-12-28 11:50:09 UTC
For your first questions, all icons are good.

For the second question, I had the attachement.

For the third one:

 zohran   master  ~  Documents  Programmation  ISM  grep -ilr zoom /usr/share/applications
/usr/share/applications/zoom-zoom.desktop
/usr/share/applications/mimeinfo.cache
Comment 7 Fulgurance 2021-12-28 11:52:28 UTC
I don't know if it's relevant, but I have a 4k screen, and before with my old laptop, I didn't have this problem, maybe a problem with the scale ?

My plasma laptop is with scale of 200%, because of the screen resolution
Comment 8 Fulgurance 2021-12-28 11:53:17 UTC
But it's the only one icon with this problem
Comment 9 Ulrich Müller gentoo-dev 2021-12-28 12:44:22 UTC
These files look all correct.

The icon that you see is a generic icon of KDE. No idea why that would show up, when the desktop file specifically says "Icon=zoom-icon", and zoom-icon.svg exists both in /usr/share/pixmaps/ and /usr/share/icons/hicolor/scalable/apps/.

CCing KDE team, any idea what is happening here?
Comment 10 Andreas Sturmlechner gentoo-dev 2021-12-28 13:10:24 UTC
All I can say right now is, it is using the same system zoom action icon on my system.
Comment 11 Ulrich Müller gentoo-dev 2021-12-28 18:40:26 UTC
I wonder if we shouldn't rename the icon (again), e.g. to videoconference-zoom.svg in order to prevent fallback to the system zoom icon.
Comment 12 Ulrich Müller gentoo-dev 2022-01-09 14:18:53 UTC
The "Icon Naming Specification" https://specifications.freedesktop.org/icon-naming-spec/icon-naming-spec-latest.html#guidelines says:

| The dash “-” character is used to separate levels of specificity in
| icon names, for all contexts other than MimeTypes. For instance, we
| use “input-mouse” as the generic item for all mouse devices, and we
| use “input-mouse-usb” for a USB mouse device. However, if the more
| specific item does not exist in the current theme, and does exist in
| a parent theme, the generic icon from the current theme is preferred,
| in order to keep consistent style.

So what I suspect is that for some reason the window manager doesn't find "zoom-icon" in its current theme and falls back to "zoom". According to the spec it should prefer (what it thinks is) the generic icon to "zoom-icon" in another theme.

I am going to rename the icon to "videoconference-zoom" in zoom-5.9.1.1380, which will hopefully prevent the fallback to the zoom system icon.
Comment 13 Larry the Git Cow gentoo-dev 2022-01-09 14:21:01 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=66434115925e355179c4f0be49f9edb3199d4bfc

commit 66434115925e355179c4f0be49f9edb3199d4bfc
Author:     Ulrich Müller <ulm@gentoo.org>
AuthorDate: 2022-01-09 13:59:07 +0000
Commit:     Ulrich Müller <ulm@gentoo.org>
CommitDate: 2022-01-09 14:07:20 +0000

    net-im/zoom: Version bump to 5.9.1.1380
    
    Change the desktop entry type from InstantMessaging (the default)
    to VideoConference.
    
    Change the icon name from zoom-icon to videoconference-zoom, in order to
    prevent a fallback to the zoom system icon.
    
    Bug: https://bugs.gentoo.org/829203
    Package-Manager: Portage-3.0.30, Repoman-3.0.3
    Signed-off-by: Ulrich Müller <ulm@gentoo.org>

 net-im/zoom/Manifest               |   1 +
 net-im/zoom/zoom-5.9.1.1380.ebuild | 161 +++++++++++++++++++++++++++++++++++++
 2 files changed, 162 insertions(+)
Comment 14 Ulrich Müller gentoo-dev 2022-01-09 14:22:23 UTC
Please test.
Comment 15 Fulgurance 2022-01-10 11:34:35 UTC
This solved my problem, thanks you :)