Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 759253 - net-im/zoom should use "official" icon
Summary: net-im/zoom should use "official" icon
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal enhancement
Assignee: Ulrich Müller
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-12-09 17:07 UTC by Fulgurance
Modified: 2021-12-28 13:10 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Fulgurance 2020-12-09 17:07:20 UTC
Hello, I just want to notice you the zoom ebuild don't use the official icon of the zoom application (conferencing Web software) . Can you fixe that? Do you need somebody upload this picture for you?

(this minor problem is present from the beginning)
Comment 1 Ulrich Müller gentoo-dev 2020-12-10 06:50:58 UTC
See bug 715088 comment #6.

Please report the problem upstream.
Comment 2 Ulrich Müller gentoo-dev 2020-12-10 10:03:31 UTC
In fact, the icon is contained in the zoom binary as an SVG image, and we could extract it with some sed magic:

LC_ALL=C sed -n '/<svg width="32"/{s/.*\(<svg \)/\1/;p;:x;n;p;/<\/svg>/q;bx}' /opt/zoom/zoom >zoom-videocam.svg

Then again, you had reported in bug 715590 that an SVG icon won't work for you, and (because we don't have a license) we cannot create any derived versions of the icon  in other formats like PNG or XPM.
Comment 3 Fulgurance 2020-12-10 10:14:18 UTC
No you don't understand, I don't mention this picture don't work, read my post, I mention this icon isn't the official icon, not the same problem.

And why you need to create derived??? Many others Linux distributionuse the official icon,just only gentoo use this strange fan made icon... 

For me gentoo is serious distributionand need to have the right icon
Comment 4 Ulrich Müller gentoo-dev 2020-12-10 10:43:16 UTC
(In reply to Fulgurance from comment #3)
> No you don't understand, I don't mention this picture don't work, read my
> post, I mention this icon isn't the official icon, not the same problem.

You had posted a screenshot in bug 715590 comment #4 which showed that the SVG icon apparently isn't displayed. Does it show the camera icon now, or is it still broken?

> And why you need to create derived??? Many others Linux distributionuse the
> official icon,just only gentoo use this strange fan made icon... 

Like I said, there is no icon in the tarball that we could install, and we are not allowed to distribute the official icon ourselves. So, please report the problem upstream.

> For me gentoo is serious distributionand need to have the right icon

Yep, and Zoom is a serious program, so its upstream should be more professional when packaging their tarballs.
Comment 5 Fulgurance 2020-12-10 10:50:14 UTC
Oh zoom provider packaging bad? Okay... .

Man, I talk about this post, why you mention my very old previous other post.....
Comment 6 Ulrich Müller gentoo-dev 2020-12-10 10:57:00 UTC
(In reply to Fulgurance from comment #5)
> Man, I talk about this post, why you mention my very old previous other
> post.....

Because you haven't answered my question. Does it show the camera icon for you, or an empty box as in that screenshot of yours?
Comment 7 Fulgurance 2020-12-10 10:59:43 UTC
I already answered for me. Yes I see the camera icon
Comment 8 Fulgurance 2020-12-10 11:00:19 UTC
I have question, what do you need to use the official icon? just contact development team?
Comment 9 Ulrich Müller gentoo-dev 2020-12-10 11:28:35 UTC
They need to package Zoom.png in their tarball.
Comment 10 Larry the Git Cow gentoo-dev 2020-12-10 20:35:44 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=233562d771e24e722fbef1e45711895efe58d4a4

commit 233562d771e24e722fbef1e45711895efe58d4a4
Author:     Ulrich Müller <ulm@gentoo.org>
AuthorDate: 2020-12-10 20:35:04 +0000
Commit:     Ulrich Müller <ulm@gentoo.org>
CommitDate: 2020-12-10 20:35:38 +0000

    net-im/zoom: Extract official icon from the binary.
    
    Bug: https://bugs.gentoo.org/759253
    Package-Manager: Portage-3.0.12, Repoman-3.0.2
    Signed-off-by: Ulrich Müller <ulm@gentoo.org>

 net-im/zoom/zoom-5.4.56259.1207-r1.ebuild | 144 ++++++++++++++++++++++++++++++
 1 file changed, 144 insertions(+)
Comment 11 Ulrich Müller gentoo-dev 2020-12-10 20:37:05 UTC
net-im/zoom-5.4.56259.1207-r1 now extracts the icon (an SVG file) from the zoom binary and installs it.

Please test.
Comment 12 Fulgurance 2020-12-10 22:10:34 UTC
I already tested, but now, the icon isn't visible, and I have the svg support ...
Comment 13 Fulgurance 2020-12-10 22:16:07 UTC
But I think now this problem come with plasma, because when I open this picture, it's the good icon...

What plasma users need to do ?
Comment 14 Ulrich Müller gentoo-dev 2020-12-10 23:21:22 UTC
(In reply to Fulgurance from comment #13)
> But I think now this problem come with plasma, because when I open this
> picture, it's the good icon...
> 
> What plasma users need to do ?

This may be the issue from bug 715590 comment #4 again. I don't know if it's a problem with your settings, or a bug in KDE (or Qt). CCing KDE team, maybe they can help?
Comment 15 Andreas Sturmlechner gentoo-dev 2020-12-11 22:53:49 UTC
Well, what you see is the icon for 'the' system zoom action. It doesn't come as much surprise that using just their very generic product name for installing the icon file globally could lead to a namespace conflict like that.

Solution: Rename to 'zoom-im', 'zoom-videoconferencing' or whatever.
Comment 16 Fulgurance 2020-12-11 23:01:13 UTC
Yes, I already check many things, and I'm sure the problem isn't my KDE installation, the problem come just with this ebuild only. I can see svg picture with dolphin for example.
Comment 17 Larry the Git Cow gentoo-dev 2020-12-12 08:00:35 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=45028317a7f64914d4f187bd62e143f632e45467

commit 45028317a7f64914d4f187bd62e143f632e45467
Author:     Ulrich Müller <ulm@gentoo.org>
AuthorDate: 2020-12-12 07:55:08 +0000
Commit:     Ulrich Müller <ulm@gentoo.org>
CommitDate: 2020-12-12 08:00:30 +0000

    net-im/zoom: Rename icon so it won't clash with KDE's zoom action.
    
    Bug: https://bugs.gentoo.org/759253#c15
    Package-Manager: Portage-3.0.12, Repoman-3.0.2
    Signed-off-by: Ulrich Müller <ulm@gentoo.org>

 ...5.4.56259.1207-r1.ebuild => zoom-5.4.56259.1207-r2.ebuild} | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)
Comment 18 Ulrich Müller gentoo-dev 2020-12-12 08:10:57 UTC
(In reply to Andreas Sturmlechner from comment #15)
> Well, what you see is the icon for 'the' system zoom action. It doesn't come
> as much surprise that using just their very generic product name for
> installing the icon file globally could lead to a namespace conflict like
> that.
> 
> Solution: Rename to 'zoom-im', 'zoom-videoconferencing' or whatever.

Interesting. Now that you say it, it is obvious that the icon in that screenshot stands for a zoom action. I had misread it as an empty box with a dashed line as boundary, i.e., as a placeholder for a missing icon.

Note though that net-im/zoom-3.5.374815.0324-r2 (which bug 715590 was about) didn't install the icon as zoom.svg but as zoom-videocam.svg. So I wonder why the generic zoom icon would have showed up?

In any case, I have now renamed the icon again, so please test net-im/zoom-5.4.56259.1207-r2.
Comment 19 Andreas Sturmlechner gentoo-dev 2020-12-12 09:36:44 UTC
Fixed.
Comment 20 Fulgurance 2020-12-14 08:00:22 UTC
I checked, but the ebuild use just the copy of zoom icon, not the official icon.

To help to fixe this minimal problem, I contacted today zoom by email to add their icon in their archive, and if they can allow Gentoo to use the official icon.
Comment 21 Ulrich Müller gentoo-dev 2020-12-14 08:12:44 UTC
(In reply to Fulgurance from comment #20)
> I checked, but the ebuild use just the copy of zoom icon, not the official
> icon.

Sorry, but what do you mean by "copy of icon"?

Did you test with net-im/zoom-5.4.56259.1207-r2, which extracts the icon (as SVG file) from the zoom binary and installs it?
Comment 22 Ulrich Müller gentoo-dev 2020-12-21 14:49:50 UTC
No reply. Closing as FIXED again.
Comment 23 Fulgurance 2020-12-21 15:11:04 UTC
It's good for me, thanks you!