Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 811531 - media-libs/libcanberra disable gtk use flag by default
Summary: media-libs/libcanberra disable gtk use flag by default
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-09-04 03:20 UTC by Casey Avila
Modified: 2022-04-12 03:15 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Casey Avila 2021-09-04 03:20:37 UTC
Given the `gtk` USE flag for libcanberra enables GTK-2 support, while the `gtk3` USE flag enables GTK-3 support, it would be useful to at least have the `gtk` USE flag disabled by default given GTK-2 has entered EOL and Gentoo is working on gtk2-removal.
Comment 1 Andreas Sturmlechner gentoo-dev 2021-09-04 14:23:55 UTC
This is not going to do much, given that desktop profile is always enabling IUSE=gtk by default anyway. I suspect the current configuration will remain until the last revdep depending on gtk2 impl (claws-mail) is gone.
Comment 2 Matt Turner gentoo-dev 2021-09-06 20:17:41 UTC
We could rename the flags: "gtk" -> "gtk2" and "gtk3" -> "gtk". Would help somewhat.
Comment 3 Andreas Sturmlechner gentoo-dev 2021-09-07 13:04:54 UTC
It should still be default enabled or introduces a default REQUIRED_USE conflict for claws-mail users, so does not achieve what the bug reporter wants.

And that's a lot of useless churn in revdeps when cleanup is in its foreseeable future anyway, see bug 769464.
Comment 4 Casey Avila 2021-09-08 06:06:18 UTC
What I was looking for was libcanberra not to pull in gtk 2 if it's not necessary. If `gtk` is enabled by the desktop profile, rearranging the USE flags as proposed would work right?

As for claws-mail, we can make it depend on libcanberra[gtk2] instead of libcanberra[gtk].
Comment 5 Larry the Git Cow gentoo-dev 2022-04-12 03:15:50 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=045488f09d792adcd03ddb91e391c94ae2c6d225

commit 045488f09d792adcd03ddb91e391c94ae2c6d225
Author:     Matt Turner <mattst88@gentoo.org>
AuthorDate: 2022-04-12 03:10:52 +0000
Commit:     Matt Turner <mattst88@gentoo.org>
CommitDate: 2022-04-12 03:15:44 +0000

    media-libs/libcanberra: Change IUSE=+gtk to IUSE=gtk2
    
    Bug: https://bugs.gentoo.org/769464
    Bug: https://bugs.gentoo.org/834685
    Closes: https://bugs.gentoo.org/811531
    Signed-off-by: Matt Turner <mattst88@gentoo.org>

 .../{libcanberra-0.30-r5.ebuild => libcanberra-0.30-r6.ebuild}    | 8 ++++----
 media-libs/libcanberra/metadata.xml                               | 2 +-
 2 files changed, 5 insertions(+), 5 deletions(-)

Additionally, it has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=65b51a8d7cc4ee7d3aa238e968c17eca331133c0

commit 65b51a8d7cc4ee7d3aa238e968c17eca331133c0
Author:     Matt Turner <mattst88@gentoo.org>
AuthorDate: 2022-04-12 03:08:54 +0000
Commit:     Matt Turner <mattst88@gentoo.org>
CommitDate: 2022-04-12 03:15:44 +0000

    mail-client/claws-mail: Update for libcanberra USE=gtk2
    
    Bug: https://bugs.gentoo.org/774918
    Bug: https://bugs.gentoo.org/811531
    Signed-off-by: Matt Turner <mattst88@gentoo.org>

 .../{claws-mail-3.18.0-r2.ebuild => claws-mail-3.18.0-r3.ebuild}        | 2 +-
 .../{claws-mail-3.19.0.ebuild => claws-mail-3.19.0-r1.ebuild}           | 2 +-
 mail-client/claws-mail/claws-mail-9999.ebuild                           | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)