Created attachment 720846 [details] fontconfig.eselect This eselect module writes its links with absolute paths which include ${EROOT} prefixes. This results in broken links when using the file system mounted at ${ROOT} natively. I don't know where this module is hosted, so I'll just attach an entire updated file. The main fix is using the --relative argument to ln, which has been available for about a decade in coreutils. If that's not portable enough, I'd recommend dropping the ES_FONTCONFIG_DIRS variable so paths are predictable. It doesn't appear to be documented anywhere anyway. The file also updates syntax a bit to simplify it and adhere to modern Gentoo style conventions. I dropped its behavior of overriding system files if a file with the same name is in the current working directory, since it seems dangerous. That behavior could still be used by prefixing files with the "./" path (but I'd prefer to drop support for specifying directories as well so it only accepts the file names/indices as they are printed).
Can you add your signed-off-by in a comment so I can add this? I've just created a git repo for it too.
Signed-off-by: David Michael <fedora.dm0@gmail.com>
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/proj/eselect-fontconfig.git/commit/?id=f57b6d44c764b18c1bf9c8ceb0574aa7103f760d commit f57b6d44c764b18c1bf9c8ceb0574aa7103f760d Author: David Michael <fedora.dm0@gmail.com> AuthorDate: 2021-07-01 19:42:33 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2022-04-03 00:27:54 +0000 Use relative symlinks This eselect module writes its links with absolute paths which include ${EROOT} prefixes. This results in broken links when using the file system mounted at ${ROOT} natively. The main fix is using the --relative argument to ln, which has been available for about a decade in coreutils. (If that's not portable enough, I'd recommend dropping the ES_FONTCONFIG_DIRS variable so paths are predictable. It doesn't appear to be documented anywhere anyway.) The file also updates syntax a bit to simplify it and adhere to modern Gentoo style conventions. I dropped its behavior of overriding system files if a file with the same name is in the current working directory, since it seems dangerous. That behavior could still be used by prefixing files with the "./" path (but I'd prefer to drop support for specifying directories as well so it only accepts the file names/indices as they are printed). [sam: reformatted/gitified git message from Bugzilla comment] Closes: https://bugs.gentoo.org/799758 Signed-off-by: David Michael <fedora.dm0@gmail.com> Signed-off-by: Sam James <sam@gentoo.org> fontconfig.eselect | 106 ++++++++++++++++++++--------------------------------- 1 file changed, 40 insertions(+), 66 deletions(-)
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6a055eb96660122f43c15c32463d2aedd7580234 commit 6a055eb96660122f43c15c32463d2aedd7580234 Author: Sam James <sam@gentoo.org> AuthorDate: 2022-04-03 00:30:53 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2022-04-03 00:30:58 +0000 app-eselect/eselect-fontconfig: add 20220403 Closes: https://bugs.gentoo.org/799758 Thanks-to: David Michael <fedora.dm0@gmail.com> Signed-off-by: Sam James <sam@gentoo.org> app-eselect/eselect-fontconfig/Manifest | 1 + .../eselect-fontconfig-20220403.ebuild | 21 +++++++++++++++++++++ 2 files changed, 22 insertions(+)
