Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 783900 - net-im/zoom: uses weird name for icon file - zoom-videocam instead of zoom
Summary: net-im/zoom: uses weird name for icon file - zoom-videocam instead of zoom
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Ulrich Müller
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-04-18 20:08 UTC by Aisha Tammy
Modified: 2021-12-28 13:10 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Aisha Tammy 2021-04-18 20:08:51 UTC
It causes many custom themes to not work in Gentoo.

Suggested solution: change icon name to 'zoom' in the ebuild - https://gitweb.gentoo.org/repo/gentoo.git/tree/net-im/zoom/zoom-5.6.13632.0328.ebuild#n68

thanks!
Comment 1 Andreas Sturmlechner gentoo-dev 2021-04-18 20:14:52 UTC
'zoom' is to generic and clashes with system icons.
Comment 2 Ulrich Müller gentoo-dev 2021-04-19 07:43:22 UTC
(In reply to Aisha Tammy from comment #0)
> It causes many custom themes to not work in Gentoo.

Please be more specific. Which custom theme package exactly, and how can the problem be reproduced?
Comment 3 Aisha Tammy 2021-04-19 13:39:27 UTC
@ulm, yes giving more information here.

The two largest ones tested from inside ::gentoo repository

x11-themes/papirus-icon-theme
x11-themes/numix-icon-theme

More ones tested from gnome-look or kde-look 

hey icon theme - https://www.gnome-look.org/p/1330383/
oie icon theme - https://store.kde.org/p/1299058/
candy icon theme - https://github.com/EliverLara/candy-icons

How to test: Install and enable any of these icon themes and the zoom icon still shows the stock icon, and not the zoom icon from these themes (it exists and is called zoom.svg or Zoom.svg)

If zoom.svg is too generic, maybe Zoom.svg ?
Comment 4 Ulrich Müller gentoo-dev 2021-04-19 14:20:10 UTC
(In reply to Aisha Tammy from comment #3)
> @ulm, yes giving more information here.
> 
> The two largest ones tested from inside ::gentoo repository
> 
> x11-themes/papirus-icon-theme
> x11-themes/numix-icon-theme

AFAICS, papirus-icon-theme installs Zoom.svg, with zoom-desktop.svg and zoom-icon.svg as symbolic links to it.

For numix-icon-theme I see only a zoom.svg in actions/ which is an image of a magnifying glass (so it's the generic icon for the zoom action).

> If zoom.svg is too generic, maybe Zoom.svg ?

I wouldn't bet that the name is always resolved in a case-sensitive manner, and I don't see any other mixed case filename in /usr/share/icons/hicolor/scalable/apps/ on my system.

How about installing it as zoom-icon.svg which would agree with one of the papirus names?
Comment 5 Michael 'veremitz' Everitt 2021-04-19 14:33:52 UTC
Would something like 'zoom-app' or 'zoom-application' (more correctly) be a good idea here? (suffixed appropriately..)
Comment 6 Aisha Tammy 2021-04-19 14:46:24 UTC
> How about installing it as zoom-icon.svg which would agree with one of the
> papirus names?

zoom-icon.svg sounds good with me!
Comment 7 Ulrich Müller gentoo-dev 2021-04-19 15:49:11 UTC
(In reply to Michael 'veremitz' Everitt from comment #5)
> Would something like 'zoom-app' or 'zoom-application' (more correctly) be a
> good idea here? (suffixed appropriately..)

Everyone would have to agree to that name (x11-themes/papirus-icon-theme doesn't, to start with).
Comment 8 Ulrich Müller gentoo-dev 2021-04-19 16:01:39 UTC
There actually is a spec for icon names: 
https://specifications.freedesktop.org/icon-naming-spec/icon-naming-spec-latest.html#guidelines

Specifically, uppercase letters are not allowed, and the icon name must be "the same as the executable for running the application". Obviously we cannot do that because zoom.svg clashes with an action icon.

(In reply to Aisha Tammy from comment #6)
> zoom-icon.svg sounds good with me!

Yes, let's go for that one.
Comment 9 Larry the Git Cow gentoo-dev 2021-04-19 16:20:23 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f80f30edf196487334884d18a0fbc9b85b9f2c13

commit f80f30edf196487334884d18a0fbc9b85b9f2c13
Author:     Ulrich Müller <ulm@gentoo.org>
AuthorDate: 2021-04-19 16:17:08 +0000
Commit:     Ulrich Müller <ulm@gentoo.org>
CommitDate: 2021-04-19 16:20:06 +0000

    net-im/zoom: Version bump to 5.6.16775.0418
    
    Install icon as "zoom-icon" instead of "zoom-videocam".
    
    Closes: https://bugs.gentoo.org/783900
    Package-Manager: Portage-3.0.18, Repoman-3.0.3
    Signed-off-by: Ulrich Müller <ulm@gentoo.org>

 net-im/zoom/Manifest                   |   1 +
 net-im/zoom/zoom-5.6.16775.0418.ebuild | 151 +++++++++++++++++++++++++++++++++
 2 files changed, 152 insertions(+)

Additionally, it has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b5fd1da09ed834bac78d66a38db7790494faa71c

commit b5fd1da09ed834bac78d66a38db7790494faa71c
Author:     Ulrich Müller <ulm@gentoo.org>
AuthorDate: 2021-04-19 16:18:54 +0000
Commit:     Ulrich Müller <ulm@gentoo.org>
CommitDate: 2021-04-19 16:20:07 +0000

    net-im/zoom: Install icon as "zoom-icon" instead of "zoom-videocam"
    
    Bug: https://bugs.gentoo.org/783900
    Package-Manager: Portage-3.0.18, Repoman-3.0.3
    Signed-off-by: Ulrich Müller <ulm@gentoo.org>

 ...oom-5.4.53391.1108-r2.ebuild => zoom-5.4.53391.1108-r3.ebuild} | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)