Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 773106 - x11-plugins/purple-facebook snapshot
Summary: x11-plugins/purple-facebook snapshot
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it
URL:
Whiteboard:
Keywords: PATCH, PMASKED
Depends on:
Blocks:
 
Reported: 2021-02-26 18:14 UTC by Gabriel
Modified: 2022-03-02 12:26 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
purple-facebook ebuild (purple-facebook-20210226.ebuild,1.09 KB, text/plain)
2021-02-26 18:14 UTC, Gabriel
Details
patch file to prevent purple-facebook from running hg at build time (purple-facebook-20210226-no-hg-while-compile.patch,690 bytes, patch)
2021-02-26 18:15 UTC, Gabriel
Details | Diff
purple-facebook-0.9.6-1a6711f.patch (purple-facebook-0.9.6-1a6711f.patch,3.79 KB, patch)
2021-06-06 15:27 UTC, Balint SZENTE
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gabriel 2021-02-26 18:14:40 UTC
Created attachment 688509 [details]
purple-facebook ebuild

I'm attaching an ebuild inspired on the 2019 purple-facebook one, but that essentially takes a snapshot of 2021-02-26.

In a nutshell, the 2019 purple-facebook plugin for Pidgin hasn't worked for a while for several reasons that are irrelevant to this request.

The ebuild I'm attaching upgrades the plugin to a version that with those problems (so far) - essentially it allows you to continue using Pidgin for Facebook Messenger chats in its restricted way.

There are several things to consider with this ebuild:
- I am still not too experienced writing ebuilds, so any suggestion to improve it will be welcome indeed
- Despite the fact that the previous versions appeared to be a snapshot, they are not, and they rely on a release being done by purple-facebook. Such release hasn't happened since 2019 or thereabouts, so this ebuild now pulls code from git and hg
- Why git AND hg, if purple-facebook is on git? (I hear you say). purple-facebook wants to `hg clone` a revision of pidgin. It gets worse: not any pidgin, but some revision within the 3.x code (thanks sam for helping figuring this out).
- Why 3.x if this plugin is for 2.x? (I also hear you say). Basically purple-facebook has relied on 3.x pidgin code since around 2017 to work with 2.x. I don't know why, I stopped looking.
- With this context, the ebuild uses the mercurial eclass to do what otherwise purple-facebook would wish to do, therefore it's got a git revision and an hg revision for both resources.
- It also contains a patch to update.sh to stop it from even considering running hg, but allowing to do everything else (it applies a bunch of patches - I don't know what they are, I stopped looking - see above).
- I also remove the build dependency for pidgin and left it as a run dependency for correctness.
Comment 1 Gabriel 2021-02-26 18:15:21 UTC
Created attachment 688512 [details, diff]
patch file to prevent purple-facebook from running hg at build time
Comment 2 Balint SZENTE 2021-06-06 15:27:32 UTC
Created attachment 713973 [details, diff]
purple-facebook-0.9.6-1a6711f.patch

Because I don't want to install extra dependency (mercurial) and the plugin's build system is utterly broken, I made a different approach.

I made a new patch which contains all upstream changes until 1a6711f, that applies over the original 0.9.6 source tarball.

So just drop this file in

/etc/portage/patches/x11-plugins/purple-facebook-20190113

and rebuild the original x11-plugins/purple-facebook-20190113 package.
Comment 3 Larry the Git Cow gentoo-dev 2022-03-02 12:26:46 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8bc00401647630565e75ea688ef0985d09af94f8

commit 8bc00401647630565e75ea688ef0985d09af94f8
Author:     Jakov Smolić <jsmolic@gentoo.org>
AuthorDate: 2022-03-02 12:22:22 +0000
Commit:     Jakov Smolić <jsmolic@gentoo.org>
CommitDate: 2022-03-02 12:26:11 +0000

    x11-plugins/purple-facebook: treeclean
    
    Closes: https://bugs.gentoo.org/830331
    Closes: https://bugs.gentoo.org/769719
    Closes: https://bugs.gentoo.org/773106
    Signed-off-by: Jakov Smolić <jsmolic@gentoo.org>

 profiles/package.mask                              |  5 ----
 x11-plugins/purple-facebook/Manifest               |  3 ---
 x11-plugins/purple-facebook/metadata.xml           |  8 -------
 .../purple-facebook-20170608.ebuild                | 27 ----------------------
 .../purple-facebook-20170831.ebuild                | 27 ----------------------
 .../purple-facebook-20190113.ebuild                | 27 ----------------------
 6 files changed, 97 deletions(-)