Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 771162 - net-print/cups-2.3.3-r2: doesn't respect unset LINGUAS variable
Summary: net-print/cups-2.3.3-r2: doesn't respect unset LINGUAS variable
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Printing Team
URL: https://www.gentoo.org/support/news-i...
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2021-02-17 21:12 UTC by i.Dark_Templar
Modified: 2021-10-28 09:49 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
cups.ebuild.patch (cups-ebuild.patch,916 bytes, patch)
2021-02-21 07:23 UTC, i.Dark_Templar
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description i.Dark_Templar 2021-02-17 21:12:23 UTC
According to linked gentoo news item, "An unset value (of LINGUAS variable) means all available ... language translations are built and installed". In case of net-print/cups-2.3.3-r2 this doesn't hold true.

Reproducible: Always

Steps to Reproduce:
1. ensure LINGUAS is not set in portage configs
2. emerge -1 net-print/cups
Actual Results:  
No cups translations are installed

Expected Results:  
All cups translations are installed

$ emerge --info cups
Portage 3.0.13 (python 3.8.7-final-0, default/linux/amd64/17.1/desktop, gcc-9.3.0, glibc-2.32-r6, 5.4.97-gentoo.54 x86_64)
=================================================================
                         System Settings
=================================================================
System uname: Linux-5.4.97-gentoo.54-x86_64-Intel-R-_Core-TM-_i5-6500_CPU_@_3.20GHz-with-glibc2.2.5
KiB Mem:    16352912 total,   6649828 free
KiB Swap:    4192252 total,   4192252 free
Timestamp of repository gentoo: Wed, 17 Feb 2021 00:45:01 +0000
sh bash 5.0_p18
ld GNU ld (Gentoo 2.35.1 p2) 2.35.1
app-shells/bash:          5.0_p18::gentoo
dev-lang/perl:            5.30.3::gentoo
dev-lang/python:          2.7.18-r6::gentoo, 3.8.7-r1::gentoo, 3.9.1-r1::gentoo
dev-util/cmake:           3.18.5::gentoo
dev-util/pkgconfig:       0.29.2::gentoo
sys-apps/baselayout:      2.7::gentoo
sys-apps/openrc:          0.42.1-r1::gentoo
sys-apps/sandbox:         2.20::gentoo
sys-devel/autoconf:       2.13-r1::gentoo, 2.69-r5::gentoo
sys-devel/automake:       1.13.4-r2::gentoo, 1.16.2-r1::gentoo
sys-devel/binutils:       2.35.1-r1::gentoo
sys-devel/gcc:            9.3.0-r2::gentoo
sys-devel/gcc-config:     2.3.2-r1::gentoo
sys-devel/libtool:        2.4.6-r6::gentoo
sys-devel/make:           4.3::gentoo
sys-kernel/linux-headers: 5.4-r1::gentoo (virtual/os-headers)
sys-libs/glibc:           2.32-r6::gentoo
Repositories:

gentoo
    location: /usr/portage
    sync-type: webrsync
    sync-uri: https://mirror.yandex.ru/gentoo-distfiles/
    priority: -1000
    sync-webrsync-verify-signature: true

dt-overlay-crossdev
    location: /var/db/repos/dt-overlay-crossdev
    masters: gentoo
    priority: 50

dt-overlay-patches
    location: /var/lib/layman/dt-overlay-patches
    sync-type: laymansync
    sync-uri: https://github.com/iDarkTemplar/dt-overlay-patches.git
    masters: gentoo
    priority: 50

dt-overlay-private
    location: /var/db/repos/dt-overlay-private
    masters: gentoo
    priority: 50

dt-overlay-public
    location: /var/lib/layman/dt-overlay-public
    sync-type: laymansync
    sync-uri: https://github.com/iDarkTemplar/dt-overlay-public.git
    masters: gentoo
    priority: 50

rion
    location: /var/lib/layman/rion
    sync-type: laymansync
    sync-uri: https://github.com/rion-overlay/rion-overlay.git
    masters: gentoo
    priority: 50

steam-overlay
    location: /var/lib/layman/steam-overlay
    sync-type: laymansync
    sync-uri: https://github.com/anyc/steam-overlay.git
    masters: gentoo
    priority: 50

tastytea
    location: /var/lib/layman/tastytea
    sync-type: laymansync
    sync-uri: https://schlomp.space/tastytea/overlay.git
    masters: gentoo
    priority: 50

Installed sets: @alsa, @archive-tools, @audacious, @bootloader, @devel-packages, @devel-tools, @devel-tools-x11, @fcitx, @filesystem-tools, @filesystem-tools-android, @fonts, @fonts-extra, @fortune, @gstreamer, @hardware-tools, @hardware-tools-x11, @ibus, @image-tools, @kde5, @language-tools, @mail-server, @media, @media-converters, @mingw, @network-analyzers, @network-tools, @network-tools-extra, @opengl-devel, @opengl-utils, @pidgin, @portage-tools, @portage-tools-dev, @portage-tools-extra, @power-utils, @printers, @psi, @pulseaudio, @qt5-meta, @qt6-meta, @system-admin-utils, @system-admin-utils-extra, @system-daemons, @system-daemons-extra, @system-utils, @system-utils-extra, @tesseract, @text-utils, @virtualbox, @vpn, @wine, @x11-core, @x11-extras, @x11-utils
ACCEPT_KEYWORDS="amd64"
ACCEPT_LICENSE="* -@EULA"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-march=native -O2 -pipe -fomit-frame-pointer -fwrapv"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/lib64/libreoffice/program/sofficerc /usr/share/config /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c"
CXXFLAGS="-march=native -O2 -pipe -fomit-frame-pointer -fwrapv"
DISTDIR="/usr/portage/distfiles"
EMERGE_DEFAULT_OPTS="--with-bdeps=y --binpkg-respect-use=y --autounmask=n --complete-graph=y --keep-going"
ENV_UNSET="CARGO_HOME DBUS_SESSION_BUS_ADDRESS DISPLAY GOBIN GOPATH PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR"
FCFLAGS="-O2 -pipe"
FEATURES="binpkg-docompress binpkg-dostrip binpkg-logs distlocks ebuild-locks fakeroot fixlafiles ipc-sandbox merge-sync multilib-strict network-sandbox news parallel-fetch pid-sandbox preserve-libs protect-owned qa-unresolved-soname-deps sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-O2 -pipe"
GENTOO_MIRRORS="http://mirror.yandex.ru/gentoo-distfiles/ http://mirror.leaseweb.com/gentoo/ http://mirror.netcologne.de/gentoo/ http://trumpetti.atm.tut.fi/gentoo/ ftp://mirror.yandex.ru/gentoo-distfiles/ http://mirror.bytemark.co.uk/gentoo/ http://gentoo.supp.name/ http://mirror.eu.oneandone.net/linux/distributions/gentoo/gentoo/ http://ftp-stud.hs-esslingen.de/pub/Mirrors/gentoo/ http://mirrors.soeasyto.com/distfiles.gentoo.org/"
INSTALL_MASK="     /etc/systemd /lib*/systemd /usr/lib*/systemd /usr/lib*/python*/test "
LANG="ru_RU.utf8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
MAKEOPTS="-j9"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/var/tmp"
USE="X a52 aac acl acpi alsa amd64 amr apm ares bash-completion bidi bluetooth bluray branding bzip2 c++0x cairo caps cdda cdio cdr cleartype cli cracklib crypt cue cups cxx dbus designer dga dirac dri dts dvd dvdr elogind emboss encode exif faad fbcon fcitx4 ffmpeg filecaps flac fontconfig fontforge freetype fribidi gif gme gmp gpm gtk gtkstyle gui ibus iconv icu idn imlib inotify ipv6 jadetex jpeg kde lcms libass libdvdcss libglvnd libtirpc lzma lzo mad matroska midi mmap mng mp3 mp4 mpeg multilib ncurses network nfs nls nptl offensive ogg openal opengl openmp opus pam pango pch pcmcia pcntl pcre pdf pic plasma plymouth png policykit posix postproc ppds private-headers projectm pulseaudio qml qt5 raw readline schroedinger seccomp sftp sndfile sockets spell split-usr ssl startup-notification svg system-cairo system-harfbuzz system-icu system-jpeg system-libevent system-libvpx system-sqlite tcpd tga theora threads tiff truetype udev udisks unicode upower usb utils vaapi vdpau vorbis vpx vulkan wavpack wma wxwidgets x264 xattr xcb xcomposite xft xinerama xpm xscreensaver xv xvid zlib zstd" ABI_X86="64 32" ADA_TARGET="gnat_2018" ALSA_CARDS="hda-intel" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon sheets words" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="aes f16c mmx mmxext pclmul popcnt sse sse2 sse3 sse4_1 sse4_2 ssse3" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock greis isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="evdev" KERNEL="linux" L10N="ru en" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LUA_SINGLE_TARGET="lua5-1" LUA_TARGETS="lua5-1" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php7-3 php7-4" POSTGRES_TARGETS="postgres10 postgres11" PYTHON_SINGLE_TARGET="python3_8" PYTHON_TARGETS="python3_8" QEMU_SOFTMMU_TARGETS="i386 x86_64" QEMU_USER_TARGETS="i386 x86_64" RUBY_TARGETS="ruby26" SANE_BACKENDS="hp" USERLAND="GNU" VIDEO_CARDS="vesa vga nvidia" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CC, CPPFLAGS, CTARGET, CXX, LC_ALL, LINGUAS, PORTAGE_BINHOST, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS

=================================================================
                        Package Settings
=================================================================

net-print/cups-2.3.3-r2::gentoo was built with the following:
USE="X acl dbus pam ssl threads usb -debug -kerberos -lprng-compat (-selinux) -static-libs -systemd -xinetd -zeroconf" ABI_X86="32 (64) (-x32)"



LINGUAS is unset, as may be seen above.

Here are current lines from ebuild checking and using LINGUAS:

https://github.com/gentoo/gentoo/blob/b20b519aff805201e83a3af9c890bc14f41260cd/net-print/cups/cups-2.3.3-r2.ebuild#L153-L170

And here are lines from build log:

 [32;01m*[0m abi_x86_32.x86: running multilib-minimal_abi_src_configure
 [32;01m*[0m LINGUAS=""
 * econf: updating cups-2.3.3-abi_x86_64.amd64/config.sub with /usr/share/gnuconfig/config.sub
 * econf: updating cups-2.3.3-abi_x86_64.amd64/config.guess with /usr/share/gnuconfig/config.guess
 * econf: updating cups-2.3.3-abi_x86_32.x86/config.sub with /usr/share/gnuconfig/config.sub
 * econf: updating cups-2.3.3-abi_x86_32.x86/config.guess with /usr/share/gnuconfig/config.guess
 * econf: updating cups-2.3.3/config.sub with /usr/share/gnuconfig/config.sub
 * econf: updating cups-2.3.3/config.guess with /usr/share/gnuconfig/config.guess
./configure --prefix=/usr --build=i686-pc-linux-gnu --host=i686-pc-linux-gnu --mandir=/usr/share/man --infodir=/usr/share/info --datadir=/usr/share --sysconfdir=/etc --localstatedir=/var/lib --docdir=/usr/share/doc/cups-2.3.3-r2 --htmldir=/usr/share/doc/cups-2.3.3-r2/html CC=x86_64-pc-linux-gnu-gcc -m32 CXX=x86_64-pc-linux-gnu-g++ -m32 KRB5CONFIG=/usr/bin/i686-pc-linux-gnu-krb5-config --libdir=/usr/lib --localstatedir=/var --with-exe-file-perm=755 --with-rundir=/run/cups --with-cups-user=lp --with-cups-group=lp --with-docdir=/usr/share/cups/html --with-languages= --with-system-groups=lpadmin --with-xinetd=/etc/xinetd.d --disable-acl --enable-dbus --disable-debug --disable-debug-guards --disable-debug-printfs --disable-gssapi --disable-pam --enable-static --enable-threads --enable-gnutls --disable-systemd --disable-libusb --disable-avahi --disable-dnssd --disable-libpaper

Empty $LINGUAS value is passed into --with-languages= argument, and it leads to all translations installation being skipped.

For behaviour described in $URL to be achieved, if LINGUAS is unset, --with-languages= argument must be skipped. In that case, current cups version will build and install all available translations.
Comment 1 i.Dark_Templar 2021-02-21 07:23:49 UTC
Created attachment 687825 [details, diff]
cups.ebuild.patch

This patch fixes issue for me. Diff:

--- /usr/portage/net-print/cups/cups-2.3.3-r2.ebuild    2021-01-22 18:09:17.000000000 +0300
+++ net-print/cups/cups-2.3.3-r2.ebuild 2021-02-20 20:43:49.846276455 +0300
@@ -150,8 +150,6 @@
 multilib_src_configure() {
        export DSOFLAGS="${LDFLAGS}"
 
-       einfo LINGUAS=\"${LINGUAS}\"
-
        # explicitly specify compiler wrt bug 524340
        #
        # need to override KRB5CONFIG for proper flags
@@ -167,7 +165,6 @@
                --with-cups-user=lp
                --with-cups-group=lp
                --with-docdir="${EPREFIX}"/usr/share/cups/html
-               --with-languages="${LINGUAS}"
                --with-system-groups=lpadmin
                --with-xinetd="${EPREFIX}"/etc/xinetd.d
                $(multilib_native_use_enable acl)
@@ -187,6 +184,12 @@
                $(multilib_is_native_abi && echo --enable-libpaper || echo --disable-libpaper)
        )
 
+       if [ -n "${LINGUAS+x}" ] ; then
+               myeconfargs+=(
+                       --with-languages="${LINGUAS}"
+               )
+       fi
+
        if tc-is-static-only; then
                myeconfargs+=(
                        --disable-shared
Comment 2 Larry the Git Cow gentoo-dev 2021-10-28 09:49:16 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8f6d1abb628f060426d6871edd65aa0ec70cee12

commit 8f6d1abb628f060426d6871edd65aa0ec70cee12
Author:     Pacho Ramos <pacho@gentoo.org>
AuthorDate: 2021-10-28 09:49:01 +0000
Commit:     Pacho Ramos <pacho@gentoo.org>
CommitDate: 2021-10-28 09:49:13 +0000

    net-print/cups: Multiple bug fixes
    
    - Fix missing dep on avahi[dbus] (#695438)
    - Ensure server path is always correct (#615438)
    - Recommend sys-auth/nss-mdns when needed (#634048)
    - Fix /run paths (#685308)
    - Respect empty LINGUAS (#771162)
    - Fix empty dirs handling (#798855)
    - Fix printing on some Samsung devices (#801316)
    - Apply other upstream accepted patches widely tested on Fedora and Debian.
    
    Closes: https://bugs.gentoo.org/695438
    Thanks-to: Mart Raudsepp
    Closes: https://bugs.gentoo.org/615438
    Thanks-to: Stefan Schmid
    Closes: https://bugs.gentoo.org/634048
    Closes: https://bugs.gentoo.org/685308
    Thanks-to: Bertrand Jacquin
    Closes: https://bugs.gentoo.org/771162
    Thanks-to: i.Dark_Templar
    Closes: https://bugs.gentoo.org/798855
    Thanks-to: Marco Scardovi (scardracs)
    Closes: https://bugs.gentoo.org/801316
    Thanks-to: Gentlenoob
    Thanks-to: mehw
    Thanks-to: Volkmar W. Pogatzki
    Package-Manager: Portage-3.0.28, Repoman-3.0.3
    Signed-off-by: Pacho Ramos <pacho@gentoo.org>

 net-print/cups/cups-2.3.3_p2-r3.ebuild             | 326 +++++++++++++++++++++
 .../files/cups-2.3.3-enforcing-read-limits.patch   |  29 ++
 .../cups/files/cups-2.3.3-ipp-retry-validate.patch |  43 +++
 net-print/cups/files/cups-2.3.3-manpage.patch      |  23 ++
 net-print/cups/files/cups-2.3.3-timeout.patch      |  26 ++
 net-print/cups/files/cupsd.init.d-r4               |  22 ++
 6 files changed, 469 insertions(+)