This line should be conditional on !systemd: https://github.com/gentoo/gentoo/blob/79ca32d4bc3f86dc0ec288a223241f26143ea78c/x11-base/xorg-server/xorg-server-1.20.10-r1.ebuild#L103 The xdm package provides xdm.service for systemd users.
The scripts are also not needed if you don't have a display manager. The news item makes it sound like the migration requires a manual step: >To update to the new DM init scripts, you need to manually add the package in your @world set Thus the dependency on gui-libs/display-manager-init should probably be removed altogether, and replaced with an einfo when emerging xorg-server.
(In reply to Jeffrey Lin from comment #1) > The scripts are also not needed if you don't have a display manager. The > news item makes it sound like the migration requires a manual step: > > >To update to the new DM init scripts, you need to manually add the package in your @world set > > Thus the dependency on gui-libs/display-manager-init should probably be > removed altogether, and replaced with an einfo when emerging xorg-server. The news item mentions this is going to happen in next version bump.
Please don't add random entries to CC. (In reply to Jeffrey Lin from comment #1) > Thus the dependency on gui-libs/display-manager-init should probably be > removed altogether, and replaced with an einfo when emerging xorg-server. Even with a news item you don't want to introduce a hard break for those not paying enough attention if you can easily avoid it.
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8122607bc6dc30365b46441412852c3cbdd613fd commit 8122607bc6dc30365b46441412852c3cbdd613fd Author: Jason A. Donenfeld <zx2c4@gentoo.org> AuthorDate: 2021-02-01 14:38:43 +0000 Commit: Jason A. Donenfeld <zx2c4@gentoo.org> CommitDate: 2021-02-01 14:38:43 +0000 x11-base/xorg-server: conditionalize display-manager-init dependency This was discussed and ack'd by sam and epsilonKNOT on IRC. Closes: https://bugs.gentoo.org/768024 Package-Manager: Portage-3.0.14, Repoman-3.0.2 Signed-off-by: Jason A. Donenfeld <zx2c4@gentoo.org> x11-base/xorg-server/xorg-server-1.20.10-r1.ebuild | 4 ++-- x11-base/xorg-server/xorg-server-9999.ebuild | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-)
*** Bug 785748 has been marked as a duplicate of this bug. ***
(In reply to Larry the Git Cow from comment #4) > The bug has been closed via the following commit(s): > > https://gitweb.gentoo.org/repo/gentoo.git/commit/ > ?id=8122607bc6dc30365b46441412852c3cbdd613fd > > commit 8122607bc6dc30365b46441412852c3cbdd613fd > Author: Jason A. Donenfeld <zx2c4@gentoo.org> > AuthorDate: 2021-02-01 14:38:43 +0000 > Commit: Jason A. Donenfeld <zx2c4@gentoo.org> > CommitDate: 2021-02-01 14:38:43 +0000 > > x11-base/xorg-server: conditionalize display-manager-init dependency > > This was discussed and ack'd by sam and epsilonKNOT on IRC. > > Closes: https://bugs.gentoo.org/768024 > Package-Manager: Portage-3.0.14, Repoman-3.0.2 > Signed-off-by: Jason A. Donenfeld <zx2c4@gentoo.org> > > x11-base/xorg-server/xorg-server-1.20.10-r1.ebuild | 4 ++-- > x11-base/xorg-server/xorg-server-9999.ebuild | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) I'm sorry if this isn't the place to discuss, but is it REALLY that necessary to have a display manager?
(In reply to houston from comment #6) > I'm sorry if this isn't the place to discuss, but is it REALLY that > necessary to have a display manager? You didn't seem to care when the files that gui-libs/display-manager-init installs were unconditionally installed by xorg-server. Read this bug. Moving this dependency somewhere else is a process.
(In reply to Andreas Sturmlechner from comment #7) > (In reply to houston from comment #6) > > I'm sorry if this isn't the place to discuss, but is it REALLY that > > necessary to have a display manager? > You didn't seem to care when the files that gui-libs/display-manager-init > installs were unconditionally installed by xorg-server. > > Read this bug. Moving this dependency somewhere else is a process. Maybe I should've replied to comment #3 instead. What do you mean by "hard break"? Is it going to become completely optional in the future, and who would it affect if having a display manager weren't a mandatory part of installing xorg-server? Also I "didn't care" because I'm just now finding out about it.
Some compromise may be to add "display-manager-init" local USE flag: RDEPEND="${CDEPEND} - !systemd? ( gui-libs/display-manager-init ) + display-manager-init? ( gui-libs/display-manager-init ) targets/desktop/package.use:x11-base/xorg-server display-manager-init targets/systemd/package.use:x11-base/xorg-server -display-manager-init So it would be enabled in desktop profiles except systemd profiles.
We're not going to lose our heads over a few kB of text files that have always been there and instead proceed as planned with slowly pushing it into the DMs instead.
