Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 766704 - app-admin/conky-1.11.6-r2 shows incorrect network speed
Summary: app-admin/conky-1.11.6-r2 shows incorrect network speed
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Daniel Pielmeier
URL: https://github.com/brndnmtthws/conky/...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-01-23 17:17 UTC by Alex Efros
Modified: 2021-03-26 22:22 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Efros 2021-01-23 17:17:25 UTC
I've referenced upstream issue with details (in short conky shows 2-3 times lower network speed than actual value).

As 1.10.8-r9 doesn't have this issue it looks like 1.11.6-r2 shouldn't be marked stable yet.
Comment 1 Daniel Pielmeier gentoo-dev 2021-01-24 16:17:06 UTC
There are always bugs. So if there is only a stable version if there are no open bugs then there would be no stable versions at all.

Also I don't know what to do here as there is no real fix until now except workarounds which need changing the configuration.
Comment 2 Alex Efros 2021-01-24 16:52:24 UTC
(In reply to Daniel Pielmeier from comment #1)
> There are always bugs. So if there is only a stable version if there are no
> open bugs then there would be no stable versions at all.

I'm not sure I get what you mean. Sure, there are always some bugs, but… there is a point in having both stable and unstable packages, and marking stable should mean something.

To me, this bug means major feature is broken, which worked just fine in previous version - and this sounds like a reason to not mark it stable yet or at least provide some solution to the issue - a patch, USE-flag or documented workaround at least.

> Also I don't know what to do here as there is no real fix until now except
> workarounds which need changing the configuration.

These workarounds (mentioned in upstream issue) doesn't actually work - they improve situation a bit, but doesn't fix it.

Maybe it's worth to add a patch to "… delete the line conky::run_all_callbacks(); in conky/src/conky.cc"? Upstream issue is opened for 1.5 year, so it's unlikely will be fixed soon. Even if this patch will break some new feature - it still makes sense because breaking something people doesn't use (yet) is less painful than breaking feature already used by nearly everyone. If people will complain about broken new feature - we can add USE-flag to control the patch, but I doubt this will be needed.
Comment 3 Daniel Pielmeier gentoo-dev 2021-01-24 17:03:09 UTC
Come on, It is just a small piece of software.

Also there are other reasons for marking a version stable. In this case the switch to slotted lua. At one point you have to make compromises.

Maybe the bug gets fixed quicker if you push upstream instead of me ;-)
Comment 4 Daniel Pielmeier gentoo-dev 2021-01-24 17:08:03 UTC
Furthermore the affected versions have been in testing for a long time but nobody reported this bug. Marking it stable detected it at last.
Comment 5 Alex Efros 2021-03-24 15:28:18 UTC
Upstream issue was just resolved, so chances are next released version won't have this bug! :)
Comment 6 Larry the Git Cow gentoo-dev 2021-03-25 15:14:16 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d45ea00b8514645bc07215085677ec5f25c708ae

commit d45ea00b8514645bc07215085677ec5f25c708ae
Author:     Daniel Pielmeier <billie@gentoo.org>
AuthorDate: 2021-03-25 15:13:14 +0000
Commit:     Daniel Pielmeier <billie@gentoo.org>
CommitDate: 2021-03-25 15:13:14 +0000

    app-admin/conky: Fix bug #766704.
    
    Thanks to Alex Efros for the report.
    
    Closes: https://bugs.gentoo.org/766704
    Package-Manager: Portage-3.0.13, Repoman-3.0.2
    Signed-off-by: Daniel Pielmeier <billie@gentoo.org>

 app-admin/conky/conky-1.12.1-r1.ebuild             | 194 +++++++++++++++++++++
 .../conky/files/conky-1.12.1-network-speed.patch   |  36 ++++
 2 files changed, 230 insertions(+)
Comment 7 Duncan 2021-03-26 22:22:49 UTC
Interesting.  I might have been affected as I run ~arch and just before the new year I merged conky, but after an initial trial I learned lua and put everything but the clock/date, including the network activity, in lua.[1]

So (unlike now-fixed bug #762163 which I reported) while I was likely affected in theory, with everything in lua I didn't see it and thus couldn't file a bug on it.  I remember wondering if the network was right before I switched the net reporting/graphing to lua, but shrugged it off as I was too busy trying to do the lua thing.

I actually found this bug while doing my routine scan of the proposed @world updates, saw a conky -rX bump, and checked the gentoo git log to see what was up.

---
[1] I wanted features like up/down network activity in a single graph, and separate cpu user/nice/system... reporting and stacked graphing instead of only all-in-one-usage, that conky doesn't support on its own, so I went to town with the lua support, and have something nice enough I'm thinking about putting it in a public git repo now.  What conky can do on its own might be a bit limited, but with its cairo and lua support, wow! And I'm rather impressed with the lua/cairo performance, too. =:^)