Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 762163 - app-admin/conky-1.12.1 USE=-ipv6 still needs conky-1.11.6-ipv6.patch
Summary: app-admin/conky-1.12.1 USE=-ipv6 still needs conky-1.11.6-ipv6.patch
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Daniel Pielmeier
URL: https://github.com/brndnmtthws/conky/...
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2020-12-28 06:44 UTC by Duncan
Modified: 2021-03-22 16:38 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
failing build log (app-admin:conky-1.11.6-r2:20201228-051357.log,47.71 KB, text/x-log)
2020-12-28 06:44 UTC, Duncan
Details
#ifdef BUILD_IPVv6 patch (app-admin.conky.ipv6.patch,503 bytes, patch)
2020-12-28 06:48 UTC, Duncan
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Duncan 2020-12-28 06:44:35 UTC
Created attachment 679948 [details]
failing build log

The problem apparently appears when the Linux kernel is built without IPv6 support and has already been reported upstream.  There's a patch in the issue there at 
https://github.com/brndnmtthws/conky/issues/1033 which I'll attach as well.

The patch is confirmed to allow building/merging conky.  This is a new conky install so I've not run-tested it yet, with or without the patch.

Here's my USE flags (after installation with the patch):

[ebuild   R    ] app-admin/conky-1.11.6-r2::gentoo  USE="X bundled-toluapp curl iconv lua-cairo math ncurses rss systemd truetype xinerama -apcupsd -cmus -doc -hddtemp -ical -imlib -iostats -ipv6 -irc -lua-imlib -lua-rsvg -moc -mpd -mysql -nano-syntax -nvidia -portmon -pulseaudio -thinkpad -vim-syntax -weather-metar -webserver -wifi -xmms2" LUA_SINGLE_TARGET="lua5-3" 0 KiB


First error:

FAILED: src/CMakeFiles/conky.dir/linux.cc.o 
/usr/lib/ccache/bin/x86_64-pc-linux-gnu-g++ -D_LARGEFILE64_SOURCE -D_POSIX_C_SOURCE=200809L -I/tmp/portage/app-admin/conky-1.11.6-r2/work/conky-1.11.6/3rdparty/toluapp/include -I. -I/usr/include/freetype2 -I/usr/include/lua5.3 -I/usr/include/libxml2 -Idata  -std=c++17 -std=gnu++17 -MD -MT src/CMakeFiles/conky.dir/linux.cc.o -MF src/CMakeFiles/conky.dir/linux.cc.o.d -o src/CMakeFiles/conky.dir/linux.cc.o -c /tmp/portage/app-admin/conky-1.11.6-r2/work/conky-1.11.6/src/linux.cc
../conky-1.11.6/src/linux.cc: In function 'void update_ipv6_net_stats()':
../conky-1.11.6/src/linux.cc:709:16: error: 'struct net_stat' has no member named 'v6addrs'; did you mean 'addrs'?
709 |     while (ns->v6addrs != nullptr) {
|                ^~~~~~~
|                addrs
Comment 1 Duncan 2020-12-28 06:48:27 UTC
Created attachment 679951 [details, diff]
#ifdef BUILD_IPVv6 patch
Comment 2 Duncan 2020-12-29 04:27:06 UTC
Two-point update:

* I've run conky with the built-in configuration now, and at least that works, so at least limited run-time tested.

* I've actually looked at the patched file and code now, and it's exactly one IPv6-specific callable #ifdefed (update_ipv6_net_stats, its single call site was already #ifdefed).  That wasn't clear from reading just the patch due to the elided section between the #ifdef and the #endif.  So no unwanted side effects would be expected.
Comment 3 Larry the Git Cow gentoo-dev 2021-01-13 14:56:44 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f3dd9a7af575a192da8c557d1259d362b773cb95

commit f3dd9a7af575a192da8c557d1259d362b773cb95
Author:     Daniel Pielmeier <billie@gentoo.org>
AuthorDate: 2021-01-13 14:56:18 +0000
Commit:     Daniel Pielmeier <billie@gentoo.org>
CommitDate: 2021-01-13 14:56:18 +0000

    app-admin/conky: Fix bug #762163.
    
    Thanks to Duncan for the report.
    
    Closes: https://bugs.gentoo.org/762163
    Package-Manager: Portage-3.0.12, Repoman-3.0.2
    Signed-off-by: Daniel Pielmeier <billie@gentoo.org>

 app-admin/conky/conky-1.11.6-r2.ebuild        |  3 ++-
 app-admin/conky/files/conky-1.11.6-ipv6.patch | 22 ++++++++++++++++++++++
 2 files changed, 24 insertions(+), 1 deletion(-)
Comment 4 Duncan 2021-03-21 18:33:20 UTC
Reopening/retitling for conky-1.12.1.  Same bug; same patch applies.

Status at the URL is closed with a March 2 commit pulling in the patch upstream, but it seems to have been after the 1.12.1 tagging.  So while it's needed with 1.12.1 it shouldn't be needed for whatever the next release is. =:^)

BTW, any chance of a live-git conky-9999 ebuild so I could follow upstream's commit-stream a bit closer?  If I create one of my own, is it worth submitting for the tree or would you prefer release-only in-tree?  Or is there an overlay with one already?
Comment 5 Daniel Pielmeier gentoo-dev 2021-03-21 19:37:51 UTC
You are correct. The release was first tagged and and then on the same day the patch was applied. So the new version still requires the patch. This was an oversight on my side.

I have a live ebuild for conky as well as for all other packages I maintain but I do not publish them to the tree. At the moment I don't intend to change this.
Comment 6 Duncan 2021-03-21 21:08:17 UTC
(In reply to Daniel Pielmeier from comment #5)
> I have a live ebuild for conky as well as for all other packages I maintain
> but I do not publish them to the tree. At the moment I don't intend to
> change this.

Thanks.  And well understood as public live packages are definitely a different workflow that many devs simply are not prepared to commit (hah! =^) to.

I can make a personal overlay live-git ebuild if I decide it's worth it.  Then I maintain it but am only responsible to myself for it, which is quite a different matter than being a maintainer responsible for a public one. =:^)
Comment 7 Larry the Git Cow gentoo-dev 2021-03-22 16:38:11 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=418162f21ba60d7bafb32d38d9f7d7c650c8cea0

commit 418162f21ba60d7bafb32d38d9f7d7c650c8cea0
Author:     Daniel Pielmeier <billie@gentoo.org>
AuthorDate: 2021-03-22 16:37:04 +0000
Commit:     Daniel Pielmeier <billie@gentoo.org>
CommitDate: 2021-03-22 16:37:39 +0000

    app-admin/conky: Add IPV6 patch to conky-1.12.1.
    
    Thanks to Duncan for the report.
    
    Closes: https://bugs.gentoo.org/762163
    Package-Manager: Portage-3.0.13, Repoman-3.0.2
    Signed-off-by: Daniel Pielmeier <billie@gentoo.org>

 app-admin/conky/conky-1.12.1.ebuild | 4 ++++
 1 file changed, 4 insertions(+)