Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 756382 - dev-db/redis-6.0.9 - [exception]: Executing test client: ERR Invalid argument 'yes' for CONFIG SET 'oom-score-adj' - Failed t o set current oom_score_adj
Summary: dev-db/redis-6.0.9 - [exception]: Executing test client: ERR Invalid argument...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Sam James
URL:
Whiteboard:
Keywords: PullRequest, TESTFAILURE
Depends on:
Blocks:
 
Reported: 2020-11-24 21:58 UTC by ernsteiswuerfel
Modified: 2022-06-12 20:36 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge --info (file_756382.txt,6.14 KB, text/plain)
2020-11-24 21:58 UTC, ernsteiswuerfel
Details
build.log (redis-6.0.9:20201124-192435.log,252.06 KB, text/plain)
2020-11-24 21:59 UTC, ernsteiswuerfel
Details
build.log (redis-6.0.9:20201126-152218.log,251.20 KB, text/x-log)
2020-11-26 15:28 UTC, ernsteiswuerfel
Details
emerge --info (file_756382.txt,6.09 KB, text/plain)
2020-11-26 15:29 UTC, ernsteiswuerfel
Details

Note You need to log in before you can comment on or make changes to this bug.
Description ernsteiswuerfel archtester 2020-11-24 21:58:31 UTC
Created attachment 674761 [details]
emerge --info

[...]
[exception]: Executing test client: ERR Invalid argument 'yes' for CONFIG SET 'oom-score-adj' - Failed t
o set current oom_score_adj. Check server logs..
ERR Invalid argument 'yes' for CONFIG SET 'oom-score-adj' - Failed to set current oom_score_adj. Check s
erver logs.
    while executing
"[srv $level "client"] {*}$args"
    (procedure "r" line 7)
    invoked from within
"r config set oom-score-adj yes"
    ("uplevel" body line 6)
    invoked from within
"uplevel 1 $code"
    (procedure "test" line 51)
    invoked from within
"test {CONFIG SET oom-score-adj works as expected} {
            set base [get_oom_score_adj]

            # Enable oom-score-adj, check defaults
     ..."
    ("uplevel" body line 13)
    invoked from within
"uplevel 1 $code "
    (procedure "start_server" line 3)
    invoked from within
"start_server {tags {"oom-score-adj"}} {
        proc get_oom_score_adj {{pid ""}} {
            if {$pid == ""} {
                set pid [srv 0 pid]
..."
    (file "tests/unit/oom-score-adj.tcl" line 5)
    invoked from within
"source $path"
    (procedure "execute_test_file" line 4)
    invoked from within
"execute_test_file $data"
    (procedure "test_client_main" line 10)
    invoked from within
"test_client_main $::test_server_port "
Comment 1 ernsteiswuerfel archtester 2020-11-24 21:59:40 UTC
Created attachment 674764 [details]
build.log
Comment 2 Tomáš Mózes 2020-11-25 19:58:42 UTC
Can you please test with FEATURES=-usersandbox?

>>> Source compiled.
>>> Test phase: dev-db/redis-6.0.9
You are emerging redis-6.0.9 with 'usersandbox' enabled. Expect some test failures or emerge with 'FEATURES=-usersandbox'!
Comment 3 ernsteiswuerfel archtester 2020-11-26 15:28:23 UTC
Re-tested with 'FEATURES=-usersandbox' but still the same test-error.
Comment 4 ernsteiswuerfel archtester 2020-11-26 15:28:46 UTC
Created attachment 675109 [details]
build.log
Comment 5 ernsteiswuerfel archtester 2020-11-26 15:29:08 UTC
Created attachment 675112 [details]
emerge --info
Comment 6 Petr Vaněk gentoo-dev 2022-06-10 15:42:47 UTC
I was able to reproduce it with the same set of FEATURES in dev-db/redis-6.0.16. It seems that 

  FEATURES="userpriv -usersandbox"

needs to be set this way in order to make this test work.
Comment 7 Larry the Git Cow gentoo-dev 2022-06-12 20:36:49 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6869d1ac8aa4ad0d4e9ce69066cb179ce3346f50

commit 6869d1ac8aa4ad0d4e9ce69066cb179ce3346f50
Author:     Petr Vaněk <arkamar@atlas.cz>
AuthorDate: 2022-06-10 16:28:18 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-06-12 20:36:38 +0000

    dev-db/redis: skip oom-score-adj related tests for some FEATURES
    
    oom-score-adj related unit tests fail when usersandbox or -userpriv
    FEATURES are set, therefore let's skip them. They were introduced as
    unit/oom-score-adj tests in 6.2.0 but they were backported to 6.0.7.
    Later, "CONFIG SET rollback on apply error" test was added in version
    7.0.0 which also tries to adjust OOM score.
    
    Closes: https://bugs.gentoo.org/756382
    Signed-off-by: Petr Vaněk <arkamar@atlas.cz>
    Closes: https://github.com/gentoo/gentoo/pull/25831
    Signed-off-by: Sam James <sam@gentoo.org>

 dev-db/redis/redis-6.0.16.ebuild   | 10 ++++++----
 dev-db/redis/redis-6.2.6.ebuild    | 10 ++++++----
 dev-db/redis/redis-6.2.7-r1.ebuild | 10 ++++++----
 dev-db/redis/redis-7.0.0-r1.ebuild | 16 ++++++++++++----
 dev-db/redis/redis-7.0.0.ebuild    | 16 ++++++++++++----
 dev-db/redis/redis-7.0.1.ebuild    | 16 ++++++++++++----
 6 files changed, 54 insertions(+), 24 deletions(-)