Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 743625 - x11-libs/libva-intel-media-driver-20.2.0: requires libva with USE X
Summary: x11-libs/libva-intel-media-driver-20.2.0: requires libva with USE X
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Media-video project
URL:
Whiteboard:
Keywords: PullRequest
: 670152 683164 (view as bug list)
Depends on:
Blocks: 733504
  Show dependency tree
 
Reported: 2020-09-19 20:29 UTC by David Heidelberg (okias)
Modified: 2021-01-04 16:59 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David Heidelberg (okias) 2020-09-19 20:29:32 UTC
Compilation failure:
x11-libs/libva-2.8.0:0/2::gentoo  USE="drm wayland -opengl -utils -vdpau -X" ABI_X86="(64) -32 (-x32)" VIDEO_CARDS="i965 intel -nouveau -nvidia"

Success:
x11-libs/libva-2.8.0:0/2::gentoo  USE="X drm wayland -opengl -utils -vdpau" ABI_X86="(64) -32 (-x32)" VIDEO_CARDS="i965 intel -nouveau -nvidia"

Difference in libva-intel-media-driver log:

/var/tmp/portage/x11-libs/libva-intel-media-driver-20.2.0/work/media-driver-intel-media-20.2.0/media_driver/linux/common/ddi/media_libva_putsurface_linux.h:31:10: fatal error: va/va_dricommon.h: No such file or directory
   31 | #include <va/va_dricommon.h>
      |          ^~~~~~~~~~~~~~~~~~~
compilation terminated.



Reproducible: Always
Comment 1 Pacho Ramos gentoo-dev 2020-12-01 17:56:42 UTC
*** Bug 670152 has been marked as a duplicate of this bug. ***
Comment 2 Pacho Ramos gentoo-dev 2020-12-01 17:56:51 UTC
*** Bug 683164 has been marked as a duplicate of this bug. ***
Comment 3 Karlson2k 2021-01-03 19:14:01 UTC
Upstream bug:
https://github.com/intel/media-driver/issues/405
Comment 4 Karlson2k 2021-01-04 15:55:31 UTC
libva-intel-media-driver CMake detects presence of X11 by detecting presence of X11 headers. If headers are found, CMake assumes that libva were compiled with X11 support and enable usage of all libva X11 features and headers.
This doesn't work on Gentoo as one can install X11 headers but compile libva without X11 support.

I've published a patch for fix it: https://github.com/gentoo/gentoo/pull/18933
This patch enforce use of X11 if USE flag X was set. Without X flag no X11 headers and/or features are used by libva-intel-media-driver.
Now the result of building libva-intel-media-driver package depends on the USE flags only.
Comment 5 Larry the Git Cow gentoo-dev 2021-01-04 16:59:48 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=77bf88d00121d5d23f550d91b168a0cbc917ec79

commit 77bf88d00121d5d23f550d91b168a0cbc917ec79
Author:     Karlson2k (Evgeny Grin) <k2k@narod.ru>
AuthorDate: 2021-01-03 19:04:46 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2021-01-04 16:50:50 +0000

    x11-libs/libva-intel-media-driver: added X USE flag
    
    This patch fixes ambiguous usage of X11 in the package.
    Before this patch the package tries to autodetect presence
    of X11 in the system and tries to use it if found. However,
    presence of X11 headers doesn't grantee that required
    packages (libva) were installed with X11 support.
    Now result of build depends on USE flags instead of
    presence/absence of X11 headers on the build system.
    
    Closes: https://bugs.gentoo.org/743625
    
    Signed-off-by: Karlson2k (Evgeny Grin) <k2k@narod.ru>
    Closes: https://github.com/gentoo/gentoo/pull/18933
    Signed-off-by: Sam James <sam@gentoo.org>

 ...va-intel-media-driver-20.2.0_x11_optional.patch | 16 ++++++++
 .../libva-intel-media-driver-20.1.1-r1.ebuild      | 43 +++++++++++++++++++++
 .../libva-intel-media-driver-20.2.0-r1.ebuild      | 45 ++++++++++++++++++++++
 3 files changed, 104 insertions(+)