Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 740420 - media-sound/picard-2.4.2 should NOT RDEPEND on dev-python/PyQt5[dbus]
Summary: media-sound/picard-2.4.2 should NOT RDEPEND on dev-python/PyQt5[dbus]
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal minor (vote)
Assignee: Gentoo Linux bug wranglers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-09-04 23:43 UTC by Julius
Modified: 2020-09-05 13:36 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Julius 2020-09-04 23:43:06 UTC
Based on https://bugs.gentoo.org/739550, https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=13e439d55a82931cfc7c777cdcef70a8f898944a added the dependency, but https://github.com/metabrainz/picard/pull/1535 made PyQt5.QtDBus optional (i.e. it's automatically used if present but ignored if not.) for the 2.4 release, so no RDPEND is required for media-sound/picard-2.4.2.

(I'm not sure what to do with 2.3. Either keep the RDEPEND, or patch.)
Comment 1 Miroslav Šulc gentoo-dev 2020-09-05 05:02:21 UTC
yesterday i tried to apply the patch but it failed so it would have to be modified to apply. or is there a patch that applies to 2.4.2?
Comment 2 Julius 2020-09-05 06:12:15 UTC
2.4 already contains the patch.

Hm. I thought the patch executable would warn you if you try to apply an already applied patch. Oh well.
Comment 3 Miroslav Šulc gentoo-dev 2020-09-05 06:51:40 UTC
i misunderstood you before. i will just drop the [dbus] and will verify it and commit.
Comment 4 Larry the Git Cow gentoo-dev 2020-09-05 06:56:23 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=bc7741807fc2268c02901352154333508c5e6ce9

commit bc7741807fc2268c02901352154333508c5e6ce9
Author:     Miroslav Šulc <fordfrog@gentoo.org>
AuthorDate: 2020-09-05 06:55:56 +0000
Commit:     Miroslav Šulc <fordfrog@gentoo.org>
CommitDate: 2020-09-05 06:56:16 +0000

    media-sound/picard: dropped [dbus] from dev-python/PyQt5
    
    Closes: https://bugs.gentoo.org/740420
    Package-Manager: Portage-3.0.5, Repoman-3.0.1
    Signed-off-by: Miroslav Šulc <fordfrog@gentoo.org>

 media-sound/picard/picard-2.4.2.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 5 Julius 2020-09-05 13:17:22 UTC
Awesome, thank you for the speedy fix (And sorry I wasn't able to explain it well).
Comment 6 Miroslav Šulc gentoo-dev 2020-09-05 13:36:36 UTC
np, the problem might be on this side in fact :-) thank you for filing the bug and providing the info :-)